Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
e3db5ebb
Unverified
Commit
e3db5ebb
authored
Sep 17, 2025
by
Michael Goin
Committed by
GitHub
Sep 17, 2025
Browse files
[CI Bugfix] Fix failing test_model_load_with_params tests due to tokenizer refactor (#25086)
Signed-off-by:
mgoin
<
mgoin64@gmail.com
>
parent
9d442b7c
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
6 deletions
+5
-6
tests/model_executor/test_model_load_with_params.py
tests/model_executor/test_model_load_with_params.py
+5
-6
No files found.
tests/model_executor/test_model_load_with_params.py
View file @
e3db5ebb
...
...
@@ -47,8 +47,8 @@ def test_model_loading_with_params(vllm_runner, monkeypatch):
assert
model_config
.
pooler_config
.
normalize
# asserts on the tokenizer loaded
assert
model_
tokenizer
.
tokenizer
_id
==
"BAAI/bge-base-en-v1.5"
assert
model_tokenizer
.
tokenizer
.
model_max_length
==
512
assert
model_
config
.
tokenizer
==
"BAAI/bge-base-en-v1.5"
assert
model_tokenizer
.
model_max_length
==
512
def
check_model
(
model
):
assert
isinstance
(
model
,
BertEmbeddingModel
)
...
...
@@ -87,8 +87,8 @@ def test_roberta_model_loading_with_params(vllm_runner, monkeypatch):
assert
model_config
.
pooler_config
.
normalize
# asserts on the tokenizer loaded
assert
model_
tokenizer
.
tokenizer
_id
==
"intfloat/multilingual-e5-base"
assert
model_tokenizer
.
tokenizer
.
model_max_length
==
512
assert
model_
config
.
tokenizer
==
"intfloat/multilingual-e5-base"
assert
model_tokenizer
.
model_max_length
==
512
def
check_model
(
model
):
assert
isinstance
(
model
,
RobertaEmbeddingModel
)
...
...
@@ -116,8 +116,7 @@ def test_facebook_roberta_model_loading_with_params(vllm_runner, monkeypatch):
output
=
vllm_model
.
embed
(
"Write a short story about a robot that"
" dreams for the first time.
\n
"
)
model_tokenizer
=
vllm_model
.
llm
.
llm_engine
.
tokenizer
assert
model_tokenizer
.
tokenizer_id
==
model_name
assert
vllm_model
.
llm
.
llm_engine
.
model_config
.
tokenizer
==
model_name
def
check_model
(
model
):
assert
isinstance
(
model
,
RobertaEmbeddingModel
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment