Unverified Commit e3db5ebb authored by Michael Goin's avatar Michael Goin Committed by GitHub
Browse files

[CI Bugfix] Fix failing test_model_load_with_params tests due to tokenizer refactor (#25086)


Signed-off-by: default avatarmgoin <mgoin64@gmail.com>
parent 9d442b7c
...@@ -47,8 +47,8 @@ def test_model_loading_with_params(vllm_runner, monkeypatch): ...@@ -47,8 +47,8 @@ def test_model_loading_with_params(vllm_runner, monkeypatch):
assert model_config.pooler_config.normalize assert model_config.pooler_config.normalize
# asserts on the tokenizer loaded # asserts on the tokenizer loaded
assert model_tokenizer.tokenizer_id == "BAAI/bge-base-en-v1.5" assert model_config.tokenizer == "BAAI/bge-base-en-v1.5"
assert model_tokenizer.tokenizer.model_max_length == 512 assert model_tokenizer.model_max_length == 512
def check_model(model): def check_model(model):
assert isinstance(model, BertEmbeddingModel) assert isinstance(model, BertEmbeddingModel)
...@@ -87,8 +87,8 @@ def test_roberta_model_loading_with_params(vllm_runner, monkeypatch): ...@@ -87,8 +87,8 @@ def test_roberta_model_loading_with_params(vllm_runner, monkeypatch):
assert model_config.pooler_config.normalize assert model_config.pooler_config.normalize
# asserts on the tokenizer loaded # asserts on the tokenizer loaded
assert model_tokenizer.tokenizer_id == "intfloat/multilingual-e5-base" assert model_config.tokenizer == "intfloat/multilingual-e5-base"
assert model_tokenizer.tokenizer.model_max_length == 512 assert model_tokenizer.model_max_length == 512
def check_model(model): def check_model(model):
assert isinstance(model, RobertaEmbeddingModel) assert isinstance(model, RobertaEmbeddingModel)
...@@ -116,8 +116,7 @@ def test_facebook_roberta_model_loading_with_params(vllm_runner, monkeypatch): ...@@ -116,8 +116,7 @@ def test_facebook_roberta_model_loading_with_params(vllm_runner, monkeypatch):
output = vllm_model.embed("Write a short story about a robot that" output = vllm_model.embed("Write a short story about a robot that"
" dreams for the first time.\n") " dreams for the first time.\n")
model_tokenizer = vllm_model.llm.llm_engine.tokenizer assert vllm_model.llm.llm_engine.model_config.tokenizer == model_name
assert model_tokenizer.tokenizer_id == model_name
def check_model(model): def check_model(model):
assert isinstance(model, RobertaEmbeddingModel) assert isinstance(model, RobertaEmbeddingModel)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment