Skip to content

GitLab

Unverified Commit d25877dd authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[BugFix] Avoid secondary error in ShmRingBuffer destructor (#6530)

parent 1c27d25f
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
vllm/distributed/device_communicators/shm_broadcast.py
View file @ d25877dd
...@@ -119,9 +119,10 @@ class ShmRingBuffer: ...@@ -119,9 +119,10 @@ class ShmRingBuffer:
) )
def __del__(self): def __del__(self):
self.shared_memory.close() if hasattr(self, "shared_memory"):
if self.is_creator: self.shared_memory.close()
self.shared_memory.unlink() if self.is_creator:
self.shared_memory.unlink()
@contextmanager @contextmanager
def get_data(self, current_idx: int): def get_data(self, current_idx: int):
...@@ -428,7 +429,6 @@ class MessageQueue: ...@@ -428,7 +429,6 @@ class MessageQueue:
def dequeue(self): def dequeue(self):
if self._is_local_reader: if self._is_local_reader:
overflow = False
with self.acquire_read() as buf: with self.acquire_read() as buf:
overflow = buf[0] == 1 overflow = buf[0] == 1
if not overflow: if not overflow:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment