Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
d1f7392c
Unverified
Commit
d1f7392c
authored
Dec 03, 2025
by
Micah Williamson
Committed by
GitHub
Dec 04, 2025
Browse files
[ROCm][CI] Fix v1/logits_processors failure on ROCm (#29927)
Signed-off-by:
Micah Williamson
<
micah.williamson@amd.com
>
parent
9ae3c55b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
16 deletions
+3
-16
tests/v1/logits_processors/test_custom_offline.py
tests/v1/logits_processors/test_custom_offline.py
+0
-5
tests/v1/logits_processors/test_custom_online.py
tests/v1/logits_processors/test_custom_online.py
+2
-10
tests/v1/logits_processors/utils.py
tests/v1/logits_processors/utils.py
+1
-1
No files found.
tests/v1/logits_processors/test_custom_offline.py
View file @
d1f7392c
# SPDX-License-Identifier: Apache-2.0
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
import
random
import
random
import
sys
from
typing
import
Any
from
typing
import
Any
import
pytest
import
pytest
...
@@ -10,7 +9,6 @@ from tests.utils import create_new_process_for_each_test
...
@@ -10,7 +9,6 @@ from tests.utils import create_new_process_for_each_test
from
tests.v1.logits_processors.utils
import
(
from
tests.v1.logits_processors.utils
import
(
DUMMY_LOGITPROC_ARG
,
DUMMY_LOGITPROC_ARG
,
DUMMY_LOGITPROC_FQCN
,
DUMMY_LOGITPROC_FQCN
,
DUMMY_LOGITPROC_MODULE
,
MAX_TOKENS
,
MAX_TOKENS
,
MODEL_NAME
,
MODEL_NAME
,
POOLING_MODEL_NAME
,
POOLING_MODEL_NAME
,
...
@@ -18,7 +16,6 @@ from tests.v1.logits_processors.utils import (
...
@@ -18,7 +16,6 @@ from tests.v1.logits_processors.utils import (
CustomLogitprocSource
,
CustomLogitprocSource
,
DummyLogitsProcessor
,
DummyLogitsProcessor
,
WrappedPerReqLogitsProcessor
,
WrappedPerReqLogitsProcessor
,
dummy_module
,
prompts
,
prompts
,
)
)
from
tests.v1.logits_processors.utils
import
entry_points
as
fake_entry_points
from
tests.v1.logits_processors.utils
import
entry_points
as
fake_entry_points
...
@@ -162,8 +159,6 @@ def test_custom_logitsprocs(monkeypatch, logitproc_source: CustomLogitprocSource
...
@@ -162,8 +159,6 @@ def test_custom_logitsprocs(monkeypatch, logitproc_source: CustomLogitprocSource
kwargs
:
dict
[
str
,
list
[
str
|
type
[
LogitsProcessor
]]]
=
{}
kwargs
:
dict
[
str
,
list
[
str
|
type
[
LogitsProcessor
]]]
=
{}
if
logitproc_source
==
CustomLogitprocSource
.
LOGITPROC_SOURCE_FQCN
:
if
logitproc_source
==
CustomLogitprocSource
.
LOGITPROC_SOURCE_FQCN
:
# Scenario: load logitproc based on fully-qualified class name (FQCN)
# Scenario: load logitproc based on fully-qualified class name (FQCN)
# Inject dummy module which defines logitproc
sys
.
modules
[
DUMMY_LOGITPROC_MODULE
]
=
dummy_module
kwargs
[
"logits_processors"
]
=
[
DUMMY_LOGITPROC_FQCN
]
kwargs
[
"logits_processors"
]
=
[
DUMMY_LOGITPROC_FQCN
]
elif
logitproc_source
==
CustomLogitprocSource
.
LOGITPROC_SOURCE_CLASS
:
elif
logitproc_source
==
CustomLogitprocSource
.
LOGITPROC_SOURCE_CLASS
:
# Scenario: load logitproc from provided class object
# Scenario: load logitproc from provided class object
...
...
tests/v1/logits_processors/test_custom_online.py
View file @
d1f7392c
...
@@ -14,11 +14,9 @@ from tests.utils import RemoteOpenAIServerCustom, create_new_process_for_each_te
...
@@ -14,11 +14,9 @@ from tests.utils import RemoteOpenAIServerCustom, create_new_process_for_each_te
from
tests.v1.logits_processors.utils
import
(
from
tests.v1.logits_processors.utils
import
(
DUMMY_LOGITPROC_ARG
,
DUMMY_LOGITPROC_ARG
,
DUMMY_LOGITPROC_FQCN
,
DUMMY_LOGITPROC_FQCN
,
DUMMY_LOGITPROC_MODULE
,
MAX_TOKENS
,
MAX_TOKENS
,
MODEL_NAME
,
MODEL_NAME
,
TEMP_GREEDY
,
TEMP_GREEDY
,
dummy_module
,
prompts
,
prompts
,
)
)
from
tests.v1.logits_processors.utils
import
entry_points
as
fake_entry_points
from
tests.v1.logits_processors.utils
import
entry_points
as
fake_entry_points
...
@@ -47,20 +45,14 @@ def _server_with_logitproc_entrypoint(
...
@@ -47,20 +45,14 @@ def _server_with_logitproc_entrypoint(
main
.
main
()
main
.
main
()
def
_server_with_logitproc_
module
(
def
_server_with_logitproc_
fqcn
(
env_dict
:
dict
[
str
,
str
]
|
None
,
env_dict
:
dict
[
str
,
str
]
|
None
,
model
:
str
,
model
:
str
,
vllm_serve_args
:
list
[
str
],
vllm_serve_args
:
list
[
str
],
)
->
None
:
)
->
None
:
"""Start vLLM server, inject module with dummy logitproc"""
"""Start vLLM server, inject module with dummy logitproc"""
# Patch `modules` to inject dummy logitproc module
from
vllm.entrypoints.cli
import
main
from
vllm.entrypoints.cli
import
main
sys
.
modules
[
DUMMY_LOGITPROC_MODULE
]
=
dummy_module
# fork is required for workers to see entrypoint patch
os
.
environ
[
"VLLM_WORKER_MULTIPROC_METHOD"
]
=
"fork"
if
env_dict
is
not
None
:
if
env_dict
is
not
None
:
os
.
environ
.
update
(
env_dict
)
os
.
environ
.
update
(
env_dict
)
...
@@ -99,7 +91,7 @@ def server(default_server_args, request, monkeypatch):
...
@@ -99,7 +91,7 @@ def server(default_server_args, request, monkeypatch):
if
request
.
param
:
if
request
.
param
:
# Launch server, append FQCN argument, inject dummy logitproc module
# Launch server, append FQCN argument, inject dummy logitproc module
args
=
default_server_args
+
request
.
param
args
=
default_server_args
+
request
.
param
_server_fxn
=
_server_with_logitproc_
module
_server_fxn
=
_server_with_logitproc_
fqcn
else
:
else
:
# Launch server, inject dummy logitproc entrypoint
# Launch server, inject dummy logitproc entrypoint
args
=
default_server_args
args
=
default_server_args
...
...
tests/v1/logits_processors/utils.py
View file @
d1f7392c
...
@@ -27,7 +27,7 @@ DUMMY_LOGITPROC_ARG = "target_token"
...
@@ -27,7 +27,7 @@ DUMMY_LOGITPROC_ARG = "target_token"
TEMP_GREEDY
=
0.0
TEMP_GREEDY
=
0.0
MAX_TOKENS
=
20
MAX_TOKENS
=
20
DUMMY_LOGITPROC_ENTRYPOINT
=
"dummy_logitproc"
DUMMY_LOGITPROC_ENTRYPOINT
=
"dummy_logitproc"
DUMMY_LOGITPROC_MODULE
=
"
DummyModule
"
DUMMY_LOGITPROC_MODULE
=
"
tests.v1.logits_processors.utils
"
DUMMY_LOGITPROC_FQCN
=
f
"
{
DUMMY_LOGITPROC_MODULE
}
:DummyLogitsProcessor"
DUMMY_LOGITPROC_FQCN
=
f
"
{
DUMMY_LOGITPROC_MODULE
}
:DummyLogitsProcessor"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment