Unverified Commit a964e5e6 authored by Cyrus Leung's avatar Cyrus Leung Committed by GitHub
Browse files

[Bugfix] Allow `--skip-tokenizer-init` with `echo and return_token_ids` (#26238)


Signed-off-by: default avatarDarkLight1337 <tlleungac@connect.ust.hk>
parent 78c1d5bf
...@@ -54,7 +54,7 @@ async def test_token_in_token_out_and_logprobs(server): ...@@ -54,7 +54,7 @@ async def test_token_in_token_out_and_logprobs(server):
prompt=token_ids, prompt=token_ids,
max_tokens=20, max_tokens=20,
temperature=0, temperature=0,
echo=False, echo=True,
extra_body={ extra_body={
"return_token_ids": True, "return_token_ids": True,
}, },
......
...@@ -691,5 +691,6 @@ class OpenAIServingCompletion(OpenAIServing): ...@@ -691,5 +691,6 @@ class OpenAIServingCompletion(OpenAIServing):
truncate_prompt_tokens=request.truncate_prompt_tokens, truncate_prompt_tokens=request.truncate_prompt_tokens,
add_special_tokens=request.add_special_tokens, add_special_tokens=request.add_special_tokens,
cache_salt=request.cache_salt, cache_salt=request.cache_salt,
needs_detokenization=bool(request.echo), needs_detokenization=bool(request.echo
and not request.return_token_ids),
) )
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment