Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
a450c64a
Unverified
Commit
a450c64a
authored
Dec 15, 2025
by
Michael Goin
Committed by
GitHub
Dec 15, 2025
Browse files
[Bugfix] Fail instead of ignoring when CompilationConfig gets invalid args (#30708)
Signed-off-by:
mgoin
<
mgoin64@gmail.com
>
parent
b2191abd
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
12 deletions
+4
-12
tests/benchmarks/test_param_sweep.py
tests/benchmarks/test_param_sweep.py
+0
-8
vllm/config/compilation.py
vllm/config/compilation.py
+4
-4
No files found.
tests/benchmarks/test_param_sweep.py
View file @
a450c64a
...
@@ -23,14 +23,6 @@ class TestParameterSweepItem:
...
@@ -23,14 +23,6 @@ class TestParameterSweepItem:
{
"compilation_config.use_inductor_graph_partition"
:
True
},
{
"compilation_config.use_inductor_graph_partition"
:
True
},
"--compilation-config.use_inductor_graph_partition=true"
,
"--compilation-config.use_inductor_graph_partition=true"
,
),
),
(
{
"compilation_config.use_inductor"
:
False
},
"--compilation-config.use_inductor=false"
,
),
(
{
"compilation_config.use_inductor"
:
True
},
"--compilation-config.use_inductor=true"
,
),
],
],
)
)
def
test_nested_boolean_params
(
self
,
input_dict
,
expected
):
def
test_nested_boolean_params
(
self
,
input_dict
,
expected
):
...
...
vllm/config/compilation.py
View file @
a450c64a
...
@@ -8,7 +8,7 @@ from dataclasses import field
...
@@ -8,7 +8,7 @@ from dataclasses import field
from
pathlib
import
Path
from
pathlib
import
Path
from
typing
import
TYPE_CHECKING
,
Any
,
ClassVar
,
Literal
from
typing
import
TYPE_CHECKING
,
Any
,
ClassVar
,
Literal
from
pydantic
import
Field
,
TypeAdapter
,
field_validator
from
pydantic
import
ConfigDict
,
Field
,
TypeAdapter
,
field_validator
from
pydantic.dataclasses
import
dataclass
from
pydantic.dataclasses
import
dataclass
import
vllm.envs
as
envs
import
vllm.envs
as
envs
...
@@ -96,7 +96,7 @@ class CUDAGraphMode(enum.Enum):
...
@@ -96,7 +96,7 @@ class CUDAGraphMode(enum.Enum):
@
config
@
config
@
dataclass
@
dataclass
(
config
=
ConfigDict
(
extra
=
"forbid"
))
class
PassConfig
:
class
PassConfig
:
"""Configuration for custom Inductor passes.
"""Configuration for custom Inductor passes.
...
@@ -251,7 +251,7 @@ class DynamicShapesType(str, enum.Enum):
...
@@ -251,7 +251,7 @@ class DynamicShapesType(str, enum.Enum):
@
config
@
config
@
dataclass
@
dataclass
(
config
=
ConfigDict
(
extra
=
"forbid"
))
class
DynamicShapesConfig
:
class
DynamicShapesConfig
:
"""Configuration to control/debug torch compile dynamic shapes."""
"""Configuration to control/debug torch compile dynamic shapes."""
...
@@ -290,7 +290,7 @@ class DynamicShapesConfig:
...
@@ -290,7 +290,7 @@ class DynamicShapesConfig:
@
config
@
config
@
dataclass
@
dataclass
(
config
=
ConfigDict
(
extra
=
"forbid"
))
class
CompilationConfig
:
class
CompilationConfig
:
"""Configuration for compilation.
"""Configuration for compilation.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment