Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
a26f59cc
Unverified
Commit
a26f59cc
authored
Apr 11, 2025
by
Jee Jee Li
Committed by
GitHub
Apr 11, 2025
Browse files
[Misc] Raise error for V1 not supporting Long LoRA. (#16415)
Signed-off-by:
Jee Jee Li
<
pandaleefree@gmail.com
>
parent
aa3b3d76
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
vllm/config.py
vllm/config.py
+6
-0
vllm/lora/models.py
vllm/lora/models.py
+1
-1
No files found.
vllm/config.py
View file @
a26f59cc
...
...
@@ -2573,6 +2573,11 @@ class LoRAConfig:
logger
.
warning
(
"LoRA with chunked prefill is still experimental "
"and may be unstable."
)
def
verify_lora_support
(
self
):
if
self
.
long_lora_scaling_factors
is
not
None
and
envs
.
VLLM_USE_V1
:
raise
ValueError
(
"V1 LoRA does not support long LoRA, please use V0."
)
@
dataclass
class
PromptAdapterConfig
:
...
...
@@ -3672,6 +3677,7 @@ class VllmConfig:
self
.
lora_config
.
verify_with_model_config
(
self
.
model_config
)
self
.
lora_config
.
verify_with_scheduler_config
(
self
.
scheduler_config
)
self
.
lora_config
.
verify_lora_support
()
if
self
.
prompt_adapter_config
:
self
.
prompt_adapter_config
.
verify_with_model_config
(
self
.
model_config
)
...
...
vllm/lora/models.py
View file @
a26f59cc
...
...
@@ -364,7 +364,7 @@ class LoRAModelManager(AdapterModelManager):
self
.
_last_mapping
:
Optional
[
LoRAMapping
]
=
None
self
.
_create_lora_modules
()
self
.
model
.
lora_manager
=
self
self
.
adapter_type
=
'LoR
a
'
self
.
adapter_type
=
'LoR
A
'
@
property
def
capacity
(
self
)
->
int
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment