Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
9bebc951
Unverified
Commit
9bebc951
authored
Feb 23, 2025
by
Roger Wang
Committed by
GitHub
Feb 23, 2025
Browse files
[Misc] Deprecate `--dataset` from `benchmark_serving.py` (#13708)
Signed-off-by:
Roger Wang
<
ywang@roblox.com
>
parent
5a2ba16f
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
19 deletions
+4
-19
benchmarks/benchmark_serving.py
benchmarks/benchmark_serving.py
+4
-19
No files found.
benchmarks/benchmark_serving.py
View file @
9bebc951
...
...
@@ -867,18 +867,10 @@ def main(args: argparse.Namespace):
tokenizer_mode
=
tokenizer_mode
,
trust_remote_code
=
args
.
trust_remote_code
)
if
args
.
dataset
is
not
None
:
warnings
.
warn
(
"The '--dataset' argument will be deprecated in the next "
"release. Please use '--dataset-name' and "
"'--dataset-path' in the future runs."
,
stacklevel
=
2
)
input_requests
=
sample_sharegpt_requests
(
dataset_path
=
args
.
dataset
,
num_requests
=
args
.
num_prompts
,
tokenizer
=
tokenizer
,
fixed_output_len
=
args
.
sharegpt_output_len
,
)
if
args
.
dataset_name
is
None
:
raise
ValueError
(
"Please specify '--dataset-name' and the corresponding "
"'--dataset-path' if required."
)
elif
args
.
dataset_name
==
"sharegpt"
:
input_requests
=
sample_sharegpt_requests
(
...
...
@@ -1052,13 +1044,6 @@ if __name__ == "__main__":
default
=
"/v1/completions"
,
help
=
"API endpoint."
,
)
parser
.
add_argument
(
"--dataset"
,
type
=
str
,
default
=
None
,
help
=
"Path to the ShareGPT dataset, will be deprecated in the "
"next release."
,
)
parser
.
add_argument
(
"--dataset-name"
,
type
=
str
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment