Unverified Commit 9bebc951 authored by Roger Wang's avatar Roger Wang Committed by GitHub
Browse files

[Misc] Deprecate `--dataset` from `benchmark_serving.py` (#13708)


Signed-off-by: default avatarRoger Wang <ywang@roblox.com>
parent 5a2ba16f
...@@ -867,18 +867,10 @@ def main(args: argparse.Namespace): ...@@ -867,18 +867,10 @@ def main(args: argparse.Namespace):
tokenizer_mode=tokenizer_mode, tokenizer_mode=tokenizer_mode,
trust_remote_code=args.trust_remote_code) trust_remote_code=args.trust_remote_code)
if args.dataset is not None: if args.dataset_name is None:
warnings.warn( raise ValueError(
"The '--dataset' argument will be deprecated in the next " "Please specify '--dataset-name' and the corresponding "
"release. Please use '--dataset-name' and " "'--dataset-path' if required.")
"'--dataset-path' in the future runs.",
stacklevel=2)
input_requests = sample_sharegpt_requests(
dataset_path=args.dataset,
num_requests=args.num_prompts,
tokenizer=tokenizer,
fixed_output_len=args.sharegpt_output_len,
)
elif args.dataset_name == "sharegpt": elif args.dataset_name == "sharegpt":
input_requests = sample_sharegpt_requests( input_requests = sample_sharegpt_requests(
...@@ -1052,13 +1044,6 @@ if __name__ == "__main__": ...@@ -1052,13 +1044,6 @@ if __name__ == "__main__":
default="/v1/completions", default="/v1/completions",
help="API endpoint.", help="API endpoint.",
) )
parser.add_argument(
"--dataset",
type=str,
default=None,
help="Path to the ShareGPT dataset, will be deprecated in the "
"next release.",
)
parser.add_argument( parser.add_argument(
"--dataset-name", "--dataset-name",
type=str, type=str,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment