Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
9b9cef31
Unverified
Commit
9b9cef31
authored
Dec 10, 2024
by
Joe Runde
Committed by
GitHub
Dec 10, 2024
Browse files
[Bugfix] Backport request id validation to v0 (#11036)
Signed-off-by:
Joe Runde
<
Joseph.Runde@ibm.com
>
parent
d05f8867
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
1 deletion
+5
-1
vllm/engine/multiprocessing/client.py
vllm/engine/multiprocessing/client.py
+4
-0
vllm/v1/engine/async_llm.py
vllm/v1/engine/async_llm.py
+1
-1
No files found.
vllm/engine/multiprocessing/client.py
View file @
9b9cef31
...
@@ -576,6 +576,10 @@ class MQLLMEngineClient(EngineClient):
...
@@ -576,6 +576,10 @@ class MQLLMEngineClient(EngineClient):
if
self
.
_errored_with
is
not
None
:
if
self
.
_errored_with
is
not
None
:
raise
ENGINE_DEAD_ERROR
(
self
.
_errored_with
)
raise
ENGINE_DEAD_ERROR
(
self
.
_errored_with
)
# Ensure the request id is unique among running requests
if
request_id
in
self
.
output_queues
:
raise
ValueError
(
f
"Request
{
request_id
}
already exists"
)
# Constructing guided decoding logits processors is expensive, so we do
# Constructing guided decoding logits processors is expensive, so we do
# it here to avoid contending with cpu resources and the GIL on the
# it here to avoid contending with cpu resources and the GIL on the
# backend process.
# backend process.
...
...
vllm/v1/engine/async_llm.py
View file @
9b9cef31
...
@@ -152,7 +152,7 @@ class AsyncLLM(EngineClient):
...
@@ -152,7 +152,7 @@ class AsyncLLM(EngineClient):
"""Add new request to the AsyncLLM."""
"""Add new request to the AsyncLLM."""
if
self
.
detokenizer
.
is_request_active
(
request_id
):
if
self
.
detokenizer
.
is_request_active
(
request_id
):
raise
Key
Error
(
f
"Request
{
request_id
}
already exists."
)
raise
Value
Error
(
f
"Request
{
request_id
}
already exists."
)
# 1) Create a new AsyncStream for the request.
# 1) Create a new AsyncStream for the request.
stream
=
self
.
_add_request_to_streams
(
request_id
)
stream
=
self
.
_add_request_to_streams
(
request_id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment