Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
966f933e
Commit
966f933e
authored
Mar 19, 2025
by
Jee Jee Li
Committed by
simon-mo
Mar 18, 2025
Browse files
[Bugfix] Fix LoRA extra vocab size (#15047)
Signed-off-by:
Jee Jee Li
<
pandaleefree@gmail.com
>
parent
1a504aff
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
1 addition
and
5 deletions
+1
-5
examples/offline_inference/audio_language.py
examples/offline_inference/audio_language.py
+0
-1
examples/offline_inference/vision_language.py
examples/offline_inference/vision_language.py
+0
-1
examples/offline_inference/vision_language_multi_image.py
examples/offline_inference/vision_language_multi_image.py
+0
-1
tests/models/decoder_only/vision_language/test_phi4mm.py
tests/models/decoder_only/vision_language/test_phi4mm.py
+0
-1
vllm/config.py
vllm/config.py
+1
-1
No files found.
examples/offline_inference/audio_language.py
View file @
966f933e
...
@@ -93,7 +93,6 @@ def run_phi4mm(question: str, audio_count: int) -> ModelRequestData:
...
@@ -93,7 +93,6 @@ def run_phi4mm(question: str, audio_count: int) -> ModelRequestData:
max_num_seqs
=
2
,
max_num_seqs
=
2
,
enable_lora
=
True
,
enable_lora
=
True
,
max_lora_rank
=
320
,
max_lora_rank
=
320
,
lora_extra_vocab_size
=
0
,
limit_mm_per_prompt
=
{
"audio"
:
audio_count
},
limit_mm_per_prompt
=
{
"audio"
:
audio_count
},
)
)
...
...
examples/offline_inference/vision_language.py
View file @
966f933e
...
@@ -682,7 +682,6 @@ def run_phi4mm(questions: list[str], modality: str) -> ModelRequestData:
...
@@ -682,7 +682,6 @@ def run_phi4mm(questions: list[str], modality: str) -> ModelRequestData:
max_num_seqs
=
2
,
max_num_seqs
=
2
,
enable_lora
=
True
,
enable_lora
=
True
,
max_lora_rank
=
320
,
max_lora_rank
=
320
,
lora_extra_vocab_size
=
0
,
)
)
return
ModelRequestData
(
return
ModelRequestData
(
...
...
examples/offline_inference/vision_language_multi_image.py
View file @
966f933e
...
@@ -342,7 +342,6 @@ def load_phi4mm(question: str, image_urls: list[str]) -> ModelRequestData:
...
@@ -342,7 +342,6 @@ def load_phi4mm(question: str, image_urls: list[str]) -> ModelRequestData:
limit_mm_per_prompt
=
{
"image"
:
len
(
image_urls
)},
limit_mm_per_prompt
=
{
"image"
:
len
(
image_urls
)},
enable_lora
=
True
,
enable_lora
=
True
,
max_lora_rank
=
320
,
max_lora_rank
=
320
,
lora_extra_vocab_size
=
0
,
)
)
placeholders
=
""
.
join
(
f
"<|image_
{
i
}
|>"
placeholders
=
""
.
join
(
f
"<|image_
{
i
}
|>"
...
...
tests/models/decoder_only/vision_language/test_phi4mm.py
View file @
966f933e
...
@@ -100,7 +100,6 @@ def run_test(
...
@@ -100,7 +100,6 @@ def run_test(
distributed_executor_backend
=
distributed_executor_backend
,
distributed_executor_backend
=
distributed_executor_backend
,
enable_lora
=
True
,
enable_lora
=
True
,
max_lora_rank
=
320
,
max_lora_rank
=
320
,
lora_extra_vocab_size
=
0
,
gpu_memory_utilization
=
0.8
,
# set to 0.8 to avoid OOM in CI
gpu_memory_utilization
=
0.8
,
# set to 0.8 to avoid OOM in CI
enforce_eager
=
True
,
enforce_eager
=
True
,
)
as
vllm_model
:
)
as
vllm_model
:
...
...
vllm/config.py
View file @
966f933e
...
@@ -2324,7 +2324,7 @@ class LoRAConfig:
...
@@ -2324,7 +2324,7 @@ class LoRAConfig:
# Setting the maximum rank to 512 should be able to satisfy the vast
# Setting the maximum rank to 512 should be able to satisfy the vast
# majority of applications.
# majority of applications.
possible_max_ranks
=
(
8
,
16
,
32
,
64
,
128
,
256
,
320
,
512
)
possible_max_ranks
=
(
8
,
16
,
32
,
64
,
128
,
256
,
320
,
512
)
possible_lora_extra_vocab_size
=
(
0
,
256
,
512
)
possible_lora_extra_vocab_size
=
(
256
,
512
)
if
self
.
max_lora_rank
not
in
possible_max_ranks
:
if
self
.
max_lora_rank
not
in
possible_max_ranks
:
raise
ValueError
(
raise
ValueError
(
f
"max_lora_rank (
{
self
.
max_lora_rank
}
) must be one of "
f
"max_lora_rank (
{
self
.
max_lora_rank
}
) must be one of "
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment