Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
95bc60e4
Unverified
Commit
95bc60e4
authored
Sep 23, 2025
by
Andrew Xia
Committed by
GitHub
Sep 23, 2025
Browse files
[gpt-oss][bugfix] remove logic to require resp_ in ResponseAPI (#25428)
Signed-off-by:
Andrew Xia
<
axia@meta.com
>
parent
4f2954f7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
15 deletions
+1
-15
tests/entrypoints/openai/test_response_api_with_harmony.py
tests/entrypoints/openai/test_response_api_with_harmony.py
+1
-0
vllm/entrypoints/openai/serving_responses.py
vllm/entrypoints/openai/serving_responses.py
+0
-15
No files found.
tests/entrypoints/openai/test_response_api_with_harmony.py
View file @
95bc60e4
...
...
@@ -523,6 +523,7 @@ async def test_function_calling(client: OpenAI, model_name: str):
input
=
"What's the weather like in Paris today?"
,
tools
=
tools
,
temperature
=
0.0
,
extra_body
=
{
"request_id"
:
"test_function_calling_non_resp"
},
)
assert
response
is
not
None
assert
response
.
status
==
"completed"
...
...
vllm/entrypoints/openai/serving_responses.py
View file @
95bc60e4
...
...
@@ -235,8 +235,6 @@ class OpenAIServingResponses(OpenAIServing):
# Handle the previous response ID.
prev_response_id
=
request
.
previous_response_id
if
prev_response_id
is
not
None
:
if
not
prev_response_id
.
startswith
(
"resp_"
):
return
self
.
_make_invalid_id_error
(
prev_response_id
)
async
with
self
.
response_store_lock
:
prev_response
=
self
.
response_store
.
get
(
prev_response_id
)
if
prev_response
is
None
:
...
...
@@ -924,9 +922,6 @@ class OpenAIServingResponses(OpenAIServing):
stream
:
Optional
[
bool
],
)
->
Union
[
ErrorResponse
,
ResponsesResponse
,
AsyncGenerator
[
StreamingResponsesResponse
,
None
]]:
if
not
response_id
.
startswith
(
"resp_"
):
return
self
.
_make_invalid_id_error
(
response_id
)
async
with
self
.
response_store_lock
:
response
=
self
.
response_store
.
get
(
response_id
)
...
...
@@ -944,9 +939,6 @@ class OpenAIServingResponses(OpenAIServing):
self
,
response_id
:
str
,
)
->
Union
[
ErrorResponse
,
ResponsesResponse
]:
if
not
response_id
.
startswith
(
"resp_"
):
return
self
.
_make_invalid_id_error
(
response_id
)
async
with
self
.
response_store_lock
:
response
=
self
.
response_store
.
get
(
response_id
)
if
response
is
None
:
...
...
@@ -972,13 +964,6 @@ class OpenAIServingResponses(OpenAIServing):
response_id
)
return
response
def
_make_invalid_id_error
(
self
,
response_id
:
str
)
->
ErrorResponse
:
return
self
.
create_error_response
(
err_type
=
"invalid_request_error"
,
message
=
(
f
"Invalid 'response_id': '
{
response_id
}
'. "
"Expected an ID that begins with 'resp'."
),
)
def
_make_not_found_error
(
self
,
response_id
:
str
)
->
ErrorResponse
:
return
self
.
create_error_response
(
err_type
=
"invalid_request_error"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment