Unverified Commit 8dd0671b authored by Jin Huang's avatar Jin Huang Committed by GitHub
Browse files

[Bugfix][V1] Only get input embeddings w/ multi-modal models if first PP (#17916)


Signed-off-by: default avatarJin Huang <jinhun@amazon.com>
Co-authored-by: default avatarJin Huang <jinhun@amazon.com>
parent f0d610a8
...@@ -1107,7 +1107,7 @@ class GPUModelRunner(LoRAModelRunnerMixin): ...@@ -1107,7 +1107,7 @@ class GPUModelRunner(LoRAModelRunnerMixin):
else: else:
mm_embeds = [] mm_embeds = []
if self.is_multimodal_model: if self.is_multimodal_model and get_pp_group().is_first_rank:
# NOTE(woosuk): To unify token ids and soft tokens (vision # NOTE(woosuk): To unify token ids and soft tokens (vision
# embeddings), we always use embeddings (rather than token ids) # embeddings), we always use embeddings (rather than token ids)
# as input to the multimodal model, even when the input is text. # as input to the multimodal model, even when the input is text.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment