Unverified Commit 8832fff9 authored by Nick Hill's avatar Nick Hill Committed by GitHub
Browse files

[BugFix] Fix `mm_encoder_attn_backend` arg type checking (#28599)


Signed-off-by: default avatarNick Hill <nhill@redhat.com>
parent a543e678
...@@ -57,7 +57,7 @@ steps: ...@@ -57,7 +57,7 @@ steps:
- pytest -v -s -m 'not cpu_test' multimodal - pytest -v -s -m 'not cpu_test' multimodal
- pytest -v -s utils_ - pytest -v -s utils_
- label: Async Engine, Inputs, Utils, Worker Test (CPU) # 4 mins - label: Async Engine, Inputs, Utils, Worker, Config Test (CPU) # 4 mins
timeout_in_minutes: 10 timeout_in_minutes: 10
source_file_dependencies: source_file_dependencies:
- vllm/ - vllm/
...@@ -66,6 +66,7 @@ steps: ...@@ -66,6 +66,7 @@ steps:
- tests/multimodal - tests/multimodal
- tests/standalone_tests/lazy_imports.py - tests/standalone_tests/lazy_imports.py
- tests/transformers_utils - tests/transformers_utils
- tests/config
no_gpu: true no_gpu: true
commands: commands:
- python3 standalone_tests/lazy_imports.py - python3 standalone_tests/lazy_imports.py
...@@ -73,6 +74,7 @@ steps: ...@@ -73,6 +74,7 @@ steps:
- pytest -v -s test_outputs.py - pytest -v -s test_outputs.py
- pytest -v -s -m 'cpu_test' multimodal - pytest -v -s -m 'cpu_test' multimodal
- pytest -v -s transformers_utils - pytest -v -s transformers_utils
- pytest -v -s config
- label: Python-only Installation Test # 10min - label: Python-only Installation Test # 10min
timeout_in_minutes: 20 timeout_in_minutes: 20
......
...@@ -170,6 +170,9 @@ class MultiModalConfig: ...@@ -170,6 +170,9 @@ class MultiModalConfig:
def _validate_mm_encoder_attn_backend( def _validate_mm_encoder_attn_backend(
cls, value: str | AttentionBackendEnum | None cls, value: str | AttentionBackendEnum | None
) -> AttentionBackendEnum | None: ) -> AttentionBackendEnum | None:
# We need to import the real type here (deferred to avoid circular import).
from vllm.attention.backends.registry import AttentionBackendEnum
if value is None or isinstance(value, AttentionBackendEnum): if value is None or isinstance(value, AttentionBackendEnum):
return value return value
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment