Unverified Commit 583e6f22 authored by TJian's avatar TJian Committed by GitHub
Browse files

[ROCm] [Wheel] [Bugfix] [Critical] Remove any packages installed from github...


[ROCm] [Wheel] [Bugfix] [Critical] Remove any packages installed from github from rocm.txt e.g  `fastsafetensors` as it is incompatible with `uv pip` (#40461)
Signed-off-by: default avatartjtanaa <tunjian.tan@embeddedllm.com>
parent 96a85c57
...@@ -307,6 +307,30 @@ RUN --mount=type=bind,source=.git,target=vllm/.git \ ...@@ -307,6 +307,30 @@ RUN --mount=type=bind,source=.git,target=vllm/.git \
&& echo "Detected vLLM version: ${VLLM_VERSION}" \ && echo "Detected vLLM version: ${VLLM_VERSION}" \
&& echo "${VLLM_VERSION}" > /tmp/vllm_version.txt && echo "${VLLM_VERSION}" > /tmp/vllm_version.txt
# Fail if git-based package dependencies are found in requirements files
# (uv doesn't handle git+ URLs well, and packages should be distributed on PyPI)
# Extra notes: pip install is able to handle git+ URLs, but uv doesn't.
RUN echo "Checking for git-based packages in requirements files..." \
&& echo "Checking common.txt for git-based packages:" \
&& if grep -q 'git+' ${COMMON_WORKDIR}/vllm/requirements/common.txt; then \
echo "ERROR: Git-based packages found in common.txt:"; \
grep 'git+' ${COMMON_WORKDIR}/vllm/requirements/common.txt; \
echo "Please publish these packages to PyPI instead of using git dependencies."; \
exit 1; \
else \
echo " ✓ No git-based packages found in common.txt"; \
fi \
&& echo "Checking rocm.txt for git-based packages:" \
&& if grep -q 'git+' ${COMMON_WORKDIR}/vllm/requirements/rocm.txt; then \
echo "ERROR: Git-based packages found in rocm.txt:"; \
grep 'git+' ${COMMON_WORKDIR}/vllm/requirements/rocm.txt; \
echo "Please publish these packages to PyPI instead of using git dependencies."; \
exit 1; \
else \
echo " ✓ No git-based packages found in rocm.txt"; \
fi \
&& echo "All requirements files are clean - no git-based packages found"
# Pin vLLM dependencies to exact versions of custom ROCm wheels # Pin vLLM dependencies to exact versions of custom ROCm wheels
# This ensures 'pip install vllm' automatically installs correct torch/triton/torchvision/amdsmi # This ensures 'pip install vllm' automatically installs correct torch/triton/torchvision/amdsmi
COPY tools/vllm-rocm/pin_rocm_dependencies.py /tmp/pin_rocm_dependencies.py COPY tools/vllm-rocm/pin_rocm_dependencies.py /tmp/pin_rocm_dependencies.py
......
...@@ -20,6 +20,4 @@ conch-triton-kernels==1.2.1 ...@@ -20,6 +20,4 @@ conch-triton-kernels==1.2.1
timm>=1.0.17 timm>=1.0.17
# amd-quark: required for Quark quantization on ROCm # amd-quark: required for Quark quantization on ROCm
# To be consistent with test_quark.py # To be consistent with test_quark.py
amd-quark>=0.8.99 amd-quark>=0.8.99
# Required for faster safetensors model loading \ No newline at end of file
fastsafetensors @ git+https://github.com/foundation-model-stack/fastsafetensors.git@0.2.2
\ No newline at end of file
...@@ -276,9 +276,7 @@ fastar==0.10.0 ...@@ -276,9 +276,7 @@ fastar==0.10.0
fastparquet==2026.3.0 fastparquet==2026.3.0
# via genai-perf # via genai-perf
fastsafetensors @ git+https://github.com/foundation-model-stack/fastsafetensors.git@65d80088fca7a8f567fba30415fbcc80f7d2259c fastsafetensors @ git+https://github.com/foundation-model-stack/fastsafetensors.git@65d80088fca7a8f567fba30415fbcc80f7d2259c
# via # via -r requirements/test/rocm.in
# -c requirements/rocm.txt
# -r requirements/test/rocm.in
filelock==3.25.2 filelock==3.25.2
# via # via
# -c requirements/common.txt # -c requirements/common.txt
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment