Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
50012113
Unverified
Commit
50012113
authored
Feb 12, 2026
by
TJian
Committed by
GitHub
Feb 11, 2026
Browse files
[ROCm] [CI] fix test_unrecognized_env (#34350)
Signed-off-by:
tjtanaa
<
tunjian.tan@embeddedllm.com
>
parent
11c7ace3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
3 deletions
+10
-3
tests/config/test_config_generation.py
tests/config/test_config_generation.py
+10
-3
No files found.
tests/config/test_config_generation.py
View file @
50012113
...
@@ -80,12 +80,19 @@ def test_ray_runtime_env(monkeypatch: pytest.MonkeyPatch):
...
@@ -80,12 +80,19 @@ def test_ray_runtime_env(monkeypatch: pytest.MonkeyPatch):
ray
.
shutdown
()
ray
.
shutdown
()
def
test_unrecognized_env
():
def
test_unrecognized_env
(
monkeypatch
):
import
os
import
os
from
vllm.envs
import
environment_variables
# Remove any existing unrecognized VLLM env vars that might interfere
for
env
in
list
(
os
.
environ
):
if
env
.
startswith
(
"VLLM_"
)
and
env
not
in
environment_variables
:
monkeypatch
.
delenv
(
env
,
raising
=
False
)
# Test that if fail_on_environ_validation is True, then an error
# Test that if fail_on_environ_validation is True, then an error
# is raised when an unrecognized vLLM environment variable is set
# is raised when an unrecognized vLLM environment variable is set
os
.
environ
[
"VLLM_UNRECOGNIZED_ENV_VAR"
]
=
"some_value"
monkeypatch
.
setenv
(
"VLLM_UNRECOGNIZED_ENV_VAR"
,
"some_value"
)
engine_args
=
EngineArgs
(
engine_args
=
EngineArgs
(
fail_on_environ_validation
=
True
,
fail_on_environ_validation
=
True
,
)
)
...
@@ -97,7 +104,7 @@ def test_unrecognized_env():
...
@@ -97,7 +104,7 @@ def test_unrecognized_env():
engine_args
.
create_engine_config
()
engine_args
.
create_engine_config
()
# Test that when the unrecognized env var is removed, no error is raised
# Test that when the unrecognized env var is removed, no error is raised
os
.
environ
.
pop
(
"VLLM_UNRECOGNIZED_ENV_VAR"
,
None
)
monkeypatch
.
delenv
(
"VLLM_UNRECOGNIZED_ENV_VAR"
)
engine_args
=
EngineArgs
(
engine_args
=
EngineArgs
(
fail_on_environ_validation
=
True
,
fail_on_environ_validation
=
True
,
)
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment