Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
3a8eef58
Unverified
Commit
3a8eef58
authored
Mar 03, 2026
by
Rohan Potdar
Committed by
GitHub
Mar 03, 2026
Browse files
[ROCm][Bugfix]: Disable AITER Triton ROPE by default (#35601)
Signed-off-by:
Rohan138
<
rohanpotdar138@gmail.com
>
parent
97995f63
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
6 deletions
+5
-6
vllm/envs.py
vllm/envs.py
+3
-3
vllm/platforms/rocm.py
vllm/platforms/rocm.py
+2
-3
No files found.
vllm/envs.py
View file @
3a8eef58
...
...
@@ -106,7 +106,7 @@ if TYPE_CHECKING:
VLLM_ROCM_USE_AITER_MLA
:
bool
=
True
VLLM_ROCM_USE_AITER_MHA
:
bool
=
True
VLLM_ROCM_USE_AITER_FP4_ASM_GEMM
:
bool
=
False
VLLM_ROCM_USE_AITER_TRITON_ROPE
:
bool
=
Tru
e
VLLM_ROCM_USE_AITER_TRITON_ROPE
:
bool
=
Fals
e
VLLM_ROCM_USE_AITER_FP8BMM
:
bool
=
True
VLLM_ROCM_USE_AITER_FP4BMM
:
bool
=
True
VLLM_ROCM_USE_AITER_UNIFIED_ATTENTION
:
bool
=
False
...
...
@@ -949,9 +949,9 @@ environment_variables: dict[str, Callable[[], Any]] = {
os
.
getenv
(
"VLLM_ROCM_USE_AITER_FP4_ASM_GEMM"
,
"False"
).
lower
()
in
(
"true"
,
"1"
)
),
# Whether to use aiter rope.
# By default is
en
abled.
# By default is
dis
abled.
"VLLM_ROCM_USE_AITER_TRITON_ROPE"
:
lambda
:
(
os
.
getenv
(
"VLLM_ROCM_USE_AITER_TRITON_ROPE"
,
"
Tru
e"
).
lower
()
in
(
"true"
,
"1"
)
os
.
getenv
(
"VLLM_ROCM_USE_AITER_TRITON_ROPE"
,
"
Fals
e"
).
lower
()
in
(
"true"
,
"1"
)
),
# Whether to use aiter triton fp8 bmm kernel
# By default is enabled.
...
...
vllm/platforms/rocm.py
View file @
3a8eef58
...
...
@@ -592,7 +592,6 @@ class RocmPlatform(Platform):
use_aiter_rms_norm
=
rocm_aiter_ops
.
is_rmsnorm_enabled
()
use_aiter_fp8_linear
=
rocm_aiter_ops
.
is_linear_fp8_enabled
()
use_aiter_fused_se
=
rocm_aiter_ops
.
is_fusion_moe_shared_experts_enabled
()
use_aiter_triton_rope
=
rocm_aiter_ops
.
is_triton_rotary_embed_enabled
()
# Aiter rms norm perform best when CUDA Graph capture is enabled.
if
(
use_aiter_rms_norm
...
...
@@ -619,9 +618,9 @@ class RocmPlatform(Platform):
and
"-grouped_topk"
not
in
compilation_config
.
custom_ops
):
compilation_config
.
custom_ops
.
append
(
"+grouped_topk"
)
# Enable rotary embedding when using AITER if
its
not disabled by user
# Enable rotary embedding
customop
when using AITER if not disabled by user
if
(
use
_aiter_
triton_rope
rocm
_aiter_
ops
.
is_enabled
()
and
"+rotary_embedding"
not
in
compilation_config
.
custom_ops
and
"-rotary_embedding"
not
in
compilation_config
.
custom_ops
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment