Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
327c0a9a
Unverified
Commit
327c0a9a
authored
Nov 13, 2025
by
Nick Hill
Committed by
GitHub
Nov 13, 2025
Browse files
[BugFix] Ensure `EngineArgs.create_engine_config` is idempotent (#28515)
Signed-off-by:
Nick Hill
<
nhill@redhat.com
>
parent
06c4873d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
10 deletions
+9
-10
vllm/engine/arg_utils.py
vllm/engine/arg_utils.py
+9
-10
No files found.
vllm/engine/arg_utils.py
View file @
327c0a9a
...
@@ -1631,40 +1631,39 @@ class EngineArgs:
...
@@ -1631,40 +1631,39 @@ class EngineArgs:
)
)
observability_config
=
ObservabilityConfig
(
observability_config
=
ObservabilityConfig
(
show_hidden_metrics_for_version
=
(
self
.
show_hidden_metrics_for_version
)
,
show_hidden_metrics_for_version
=
self
.
show_hidden_metrics_for_version
,
otlp_traces_endpoint
=
self
.
otlp_traces_endpoint
,
otlp_traces_endpoint
=
self
.
otlp_traces_endpoint
,
collect_detailed_traces
=
self
.
collect_detailed_traces
,
collect_detailed_traces
=
self
.
collect_detailed_traces
,
)
)
# Compilation config overrides
# Compilation config overrides
compilation_config
=
copy
.
deepcopy
(
self
.
compilation_config
)
if
self
.
cuda_graph_sizes
is
not
None
:
if
self
.
cuda_graph_sizes
is
not
None
:
logger
.
warning
(
logger
.
warning
(
"--cuda-graph-sizes is deprecated and will be removed in v0.13.0 or "
"--cuda-graph-sizes is deprecated and will be removed in v0.13.0 or "
"v1.0.0, whichever is soonest. Please use --cudagraph-capture-sizes "
"v1.0.0, whichever is soonest. Please use --cudagraph-capture-sizes "
"instead."
"instead."
)
)
if
self
.
compilation_config
.
cudagraph_capture_sizes
is
not
None
:
if
compilation_config
.
cudagraph_capture_sizes
is
not
None
:
raise
ValueError
(
raise
ValueError
(
"cuda_graph_sizes and compilation_config."
"cuda_graph_sizes and compilation_config."
"cudagraph_capture_sizes are mutually exclusive"
"cudagraph_capture_sizes are mutually exclusive"
)
)
self
.
compilation_config
.
cudagraph_capture_sizes
=
self
.
cuda_graph_sizes
compilation_config
.
cudagraph_capture_sizes
=
self
.
cuda_graph_sizes
if
self
.
cudagraph_capture_sizes
is
not
None
:
if
self
.
cudagraph_capture_sizes
is
not
None
:
if
self
.
compilation_config
.
cudagraph_capture_sizes
is
not
None
:
if
compilation_config
.
cudagraph_capture_sizes
is
not
None
:
raise
ValueError
(
raise
ValueError
(
"cudagraph_capture_sizes and compilation_config."
"cudagraph_capture_sizes and compilation_config."
"cudagraph_capture_sizes are mutually exclusive"
"cudagraph_capture_sizes are mutually exclusive"
)
)
self
.
compilation_config
.
cudagraph_capture_sizes
=
(
compilation_config
.
cudagraph_capture_sizes
=
self
.
cudagraph_capture_sizes
self
.
cudagraph_capture_sizes
)
if
self
.
max_cudagraph_capture_size
is
not
None
:
if
self
.
max_cudagraph_capture_size
is
not
None
:
if
self
.
compilation_config
.
max_cudagraph_capture_size
is
not
None
:
if
compilation_config
.
max_cudagraph_capture_size
is
not
None
:
raise
ValueError
(
raise
ValueError
(
"max_cudagraph_capture_size and compilation_config."
"max_cudagraph_capture_size and compilation_config."
"max_cudagraph_capture_size are mutually exclusive"
"max_cudagraph_capture_size are mutually exclusive"
)
)
self
.
compilation_config
.
max_cudagraph_capture_size
=
(
compilation_config
.
max_cudagraph_capture_size
=
(
self
.
max_cudagraph_capture_size
self
.
max_cudagraph_capture_size
)
)
...
@@ -1679,7 +1678,7 @@ class EngineArgs:
...
@@ -1679,7 +1678,7 @@ class EngineArgs:
load_config
=
load_config
,
load_config
=
load_config
,
structured_outputs_config
=
self
.
structured_outputs_config
,
structured_outputs_config
=
self
.
structured_outputs_config
,
observability_config
=
observability_config
,
observability_config
=
observability_config
,
compilation_config
=
self
.
compilation_config
,
compilation_config
=
compilation_config
,
kv_transfer_config
=
self
.
kv_transfer_config
,
kv_transfer_config
=
self
.
kv_transfer_config
,
kv_events_config
=
self
.
kv_events_config
,
kv_events_config
=
self
.
kv_events_config
,
ec_transfer_config
=
self
.
ec_transfer_config
,
ec_transfer_config
=
self
.
ec_transfer_config
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment