Unverified Commit 21c26279 authored by Xingyu Liu's avatar Xingyu Liu Committed by GitHub
Browse files

[Misc]Remove redundant hidden_size property in ModelConfig (#29749)


Signed-off-by: default avatarXingyu Liu <charlotteliu12x@gmail.com>
Co-authored-by: default avatarHarry Mellor <19981378+hmellor@users.noreply.github.com>
parent 39d28108
...@@ -1726,19 +1726,12 @@ class ModelConfig: ...@@ -1726,19 +1726,12 @@ class ModelConfig:
logger.debug_once("head dtype: %s", head_dtype) logger.debug_once("head dtype: %s", head_dtype)
return head_dtype return head_dtype
@property
def hidden_size(self):
if hasattr(self.hf_config, "hidden_size"):
return self.hf_config.hidden_size
text_config = self.hf_config.get_text_config()
return text_config.hidden_size
@property @property
def embedding_size(self): def embedding_size(self):
dense_modules = try_get_dense_modules(self.model, revision=self.revision) dense_modules = try_get_dense_modules(self.model, revision=self.revision)
if dense_modules is not None: if dense_modules is not None:
return dense_modules[-1]["out_features"] return dense_modules[-1]["out_features"]
return self.hidden_size return self.get_hidden_size()
def get_and_verify_max_len(self, max_model_len: int): def get_and_verify_max_len(self, max_model_len: int):
# Consider max_model_len in tokenizer_config only when # Consider max_model_len in tokenizer_config only when
......
...@@ -301,7 +301,7 @@ def as_seq_cls_model(cls: _T) -> _T: ...@@ -301,7 +301,7 @@ def as_seq_cls_model(cls: _T) -> _T:
quant_config = vllm_config.quant_config quant_config = vllm_config.quant_config
self.score = ReplicatedLinear( self.score = ReplicatedLinear(
model_config.hidden_size, model_config.get_hidden_size(),
text_config.num_labels, text_config.num_labels,
bias=False, bias=False,
params_dtype=vllm_config.model_config.head_dtype, params_dtype=vllm_config.model_config.head_dtype,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment