"vscode:/vscode.git/clone" did not exist on "e51929ebca5833a5e6eed484775178d33a014faa"
Unverified Commit 13397841 authored by Ning Xie's avatar Ning Xie Committed by GitHub
Browse files

[structured output] validate unsupported json features first (#33233)


Signed-off-by: default avatarAndy Xie <andy.xning@gmail.com>
Co-authored-by: default avatarChauncey <chaunceyjiang@gmail.com>
Co-authored-by: default avatarRussell Bryant <rbryant@redhat.com>
parent c60f8e3b
...@@ -304,17 +304,17 @@ def validate_xgrammar_grammar(sampling_params: SamplingParams) -> None: ...@@ -304,17 +304,17 @@ def validate_xgrammar_grammar(sampling_params: SamplingParams) -> None:
else: else:
schema = so_params.json schema = so_params.json
if has_xgrammar_unsupported_json_features(schema):
raise ValueError(
"The provided JSON schema contains features not supported by xgrammar."
)
try: try:
xgr.Grammar.from_json_schema(schema) xgr.Grammar.from_json_schema(schema)
except Exception as err: except Exception as err:
raise ValueError( raise ValueError(
f"Failed to transform json schema into a grammar: {err}" f"Failed to transform json schema into a grammar: {err}"
) from err ) from err
if has_xgrammar_unsupported_json_features(schema):
raise ValueError(
"The provided JSON schema contains features not supported by xgrammar."
)
return return
if so_params.grammar: if so_params.grammar:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment