Unverified Commit 11fcf0e0 authored by Noam Gat's avatar Noam Gat Committed by GitHub
Browse files

Remove token-adding chat embedding params (#10551)


Signed-off-by: default avatarNoam Gat <noamgat@gmail.com>
parent b6374e09
...@@ -760,22 +760,6 @@ class EmbeddingChatRequest(OpenAIBaseModel): ...@@ -760,22 +760,6 @@ class EmbeddingChatRequest(OpenAIBaseModel):
# doc: end-chat-embedding-pooling-params # doc: end-chat-embedding-pooling-params
# doc: begin-chat-embedding-extra-params # doc: begin-chat-embedding-extra-params
add_generation_prompt: bool = Field(
default=True,
description=
("If true, the generation prompt will be added to the chat template. "
"This is a parameter used by chat template in tokenizer config of the "
"model."),
)
continue_final_message: bool = Field(
default=False,
description=
("If this is set, the chat will be formatted so that the final "
"message in the chat is open-ended, without any EOS tokens. The "
"model will continue this message rather than starting a new one. "
"This allows you to \"prefill\" part of the model's response for it. "
"Cannot be used at the same time as `add_generation_prompt`."),
)
add_special_tokens: bool = Field( add_special_tokens: bool = Field(
default=False, default=False,
description=( description=(
......
...@@ -148,8 +148,10 @@ class OpenAIServingEmbedding(OpenAIServing): ...@@ -148,8 +148,10 @@ class OpenAIServingEmbedding(OpenAIServing):
chat_template=request.chat_template or self.chat_template, chat_template=request.chat_template or self.chat_template,
chat_template_content_format=self. chat_template_content_format=self.
chat_template_content_format, chat_template_content_format,
add_generation_prompt=request.add_generation_prompt, # In embedding requests, we are not generating tokens,
continue_final_message=request.continue_final_message, # so there is no need to append extra tokens to the input
add_generation_prompt=False,
continue_final_message=False,
truncate_prompt_tokens=truncate_prompt_tokens, truncate_prompt_tokens=truncate_prompt_tokens,
add_special_tokens=request.add_special_tokens, add_special_tokens=request.add_special_tokens,
) )
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment