Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
0ceaebf8
Unverified
Commit
0ceaebf8
authored
May 16, 2025
by
Nick Hill
Committed by
GitHub
May 16, 2025
Browse files
[BugFix] Fix ordering of KVConnector finished send/rcv sets (#18211)
Signed-off-by:
Nick Hill
<
nhill@redhat.com
>
parent
1db4f47f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
4 deletions
+5
-4
vllm/distributed/kv_transfer/kv_connector/v1/base.py
vllm/distributed/kv_transfer/kv_connector/v1/base.py
+2
-1
vllm/distributed/kv_transfer/kv_connector/v1/multi_connector.py
...istributed/kv_transfer/kv_connector/v1/multi_connector.py
+3
-3
No files found.
vllm/distributed/kv_transfer/kv_connector/v1/base.py
View file @
0ceaebf8
...
@@ -183,7 +183,8 @@ class KVConnectorBase_V1(ABC):
...
@@ -183,7 +183,8 @@ class KVConnectorBase_V1(ABC):
finished generating tokens.
finished generating tokens.
Returns:
Returns:
ids of requests that have finished asynchronous (recving, sending).
ids of requests that have finished asynchronous transfer,
tuple of (sending/saving ids, recving/loading ids).
The finished saves/sends req ids must belong to a set provided in a
The finished saves/sends req ids must belong to a set provided in a
call to this method (this call or a prior one).
call to this method (this call or a prior one).
"""
"""
...
...
vllm/distributed/kv_transfer/kv_connector/v1/multi_connector.py
View file @
0ceaebf8
...
@@ -103,10 +103,10 @@ class MultiConnector(KVConnectorBase_V1):
...
@@ -103,10 +103,10 @@ class MultiConnector(KVConnectorBase_V1):
def
get_finished
(
def
get_finished
(
self
,
finished_req_ids
:
set
[
str
]
self
,
finished_req_ids
:
set
[
str
]
)
->
tuple
[
Optional
[
set
[
str
]],
Optional
[
set
[
str
]]]:
)
->
tuple
[
Optional
[
set
[
str
]],
Optional
[
set
[
str
]]]:
finished_recving
:
set
[
str
]
=
set
()
finished_sending
:
set
[
str
]
=
set
()
finished_sending
:
set
[
str
]
=
set
()
finished_recving
:
set
[
str
]
=
set
()
for
c
in
self
.
_connectors
:
for
c
in
self
.
_connectors
:
recv
ing
,
send
ing
=
c
.
get_finished
(
finished_req_ids
)
send
ing
,
recv
ing
=
c
.
get_finished
(
finished_req_ids
)
if
not
recving
and
not
sending
:
if
not
recving
and
not
sending
:
continue
continue
# Aggregate finished recving request ids.
# Aggregate finished recving request ids.
...
@@ -125,7 +125,7 @@ class MultiConnector(KVConnectorBase_V1):
...
@@ -125,7 +125,7 @@ class MultiConnector(KVConnectorBase_V1):
else
:
else
:
self
.
_extra_async_saves
[
req_id
]
=
extra_pending
-
1
self
.
_extra_async_saves
[
req_id
]
=
extra_pending
-
1
return
finished_
recv
ing
or
None
,
finished_
send
ing
or
None
return
finished_
send
ing
or
None
,
finished_
recv
ing
or
None
# ==============================
# ==============================
# Scheduler-side methods
# Scheduler-side methods
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment