Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
OpenDAS
vllm_cscc
Commits
04d37523
Unverified
Commit
04d37523
authored
Sep 21, 2025
by
Yang Liu
Committed by
GitHub
Sep 22, 2025
Browse files
[Bugfix][V0 Deprecation][CI] use async mock and await for async method (#25325)
Signed-off-by:
Yang
<
lymailforjob@gmail.com
>
parent
bc6e542d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
9 deletions
+20
-9
tests/entrypoints/openai/test_lora_resolvers.py
tests/entrypoints/openai/test_lora_resolvers.py
+20
-9
No files found.
tests/entrypoints/openai/test_lora_resolvers.py
View file @
04d37523
...
...
@@ -5,7 +5,7 @@ from contextlib import suppress
from
dataclasses
import
dataclass
,
field
from
http
import
HTTPStatus
from
typing
import
Optional
from
unittest.mock
import
MagicMock
from
unittest.mock
import
AsyncMock
,
MagicMock
import
pytest
...
...
@@ -83,20 +83,31 @@ def register_mock_resolver():
def
mock_serving_setup
():
"""Provides a mocked engine and serving completion instance."""
mock_engine
=
MagicMock
(
spec
=
AsyncLLM
)
mock_engine
.
get_tokenizer
.
return_value
=
get_tokenizer
(
MODEL_NAME
)
mock_engine
.
errored
=
False
def
mock_add_lora_side_effect
(
lora_request
:
LoRARequest
):
tokenizer
=
get_tokenizer
(
MODEL_NAME
)
mock_engine
.
get_tokenizer
=
AsyncMock
(
return_value
=
tokenizer
)
async
def
mock_add_lora_side_effect
(
lora_request
:
LoRARequest
):
"""Simulate engine behavior when adding LoRAs."""
if
lora_request
.
lora_name
==
"test-lora"
:
# Simulate successful addition
return
el
if
lora_request
.
lora_name
==
"invalid-lora"
:
return
True
if
lora_request
.
lora_name
==
"invalid-lora"
:
# Simulate failure during addition (e.g. invalid format)
raise
ValueError
(
f
"Simulated failure adding LoRA: "
f
"
{
lora_request
.
lora_name
}
"
)
return
True
mock_engine
.
add_lora
=
AsyncMock
(
side_effect
=
mock_add_lora_side_effect
)
async
def
mock_generate
(
*
args
,
**
kwargs
):
for
_
in
[]:
yield
_
mock_engine
.
generate
=
MagicMock
(
spec
=
AsyncLLM
.
generate
,
side_effect
=
mock_generate
)
mock_engine
.
add_lora
.
side_effect
=
mock_add_lora_side_effect
mock_engine
.
generate
.
reset_mock
()
mock_engine
.
add_lora
.
reset_mock
()
...
...
@@ -131,7 +142,7 @@ async def test_serving_completion_with_lora_resolver(mock_serving_setup,
with
suppress
(
Exception
):
await
serving_completion
.
create_completion
(
req_found
)
mock_engine
.
add_lora
.
assert_
call
ed_once
()
mock_engine
.
add_lora
.
assert_
await
ed_once
()
called_lora_request
=
mock_engine
.
add_lora
.
call_args
[
0
][
0
]
assert
isinstance
(
called_lora_request
,
LoRARequest
)
assert
called_lora_request
.
lora_name
==
lora_model_name
...
...
@@ -157,7 +168,7 @@ async def test_serving_completion_resolver_not_found(mock_serving_setup,
response
=
await
serving_completion
.
create_completion
(
req
)
mock_engine
.
add_lora
.
assert_not_
call
ed
()
mock_engine
.
add_lora
.
assert_not_
await
ed
()
mock_engine
.
generate
.
assert_not_called
()
assert
isinstance
(
response
,
ErrorResponse
)
...
...
@@ -181,7 +192,7 @@ async def test_serving_completion_resolver_add_lora_fails(
response
=
await
serving_completion
.
create_completion
(
req
)
# Assert add_lora was called before the failure
mock_engine
.
add_lora
.
assert_
call
ed_once
()
mock_engine
.
add_lora
.
assert_
await
ed_once
()
called_lora_request
=
mock_engine
.
add_lora
.
call_args
[
0
][
0
]
assert
isinstance
(
called_lora_request
,
LoRARequest
)
assert
called_lora_request
.
lora_name
==
invalid_model
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment