Skip to content

GitLab

Unverified Commit 02d4b854 authored by Andrew Sansom's avatar Andrew Sansom Committed by GitHub
Browse files

Use kwargs for long lists of `EngineCoreRequest` arguments in tests and fix extra kwargs (#24987) 


Signed-off-by: default avatarAndrew Sansom <andrew@protopia.ai>
parent 86daa875
Hide whitespace changes
Inline Side-by-side
Showing with 16 additions and 18 deletions
tests/detokenizer/test_min_tokens.py
View file @ 02d4b854
...@@ -31,16 +31,14 @@ def test_min_tokens_with_stop(min_tokens: int, stop: str, truth: str): ...@@ -31,16 +31,14 @@ def test_min_tokens_with_stop(min_tokens: int, stop: str, truth: str):
stop=stop, stop=stop,
min_tokens=min_tokens, min_tokens=min_tokens,
) )
request = EngineCoreRequest("", request = EngineCoreRequest(request_id="",
prompt_token_ids, prompt_token_ids=prompt_token_ids,
None, mm_features=None,
None, sampling_params=params,
None, pooling_params=None,
params, eos_token_id=None,
None, arrival_time=0.0,
None, lora_request=None,
0.0,
None,
cache_salt=None, cache_salt=None,
data_parallel_rank=None) data_parallel_rank=None)
......
tests/tokenization/test_detokenize.py
View file @ 02d4b854
...@@ -61,14 +61,14 @@ def _run_incremental_decode(tokenizer, ...@@ -61,14 +61,14 @@ def _run_incremental_decode(tokenizer,
skip_special_tokens=skip_special_tokens, skip_special_tokens=skip_special_tokens,
spaces_between_special_tokens=spaces_between_special_tokens, spaces_between_special_tokens=spaces_between_special_tokens,
) )
request = EngineCoreRequest("", request = EngineCoreRequest(request_id="",
prompt_token_ids, prompt_token_ids=prompt_token_ids,
None, mm_features=None,
params, sampling_params=params,
None, pooling_params=None,
None, eos_token_id=None,
0.0, arrival_time=0.0,
None, lora_request=None,
cache_salt=None, cache_salt=None,
data_parallel_rank=None) data_parallel_rank=None)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment