"vllm/vscode:/vscode.git/clone" did not exist on "a258ad8bcc0014c04d11a9bc8c6591b379c31b68"
  • Nick Hill's avatar
    [Tests] Shutdown test `RemoteVLLMServer` cleanly (#36950) · b373b510
    Nick Hill authored
    
    
    Recent PR #33949 changed the teardown logic of the RemoteVLLMServer test utility class to
    send SIGTERM to all vllm (sub)processes at once, which breaks the clean/coordinated
    shutdown logic that assumes only the top-level process will receive a signal (for example
    when running in a container that's shut down).
    
    This caused a bunch of errors and stacktraces in some test logs, even though those tests
    still pass. We should still attempt a normal shutdown and only kill other procs if they are
    still running after a few seconds.
    
    Example: tests/v1/distributed/test_external_lb_dp.py::test_external_lb_completion_streaming
    Signed-off-by: default avatarNick Hill <nickhill123@gmail.com>
    b373b510
utils.py 59.2 KB