test_utils.py 8.87 KB
Newer Older
1
import asyncio
2
3
import os
import socket
4
from functools import partial
5
from typing import AsyncIterator, Tuple
6

7
8
import pytest

9
from vllm.utils import (FlexibleArgumentParser, StoreBoolean, deprecate_kwargs,
10
                        get_open_port, merge_async_iterators, supports_kw)
11
12
13

from .utils import error_on_warning

14
15
16
17

@pytest.mark.asyncio
async def test_merge_async_iterators():

18
    async def mock_async_iterator(idx: int):
19
20
21
22
23
        try:
            while True:
                yield f"item from iterator {idx}"
                await asyncio.sleep(0.1)
        except asyncio.CancelledError:
24
            print(f"iterator {idx} cancelled")
25
26

    iterators = [mock_async_iterator(i) for i in range(3)]
27
28
29
30
    merged_iterator = merge_async_iterators(*iterators,
                                            is_cancelled=partial(asyncio.sleep,
                                                                 0,
                                                                 result=False))
31
32
33
34
35
36
37
38
39
40
41
42
43

    async def stream_output(generator: AsyncIterator[Tuple[int, str]]):
        async for idx, output in generator:
            print(f"idx: {idx}, output: {output}")

    task = asyncio.create_task(stream_output(merged_iterator))
    await asyncio.sleep(0.5)
    task.cancel()
    with pytest.raises(asyncio.CancelledError):
        await task

    for iterator in iterators:
        try:
44
45
            # Can use anext() in python >= 3.10
            await asyncio.wait_for(iterator.__anext__(), 1)
46
47
48
49
50
51
        except StopAsyncIteration:
            # All iterators should be cancelled and print this message.
            print("Iterator was cancelled normally")
        except (Exception, asyncio.CancelledError) as e:
            raise AssertionError() from e

52
53
54
55
56
57
58
59
60
61

def test_deprecate_kwargs_always():

    @deprecate_kwargs("old_arg", is_deprecated=True)
    def dummy(*, old_arg: object = None, new_arg: object = None):
        pass

    with pytest.warns(DeprecationWarning, match="'old_arg'"):
        dummy(old_arg=1)

62
    with error_on_warning(DeprecationWarning):
63
64
65
66
67
68
69
70
71
        dummy(new_arg=1)


def test_deprecate_kwargs_never():

    @deprecate_kwargs("old_arg", is_deprecated=False)
    def dummy(*, old_arg: object = None, new_arg: object = None):
        pass

72
    with error_on_warning(DeprecationWarning):
73
74
        dummy(old_arg=1)

75
    with error_on_warning(DeprecationWarning):
76
77
78
79
80
81
82
83
84
85
86
87
88
        dummy(new_arg=1)


def test_deprecate_kwargs_dynamic():
    is_deprecated = True

    @deprecate_kwargs("old_arg", is_deprecated=lambda: is_deprecated)
    def dummy(*, old_arg: object = None, new_arg: object = None):
        pass

    with pytest.warns(DeprecationWarning, match="'old_arg'"):
        dummy(old_arg=1)

89
    with error_on_warning(DeprecationWarning):
90
91
92
93
        dummy(new_arg=1)

    is_deprecated = False

94
    with error_on_warning(DeprecationWarning):
95
96
        dummy(old_arg=1)

97
    with error_on_warning(DeprecationWarning):
98
99
100
101
102
103
104
105
106
107
108
        dummy(new_arg=1)


def test_deprecate_kwargs_additional_message():

    @deprecate_kwargs("old_arg", is_deprecated=True, additional_message="abcd")
    def dummy(*, old_arg: object = None, new_arg: object = None):
        pass

    with pytest.warns(DeprecationWarning, match="abcd"):
        dummy(old_arg=1)
109
110
111
112
113
114
115
116
117
118
119
120


def test_get_open_port():
    os.environ["VLLM_PORT"] = "5678"
    # make sure we can get multiple ports, even if the env var is set
    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s1:
        s1.bind(("localhost", get_open_port()))
        with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s2:
            s2.bind(("localhost", get_open_port()))
            with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s3:
                s3.bind(("localhost", get_open_port()))
    os.environ.pop("VLLM_PORT")
121
122
123
124
125
126
127
128
129
130
131
132
133
134


# Tests for FlexibleArgumentParser
@pytest.fixture
def parser():
    parser = FlexibleArgumentParser()
    parser.add_argument('--image-input-type',
                        choices=['pixel_values', 'image_features'])
    parser.add_argument('--model-name')
    parser.add_argument('--batch-size', type=int)
    parser.add_argument('--enable-feature', action='store_true')
    return parser


135
136
137
138
@pytest.fixture
def parser_with_config():
    parser = FlexibleArgumentParser()
    parser.add_argument('serve')
139
140
    parser.add_argument('model_tag')
    parser.add_argument('--served-model-name', type=str)
141
142
143
    parser.add_argument('--config', type=str)
    parser.add_argument('--port', type=int)
    parser.add_argument('--tensor-parallel-size', type=int)
144
145
    parser.add_argument('--trust-remote-code', action='store_true')
    parser.add_argument('--multi-step-stream-outputs', action=StoreBoolean)
146
147
148
    return parser


149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
def test_underscore_to_dash(parser):
    args = parser.parse_args(['--image_input_type', 'pixel_values'])
    assert args.image_input_type == 'pixel_values'


def test_mixed_usage(parser):
    args = parser.parse_args([
        '--image_input_type', 'image_features', '--model-name',
        'facebook/opt-125m'
    ])
    assert args.image_input_type == 'image_features'
    assert args.model_name == 'facebook/opt-125m'


def test_with_equals_sign(parser):
    args = parser.parse_args(
        ['--image_input_type=pixel_values', '--model-name=facebook/opt-125m'])
    assert args.image_input_type == 'pixel_values'
    assert args.model_name == 'facebook/opt-125m'


def test_with_int_value(parser):
    args = parser.parse_args(['--batch_size', '32'])
    assert args.batch_size == 32
    args = parser.parse_args(['--batch-size', '32'])
    assert args.batch_size == 32


def test_with_bool_flag(parser):
    args = parser.parse_args(['--enable_feature'])
    assert args.enable_feature is True
    args = parser.parse_args(['--enable-feature'])
    assert args.enable_feature is True


def test_invalid_choice(parser):
    with pytest.raises(SystemExit):
        parser.parse_args(['--image_input_type', 'invalid_choice'])


def test_missing_required_argument(parser):
    parser.add_argument('--required-arg', required=True)
    with pytest.raises(SystemExit):
        parser.parse_args([])
193
194
195
196


def test_cli_override_to_config(parser_with_config):
    args = parser_with_config.parse_args([
197
        'serve', 'mymodel', '--config', './data/test_config.yaml',
198
199
200
201
        '--tensor-parallel-size', '3'
    ])
    assert args.tensor_parallel_size == 3
    args = parser_with_config.parse_args([
202
        'serve', 'mymodel', '--tensor-parallel-size', '3', '--config',
203
204
205
        './data/test_config.yaml'
    ])
    assert args.tensor_parallel_size == 3
206
207
208
209
210
211
212
    assert args.port == 12312
    args = parser_with_config.parse_args([
        'serve', 'mymodel', '--tensor-parallel-size', '3', '--config',
        './data/test_config.yaml', '--port', '666'
    ])
    assert args.tensor_parallel_size == 3
    assert args.port == 666
213
214
215
216


def test_config_args(parser_with_config):
    args = parser_with_config.parse_args(
217
        ['serve', 'mymodel', '--config', './data/test_config.yaml'])
218
    assert args.tensor_parallel_size == 2
219
220
    assert args.trust_remote_code
    assert not args.multi_step_stream_outputs
221
222
223
224


def test_config_file(parser_with_config):
    with pytest.raises(FileNotFoundError):
225
226
        parser_with_config.parse_args(
            ['serve', 'mymodel', '--config', 'test_config.yml'])
227
228
229

    with pytest.raises(ValueError):
        parser_with_config.parse_args(
230
            ['serve', 'mymodel', '--config', './data/test_config.json'])
231
232
233

    with pytest.raises(ValueError):
        parser_with_config.parse_args([
234
235
            'serve', 'mymodel', '--tensor-parallel-size', '3', '--config',
            '--batch-size', '32'
236
        ])
237
238
239
240
241
242


def test_no_model_tag(parser_with_config):
    with pytest.raises(ValueError):
        parser_with_config.parse_args(
            ['serve', '--config', './data/test_config.yaml'])
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272


# yapf: enable
@pytest.mark.parametrize(
    "callable,kw_name,requires_kw_only,allow_var_kwargs,is_supported",
    [
        # Tests for positional argument support
        (lambda foo: None, "foo", True, True, False),
        (lambda foo: None, "foo", False, True, True),
        # Tests for positional or keyword / keyword only
        (lambda foo=100: None, "foo", True, True, False),
        (lambda *, foo: None, "foo", False, True, True),
        # Tests to make sure the names of variadic params are NOT supported
        (lambda *args: None, "args", False, True, False),
        (lambda **kwargs: None, "kwargs", False, True, False),
        # Tests for if we allow var kwargs to add support
        (lambda foo: None, "something_else", False, True, False),
        (lambda foo, **kwargs: None, "something_else", False, True, True),
        (lambda foo, **kwargs: None, "kwargs", True, True, False),
        (lambda foo, **kwargs: None, "foo", True, True, False),
    ])
# yapf: disable
def test_supports_kw(callable,kw_name,requires_kw_only,
                     allow_var_kwargs,is_supported):
    assert supports_kw(
        callable=callable,
        kw_name=kw_name,
        requires_kw_only=requires_kw_only,
        allow_var_kwargs=allow_var_kwargs
    ) == is_supported