test_lora_manager.py 25.5 KB
Newer Older
1
# SPDX-License-Identifier: Apache-2.0
2
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
3

4
5
6
7
8
9
10
import os

import pytest
import torch
from safetensors.torch import load_file
from torch import nn

11
from vllm.config import ModelConfig, VllmConfig
12
from vllm.config.lora import LoRAConfig
13
14
15
16
17
from vllm.lora.layers import (
    ColumnParallelLinearWithLoRA,
    MergedColumnParallelLinearWithLoRA,
    RowParallelLinearWithLoRA,
)
18
from vllm.lora.lora_weights import LoRALayerWeights, PackedLoRALayerWeights
19
20
21
22
23
24
from vllm.lora.models import (
    LoRAMapping,
    LoRAModel,
    LoRAModelManager,
    LRUCacheLoRAModelManager,
)
25
from vllm.lora.peft_helper import PEFTHelper
26
from vllm.lora.request import LoRARequest
27
from vllm.lora.worker_manager import LRUCacheWorkerLoRAManager, WorkerLoRAManager
28
from vllm.platforms import current_platform
29

30
31
from .utils import create_peft_lora

Terry's avatar
Terry committed
32
33
34
35
36
37
38
EMBEDDING_MODULES = {
    "embed_tokens": "input_embeddings",
    "lm_head": "output_embeddings",
}

EMBEDDING_PADDING_MODULES = ["lm_head"]

39
40
41
42
43
DEVICES = (
    [f"cuda:{i}" for i in range(1 if torch.cuda.device_count() == 1 else 2)]
    if current_platform.is_cuda_alike()
    else ["cpu"]
)
44

45
46
DEFAULT_DTYPE = torch.get_default_dtype()

47

48
@pytest.mark.parametrize("device", DEVICES)
49
def test_from_lora_tensors(sql_lora_files, device):
50
    tensors = load_file(os.path.join(sql_lora_files, "adapter_model.safetensors"))
51
    new_embeddings = load_file(
52
53
        os.path.join(sql_lora_files, "new_embeddings.safetensors")
    )
54

55
56
57
    peft_helper = PEFTHelper.from_local_dir(
        sql_lora_files, max_position_embeddings=4096
    )
Terry's avatar
Terry committed
58
59
60
    lora_model = LoRAModel.from_lora_tensors(
        1,
        tensors,
61
62
        peft_helper=peft_helper,
        device=device,
Terry's avatar
Terry committed
63
64
        embeddings=new_embeddings,
        embedding_modules=EMBEDDING_MODULES,
65
66
        embedding_padding_modules=EMBEDDING_PADDING_MODULES,
    )
67
68
69
70
71
72
    for module_name, lora in lora_model.loras.items():
        assert lora.module_name == module_name
        assert lora.rank == 8
        assert lora.lora_alpha == 16
        assert lora.lora_a is not None
        assert lora.lora_b is not None
73
74
        assert lora.lora_a.device == torch.device(device)
        assert lora.lora_b.device == torch.device(device)
75
76
77
        assert lora.lora_a.shape[0] == lora.lora_b.shape[1], (
            f"{lora.lora_a.shape=}, {lora.lora_b.shape=}"
        )
78
        assert lora.lora_a.shape[0] == 8
79
        embeddings_module = next(
80
81
            (k for k in EMBEDDING_MODULES if k in module_name), None
        )
82
83
84
85
        if embeddings_module:
            assert torch.equal(
                lora.embeddings_tensor,
                new_embeddings[EMBEDDING_MODULES[embeddings_module]].to(
86
87
88
                    device=lora.embeddings_tensor.device
                ),
            )
89
90
91
92
        else:
            assert lora.embeddings_tensor is None


93
94
95
def create_lora(
    lora_id: int, model: nn.Module, sub_modules: list[str], device: torch.device
) -> LoRAModel:
96
    loras: dict[str, LoRALayerWeights] = {}
97
98
99
100
101
102
    for name in sub_modules:
        w = model.get_submodule(name).weight
        loras[name] = LoRALayerWeights(
            name,
            8,
            16,
103
104
            torch.rand([8, w.shape[1]], device=device),
            torch.rand([w.shape[0], 8], device=device),
105
106
107
108
109
110
111
112
113
        )
    return LoRAModel(lora_id, 8, loras)


def create_packed_lora(
    lora_id: int,
    model: nn.Module,
    module_name,
    replaced_module_names,
114
    device: torch.device,
115
116
117
    empty_replaced_module_name=None,
) -> LoRAModel:
    w = model.get_submodule(module_name).weight
118
    loras: dict[str, LoRALayerWeights] = {}
119
120
121
122
123
124
125
    for replaced_module_name in replaced_module_names:
        if replaced_module_name == empty_replaced_module_name:
            continue
        loras[replaced_module_name] = LoRALayerWeights(
            replaced_module_name,
            8,
            16,
126
            torch.rand([8, w.shape[1]], device=device),
127
            torch.rand([w.shape[0] // len(replaced_module_names), 8], device=device),
128
129
130
131
132
133
        )
    return LoRAModel(lora_id, 8, loras)


def test_replace_submodules(dist_init, dummy_model):
    model = dummy_model
Terry's avatar
Terry committed
134
    manager = LoRAModelManager(
135
136
137
138
139
140
141
142
143
        model,
        1,
        1,
        1,
        LoRAConfig(
            max_lora_rank=8, max_cpu_loras=8, max_loras=8, lora_dtype=DEFAULT_DTYPE
        ),
        torch.device(DEVICES[0]),
    )
144
    model = manager.model
145
146
147
148
    assert isinstance(model.get_submodule("dense1"), ColumnParallelLinearWithLoRA)
    assert isinstance(
        model.get_submodule("layer1.dense1"), ColumnParallelLinearWithLoRA
    )
149
    assert isinstance(model.get_submodule("dense2"), RowParallelLinearWithLoRA)
150
    assert isinstance(model.get_submodule("layer1.dense2"), RowParallelLinearWithLoRA)
151
152


153
@pytest.mark.parametrize("device", DEVICES)
154
def test_lora_model_manager(dist_init, dummy_model, device):
155
    model = dummy_model
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
    model_lora1 = create_lora(
        1, model, ["layer1.dense1", "dense2", "lm_head"], device=device
    )
    model_lora2 = create_lora(2, model, ["dense1", "dense2", "lm_head"], device=device)
    model_lora3 = create_lora(3, model, ["dense1", "dense2", "lm_head"], device=device)
    manager = LoRAModelManager(
        model,
        2,
        2,
        2,
        LoRAConfig(
            max_lora_rank=8, max_cpu_loras=3, max_loras=2, lora_dtype=DEFAULT_DTYPE
        ),
        device=device,
    )
171
    assert all(x is None for x in manager.lora_index_to_id)
172
173
    assert manager.add_adapter(model_lora1)
    assert manager.activate_adapter(1)
174
    assert manager.lora_index_to_id[0] == 1
175
176
177
178
    assert not manager.add_adapter(model_lora1)
    assert not manager.activate_adapter(1)
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(2)
179
180
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2
181
182
183
    assert not manager.add_adapter(model_lora2)
    assert not manager.activate_adapter(2)
    assert manager.add_adapter(model_lora3)
184
185
186
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2
    with pytest.raises(ValueError):
187
        assert manager.activate_adapter(3)
188
189
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2
190
    assert manager.remove_adapter(model_lora2.id)
191
    assert manager.lora_index_to_id[1] is None
192
193
194
195
    assert not manager.remove_adapter(model_lora2.id)
    assert manager.remove_adapter(model_lora1.id)
    assert not manager.remove_adapter(model_lora1.id)
    assert manager.add_adapter(model_lora1)
196
197
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] is None
198
199
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(3)
200
201
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] is None
202
    assert manager.activate_adapter(2)
203
204
205
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 2

206
207
    assert manager.device == device
    assert manager.punica_wrapper.device == device
208
209
210
211
212
213
214
    assert hasattr(manager, "supported_lora_modules")
    assert sorted(manager.supported_lora_modules) == [
        "dense1",
        "dense2",
        "lm_head",
        "output",
    ]
215

216

217
@pytest.mark.parametrize("device", DEVICES)
218
def test_lora_lru_cache_model_manager(dist_init, dummy_model, device):
219
    model = dummy_model
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
    model_lora1 = create_lora(
        1, model, ["layer1.dense1", "dense2", "lm_head"], device=device
    )
    model_lora2 = create_lora(2, model, ["dense1", "dense2", "lm_head"], device=device)
    model_lora3 = create_lora(3, model, ["dense1", "dense2", "lm_head"], device=device)
    manager = LRUCacheLoRAModelManager(
        model,
        2,
        2,
        2,
        LoRAConfig(
            max_lora_rank=8, max_cpu_loras=3, max_loras=2, lora_dtype=DEFAULT_DTYPE
        ),
        device=device,
    )
235
    assert all(x is None for x in manager.lora_index_to_id)
236
237
    assert manager.add_adapter(model_lora1)
    assert manager.activate_adapter(1)
238
    assert manager.lora_index_to_id[0] == 1
239
240
241
242
    assert not manager.add_adapter(model_lora1)
    assert not manager.activate_adapter(1)
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(2)
243
244
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2
245
246
247
    assert not manager.add_adapter(model_lora2)
    assert not manager.activate_adapter(2)
    assert manager.add_adapter(model_lora3)
248
249
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2
250
    assert manager.activate_adapter(3)
251
252
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 2
253
    assert manager.remove_adapter(model_lora2.id)
254
    assert manager.lora_index_to_id[1] is None
255
256
257
258
259
    assert not manager.remove_adapter(model_lora2.id)
    assert manager.remove_adapter(model_lora1.id)
    assert not manager.remove_adapter(model_lora1.id)
    assert manager.add_adapter(model_lora1)
    assert manager.activate_adapter(1)
260
261
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 1
262
263
    assert manager.add_adapter(model_lora2)
    assert manager.deactivate_adapter(3)
264
265
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] == 1
266
    assert manager.activate_adapter(2)
267
268
    assert manager.lora_index_to_id[0] == 2
    assert manager.lora_index_to_id[1] == 1
269
    assert manager.activate_adapter(3)
270
271
    assert manager.lora_index_to_id[0] == 2
    assert manager.lora_index_to_id[1] == 3
272
    assert manager.pin_adapter(2)
273
274
    assert manager.lora_index_to_id[0] == 2
    assert manager.lora_index_to_id[1] == 3
275
    assert manager.activate_adapter(1)
276
277
    assert manager.lora_index_to_id[0] == 2
    assert manager.lora_index_to_id[1] == 1
278
    assert manager.deactivate_adapter(2)
279
280
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] == 1
281
    assert manager.activate_adapter(3)
282
283
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 1
284
285
    assert manager.pin_adapter(3)
    assert manager.pin_adapter(1)
286
    with pytest.raises(RuntimeError):
287
        assert manager.pin_adapter(2)
288
289
290
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 1
    with pytest.raises(RuntimeError):
291
        assert manager.activate_adapter(2)
292

293
294
    assert manager.deactivate_adapter(3)
    assert manager.pin_adapter(2)
295
296
    assert manager.lora_index_to_id[0] == 2
    assert manager.lora_index_to_id[1] == 1
297
    assert manager.remove_adapter(3)
298
    with pytest.raises(ValueError):
299
        assert manager.pin_adapter(3)
300

301
302
303
    assert manager.punica_wrapper.device == device
    assert manager.device == device

304

305
@pytest.mark.parametrize("device", DEVICES)
306
def test_lru_lora_model_manager(dist_init, dummy_model, device):
307
308
309
    # This tests just the LRU cache functionality, everything else is
    # tested in test_lora_model_manager
    model = dummy_model
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
    model_lora1 = create_lora(
        1, model, ["layer1.dense1", "dense2", "lm_head"], device=device
    )
    model_lora2 = create_lora(2, model, ["dense1", "dense2", "lm_head"], device=device)
    model_lora3 = create_lora(3, model, ["dense1", "dense2", "lm_head"], device=device)
    model_lora4 = create_lora(4, model, ["dense1", "dense2", "lm_head"], device=device)
    manager = LRUCacheLoRAModelManager(
        model,
        2,
        2,
        2,
        LoRAConfig(
            max_lora_rank=8, max_cpu_loras=2, max_loras=2, lora_dtype=DEFAULT_DTYPE
        ),
        device=device,
    )
326
327
328
    assert all(x is None for x in manager.lora_index_to_id)

    # Add up to capacity
329
330
331
332
    assert manager.add_adapter(model_lora1)
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(1)
    assert manager.activate_adapter(2)
333

334
    assert set(manager.list_adapters()) == {1, 2}
335
336
337
338
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2

    # Add over capacity
339
340
341
342
    assert manager.add_adapter(model_lora3)
    assert manager.add_adapter(model_lora4)
    assert manager.activate_adapter(3)
    assert manager.activate_adapter(4)
343

344
    assert set(manager.list_adapters()) == {3, 4}
345
346
347
348
349
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 4

    # Add 3 again to move it to the top and then add 2
    # should return false since it's in already
350
351
352
353
    assert not manager.add_adapter(model_lora3)
    assert not manager.activate_adapter(3)
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(2)
354

355
    assert set(manager.list_adapters()) == {3, 2}
356
357
358
359
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 2

    # Remove manually
360
361
    assert manager.remove_adapter(3)
    assert not manager.remove_adapter(3)
362

363
    assert set(manager.list_adapters()) == {2}
364
365
366
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] == 2

367
368
369
370
    assert manager.add_adapter(model_lora3)
    assert manager.activate_adapter(3)
    assert manager.add_adapter(model_lora4)
    assert manager.activate_adapter(4)
371

372
    assert set(manager.list_adapters()) == {3, 4}
373
374
375
    assert manager.lora_index_to_id[0] == 3
    assert manager.lora_index_to_id[1] == 4

376
377
    assert manager.remove_oldest_adapter()
    assert set(manager.list_adapters()) == {4}
378
379
380
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] == 4

381
382
    assert manager.remove_oldest_adapter()
    assert set(manager.list_adapters()) == set()
383
384
    assert all(x is None for x in manager.lora_index_to_id)

385
386
    assert not manager.remove_oldest_adapter()
    assert set(manager.list_adapters()) == set()
387
388
    assert all(x is None for x in manager.lora_index_to_id)

389
    # pinning
390
391
392
393
394
    assert manager.add_adapter(model_lora3)
    assert manager.activate_adapter(3)
    assert manager.add_adapter(model_lora4)
    assert manager.activate_adapter(4)
    assert set(manager.list_adapters()) == {3, 4}
395
    with pytest.raises(ValueError):
396
397
        assert manager.pin_adapter(1)
    assert manager.pin_adapter(3)
398
    # Remove manually
399
400
    assert manager.remove_adapter(3)
    assert not manager.remove_adapter(3)
401

402
    assert set(manager.list_adapters()) == {4}
403
404
405
    assert manager.lora_index_to_id[0] is None
    assert manager.lora_index_to_id[1] == 4

406
407
408
409
    assert manager.add_adapter(model_lora1)
    assert manager.pin_adapter(1)
    assert manager.add_adapter(model_lora2)
    assert manager.activate_adapter(2)
410

411
    assert set(manager.list_adapters()) == {1, 2}
412
413
414
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] == 2

415
416
    assert manager.remove_oldest_adapter()
    assert set(manager.list_adapters()) == {1}
417
418
419
420
    assert manager.lora_index_to_id[0] == 1
    assert manager.lora_index_to_id[1] is None

    with pytest.raises(RuntimeError):
421
        assert manager.remove_oldest_adapter()
422

423
    assert set(manager.list_adapters()) == {1}
424
425
    assert manager.punica_wrapper.device == device
    assert manager.device == device
426

427

428
@pytest.mark.parametrize("device", DEVICES)
429
430
431
432
def test_lru_cache_worker_adapter_manager(dist_init, dummy_model, device, tmp_path):
    lora_config = LoRAConfig(
        max_lora_rank=8, max_cpu_loras=4, max_loras=4, lora_dtype=DEFAULT_DTYPE
    )
433
434
435
436
437
438
439
440
441

    dummy_lora_files = f"{tmp_path}/lora_adapter"
    os.makedirs(dummy_lora_files, exist_ok=True)
    create_peft_lora(
        dummy_model,
        save_dir=dummy_lora_files,
        target_modules=["layer1.dense1", "dense2"],
        lora_dtype=DEFAULT_DTYPE,
    )
442
443

    model_config = ModelConfig(max_model_len=16)
444
    vllm_config = VllmConfig(model_config=model_config, lora_config=lora_config)
445
446
447

    vllm_config.scheduler_config.max_num_seqs = 4
    vllm_config.scheduler_config.max_num_batched_tokens = 2
448
    worker_adapter_manager = LRUCacheWorkerLoRAManager(
449
450
        vllm_config, device, EMBEDDING_MODULES, EMBEDDING_PADDING_MODULES
    )
451
452
453
454

    worker_adapter_manager.max_num_seqs = 4
    worker_adapter_manager.max_num_batched_tokens = 2

455
    worker_adapter_manager.create_lora_manager(dummy_model)
456
457

    mapping = LoRAMapping([], [])
458
459
460
461
    worker_adapter_manager.set_active_adapters(
        [LoRARequest("1", 1, dummy_lora_files), LoRARequest("2", 2, dummy_lora_files)],
        mapping,
    )
462
463
464
    assert worker_adapter_manager.list_adapters() == {1, 2}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
465

466
467
468
469
470
471
472
473
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("3", 3, dummy_lora_files),
            LoRARequest("4", 4, dummy_lora_files),
        ],
        mapping,
    )
474
475
476
477
478
    assert worker_adapter_manager.list_adapters() == {1, 2, 3, 4}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 3
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[3] == 4
479

480
481
482
483
484
485
486
487
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("2", 2, dummy_lora_files),
            LoRARequest("5", 5, dummy_lora_files),
        ],
        mapping,
    )
488
489
490
491
492
    assert worker_adapter_manager.list_adapters() == {1, 2, 4, 5}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 5
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[3] == 4
493

494
495
496
497
498
499
500
501
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("1", 1, dummy_lora_files),
        ],
        mapping,
    )
502
503
504
505
506
    assert worker_adapter_manager.list_adapters() == {1, 2, 4, 5}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 5
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[3] == 4
507

508
509
510
511
512
513
514
515
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("6", 6, dummy_lora_files),
            LoRARequest("7", 7, dummy_lora_files),
            LoRARequest("8", 8, dummy_lora_files),
        ],
        mapping,
    )
516
517
518
519
520
    assert worker_adapter_manager.list_adapters() == {1, 6, 7, 8}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 7
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 8
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[3] == 6
521
522
523

    # Over capacity
    with pytest.raises(RuntimeError):
524
525
526
527
528
529
530
531
532
533
        worker_adapter_manager.set_active_adapters(
            [
                LoRARequest("10", 10, dummy_lora_files),
                LoRARequest("11", 11, dummy_lora_files),
                LoRARequest("12", 12, dummy_lora_files),
                LoRARequest("13", 13, dummy_lora_files),
                LoRARequest("14", 14, dummy_lora_files),
            ],
            mapping,
        )
534

535
    assert worker_adapter_manager.device == device
536
    assert worker_adapter_manager._adapter_manager.punica_wrapper.device == device
537

538

539
@pytest.mark.parametrize("device", DEVICES)
540
def test_worker_adapter_manager(dist_init, dummy_model_gate_up, device, tmp_path):
541
    # Should remove every LoRA not specified in the request.
542
543
544
    lora_config = LoRAConfig(
        max_lora_rank=8, max_cpu_loras=4, max_loras=4, lora_dtype=DEFAULT_DTYPE
    )
545
546

    model_config = ModelConfig(max_model_len=16)
547
    vllm_config = VllmConfig(model_config=model_config, lora_config=lora_config)
548
549
550
551

    vllm_config.scheduler_config.max_num_seqs = 4
    vllm_config.scheduler_config.max_num_batched_tokens = 2

552
553
554
    worker_adapter_manager = WorkerLoRAManager(
        vllm_config, device, EMBEDDING_MODULES, EMBEDDING_PADDING_MODULES
    )
555
    worker_adapter_manager.vocab_size = (
556
557
        dummy_model_gate_up.unpadded_vocab_size - lora_config.lora_extra_vocab_size
    )
558
559
560
561
562
563
564
565
566
567
    worker_adapter_manager.create_lora_manager(dummy_model_gate_up)

    dummy_lora_files = f"{tmp_path}/lora_adapter"
    os.makedirs(dummy_lora_files, exist_ok=True)
    create_peft_lora(
        dummy_model_gate_up,
        save_dir=dummy_lora_files,
        target_modules=["layer1.dense1", "dense2"],
        lora_dtype=DEFAULT_DTYPE,
    )
568
569

    mapping = LoRAMapping([], [])
570
571
572
573
    worker_adapter_manager.set_active_adapters(
        [LoRARequest("1", 1, dummy_lora_files), LoRARequest("2", 2, dummy_lora_files)],
        mapping,
    )
574
575
576
    assert worker_adapter_manager.list_adapters() == {1, 2}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
577

578
579
580
581
582
583
584
585
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("3", 3, dummy_lora_files),
            LoRARequest("4", 4, dummy_lora_files),
        ],
        mapping,
    )
586
587
588
589
    assert worker_adapter_manager.list_adapters() == {1, 3, 4}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 3
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 4
590

591
592
593
594
595
596
597
598
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("2", 2, dummy_lora_files),
            LoRARequest("5", 5, dummy_lora_files),
        ],
        mapping,
    )
599
600
601
602
    assert worker_adapter_manager.list_adapters() == {1, 2, 5}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 2
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 5
603

604
605
606
607
608
609
610
611
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("1", 1, dummy_lora_files),
            LoRARequest("1", 1, dummy_lora_files),
        ],
        mapping,
    )
612
613
614
615
    assert worker_adapter_manager.list_adapters() == {1}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 1
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] is None
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] is None
616

617
618
619
620
621
622
623
624
    worker_adapter_manager.set_active_adapters(
        [
            LoRARequest("6", 6, dummy_lora_files),
            LoRARequest("7", 7, dummy_lora_files),
            LoRARequest("8", 8, dummy_lora_files),
        ],
        mapping,
    )
625
626
627
628
    assert worker_adapter_manager.list_adapters() == {6, 7, 8}
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[0] == 8
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[1] == 6
    assert worker_adapter_manager._adapter_manager.lora_index_to_id[2] == 7
629
630
631

    # Over capacity
    with pytest.raises(RuntimeError):
632
633
634
635
636
637
638
639
640
641
        worker_adapter_manager.set_active_adapters(
            [
                LoRARequest("10", 10, dummy_lora_files),
                LoRARequest("11", 11, dummy_lora_files),
                LoRARequest("12", 12, dummy_lora_files),
                LoRARequest("13", 13, dummy_lora_files),
                LoRARequest("14", 14, dummy_lora_files),
            ],
            mapping,
        )
642

643
    assert worker_adapter_manager.device == device
644
    assert worker_adapter_manager._adapter_manager.punica_wrapper.device == device
645

646

647
@pytest.mark.parametrize("device", DEVICES)
648
def test_packed_loras(dist_init, dummy_model_gate_up, device):
649
650
651
652
653
    model = dummy_model_gate_up
    model_lora = create_packed_lora(
        1,
        model,
        module_name="gate_up_proj",
654
        replaced_module_names=["gate_proj", "up_proj"],
655
656
        device=device,
    )
657
658
659
660
661
    model_lora1 = create_packed_lora(
        2,
        model,
        module_name="gate_up_proj",
        replaced_module_names=["gate_proj", "up_proj"],
662
        device=device,
663
664
665
        empty_replaced_module_name="gate_proj",
    )

666
667
668
669
670
671
672
673
674
675
    manager = LoRAModelManager(
        model,
        2,
        2,
        2,
        LoRAConfig(
            max_lora_rank=8, max_cpu_loras=2, max_loras=2, lora_dtype=DEFAULT_DTYPE
        ),
        device=device,
    )
676
677
    model = manager.model

678
679
680
    assert isinstance(
        model.get_submodule("gate_up_proj"), MergedColumnParallelLinearWithLoRA
    )
681
682
683
    # Verify packed lora is correct
    model_lora_clone = model_lora.clone(1)
    model_lora_clone1 = model_lora1.clone(1)
684
685
    assert manager.add_adapter(model_lora)
    assert manager.add_adapter(model_lora1)
686

687
688
689
    assert model_lora.get_lora("gate_proj") is None
    assert model_lora.get_lora("up_proj") is None
    assert model_lora1.get_lora("up_proj") is None
690
691
692
    packed_lora = model_lora.get_lora("gate_up_proj")
    assert packed_lora and isinstance(packed_lora, PackedLoRALayerWeights)

693
694
695
696
697
698
699
700
701
702
703
704
    torch.testing.assert_close(
        packed_lora.lora_a[0], model_lora_clone.get_lora("gate_proj").lora_a
    )
    torch.testing.assert_close(
        packed_lora.lora_b[0], model_lora_clone.get_lora("gate_proj").lora_b
    )
    torch.testing.assert_close(
        packed_lora.lora_a[1], model_lora_clone.get_lora("up_proj").lora_a
    )
    torch.testing.assert_close(
        packed_lora.lora_b[1], model_lora_clone.get_lora("up_proj").lora_b
    )
705
706
707
708
709
710

    packed_lora1 = model_lora1.get_lora("gate_up_proj")
    assert packed_lora1 and isinstance(packed_lora1, PackedLoRALayerWeights)

    assert packed_lora1.lora_a[0] is None
    assert packed_lora1.lora_b[0] is None
711
712
713
714
715
716
    torch.testing.assert_close(
        packed_lora1.lora_a[1], model_lora_clone1.get_lora("up_proj").lora_a
    )
    torch.testing.assert_close(
        packed_lora1.lora_b[1], model_lora_clone1.get_lora("up_proj").lora_b
    )