.pre-commit-config.yaml 8.98 KB
Newer Older
1
2
3
default_install_hook_types:
  - pre-commit
  - commit-msg
4
5
6
default_stages:
  - pre-commit # Run locally
  - manual # Run in CI
7
exclude: 'vllm/third_party/.*'
8
9
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
10
  rev: v0.14.0
11
  hooks:
12
  - id: ruff-check
13
    args: [--output-format, github, --fix]
14
  - id: ruff-format
15
- repo: https://github.com/crate-ci/typos
Jiayi Yan's avatar
Jiayi Yan committed
16
  rev: v1.43.5
17
  hooks:
18
  - id: typos
19
    args: [--force-exclude]
20
- repo: https://github.com/pre-commit/mirrors-clang-format
21
  rev: v21.1.2
22
23
  hooks:
  - id: clang-format
24
    exclude: 'csrc/(moe/topk_softmax_kernels.cu|quantization/gguf/(ggml-common.h|dequantize.cuh|vecdotq.cuh|mmq.cuh|mmvq.cuh))|vllm/third_party/.*'
25
26
    types_or: [c++, cuda]
    args: [--style=file, --verbose]
27
28
- repo: https://github.com/DavidAnson/markdownlint-cli2
  rev: v0.21.0
29
  hooks:
30
31
32
  - id: markdownlint-cli2
    language_version: lts
    args: [--fix]
Harry Mellor's avatar
Harry Mellor committed
33
    exclude: ^CLAUDE\.md$
34
- repo: https://github.com/rhysd/actionlint
35
  rev: v1.7.7
36
37
  hooks:
  - id: actionlint
38
- repo: https://github.com/astral-sh/uv-pre-commit
39
  rev: 0.11.1
40
41
  hooks:
    - id: pip-compile
42
      args: [requirements/test.in, -c, requirements/common.txt, -o, requirements/test.txt, --index-strategy, unsafe-best-match, --torch-backend, cu130, --python-platform, x86_64-manylinux_2_28, --python-version, "3.12"]
43
      files: ^requirements/test\.(in|txt)$
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
    - id: pip-compile
      alias: pip-compile-rocm
      name: pip-compile-rocm
      args: [
        requirements/rocm-test.in, -o, requirements/rocm-test.txt,
        --index-strategy, unsafe-best-match,
        -c, requirements/rocm.txt,
        --python-platform, x86_64-manylinux_2_28,
        --python-version, "3.12",
        # Exclude torch and CUDA/NVIDIA packages
        --no-emit-package, torch,
        --no-emit-package, torchvision,
        --no-emit-package, torchaudio,
        --no-emit-package, triton,
        --no-emit-package, cuda-bindings,
        --no-emit-package, cuda-pathfinder,
        --no-emit-package, cuda-toolkit,
        --no-emit-package, cupy-cuda12x,
62
        # nvidia packages (unsuffixed / unified naming)
63
64
65
66
        --no-emit-package, nvidia-cublas,
        --no-emit-package, nvidia-cuda-cupti,
        --no-emit-package, nvidia-cuda-nvrtc,
        --no-emit-package, nvidia-cuda-runtime,
67
        --no-emit-package, nvidia-cudnn,
68
69
70
71
72
        --no-emit-package, nvidia-cufft,
        --no-emit-package, nvidia-cufile,
        --no-emit-package, nvidia-curand,
        --no-emit-package, nvidia-cusolver,
        --no-emit-package, nvidia-cusparse,
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
        --no-emit-package, nvidia-cusparselt,
        --no-emit-package, nvidia-nccl,
        --no-emit-package, nvidia-nvjitlink,
        --no-emit-package, nvidia-nvshmem,
        --no-emit-package, nvidia-nvtx,
        # nvidia cu12 packages
        --no-emit-package, nvidia-cublas-cu12,
        --no-emit-package, nvidia-cuda-cupti-cu12,
        --no-emit-package, nvidia-cuda-nvrtc-cu12,
        --no-emit-package, nvidia-cuda-runtime-cu12,
        --no-emit-package, nvidia-cudnn-cu12,
        --no-emit-package, nvidia-cufft-cu12,
        --no-emit-package, nvidia-cufile-cu12,
        --no-emit-package, nvidia-curand-cu12,
        --no-emit-package, nvidia-cusolver-cu12,
        --no-emit-package, nvidia-cusparse-cu12,
        --no-emit-package, nvidia-cusparselt-cu12,
        --no-emit-package, nvidia-nccl-cu12,
        --no-emit-package, nvidia-nvjitlink-cu12,
        --no-emit-package, nvidia-nvshmem-cu12,
        --no-emit-package, nvidia-nvtx-cu12,
        # nvidia cu13 packages
        --no-emit-package, nvidia-cublas-cu13,
        --no-emit-package, nvidia-cuda-cupti-cu13,
        --no-emit-package, nvidia-cuda-nvrtc-cu13,
        --no-emit-package, nvidia-cuda-runtime-cu13,
        --no-emit-package, nvidia-cudnn-cu13,
        --no-emit-package, nvidia-cufft-cu13,
        --no-emit-package, nvidia-cufile-cu13,
        --no-emit-package, nvidia-curand-cu13,
        --no-emit-package, nvidia-cusolver-cu13,
        --no-emit-package, nvidia-cusparse-cu13,
105
106
        --no-emit-package, nvidia-cusparselt-cu13,
        --no-emit-package, nvidia-nccl-cu13,
107
        --no-emit-package, nvidia-nvjitlink-cu13,
108
        --no-emit-package, nvidia-nvshmem-cu13,
109
        --no-emit-package, nvidia-nvtx-cu13,
110
111
      ]
      files: ^requirements/rocm-test\.(in|txt)$
112
113
- repo: local
  hooks:
114
115
116
  - id: format-torch-nightly-test
    name: reformat nightly_torch_test.txt to be in sync with test.in
    language: python
117
    entry: python tools/pre_commit/generate_nightly_torch_test.py
118
    files: ^requirements/test\.(in|txt)$
119
  - id: mypy-local
120
121
    name: Run mypy locally for lowest supported Python version
    entry: python tools/pre_commit/mypy.py 0 "3.10"
122
    stages: [pre-commit] # Don't run in CI
123
124
125
126
    <<: &mypy_common
      language: python
      types_or: [python, pyi]
      require_serial: true
127
      additional_dependencies: ["mypy[faster-cache]==1.19.1", regex, types-cachetools, types-setuptools, types-PyYAML, types-requests, types-torch, pydantic]
128
129
  - id: mypy-3.10 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
    name: Run mypy for Python 3.10
130
131
    entry: python tools/pre_commit/mypy.py 1 "3.10"
    <<: *mypy_common
132
    stages: [manual] # Only run in CI
133
134
  - id: mypy-3.11 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
    name: Run mypy for Python 3.11
135
136
    entry: python tools/pre_commit/mypy.py 1 "3.11"
    <<: *mypy_common
137
    stages: [manual] # Only run in CI
138
139
  - id: mypy-3.12 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
    name: Run mypy for Python 3.12
140
141
    entry: python tools/pre_commit/mypy.py 1 "3.12"
    <<: *mypy_common
142
    stages: [manual] # Only run in CI
143
144
145
146
147
  - id: mypy-3.13 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
    name: Run mypy for Python 3.13
    entry: python tools/pre_commit/mypy.py 1 "3.13"
    <<: *mypy_common
    stages: [manual] # Only run in CI
148
149
  - id: shellcheck
    name: Lint shell scripts
150
    entry: tools/pre_commit/shellcheck.sh
151
152
153
154
    language: script
    types: [shell]
  - id: png-lint
    name: Lint PNG exports from excalidraw
155
    entry: tools/pre_commit/png-lint.sh
156
157
    language: script
    types: [png]
158
159
160
161
162
163
  - id: signoff-commit
    name: Sign-off Commit
    entry: bash
    args:
      - -c
      - |
164
165
        if ! grep -q "^Signed-off-by: $(git config user.name) <$(git config user.email)>" "$(git rev-parse --git-path COMMIT_EDITMSG)"; then
          printf "\nSigned-off-by: $(git config user.name) <$(git config user.email)>\n" >> "$(git rev-parse --git-path COMMIT_EDITMSG)"
166
167
168
169
        fi
    language: system
    verbose: true
    stages: [commit-msg]
170
171
  - id: check-spdx-header
    name: Check SPDX headers
172
    entry: python tools/pre_commit/check_spdx_header.py
173
174
    language: python
    types: [python]
175
176
  - id: check-root-lazy-imports
    name: Check root lazy imports
177
    entry: python tools/pre_commit/check_init_lazy_imports.py
178
179
    language: python
    types: [python]
180
181
  - id: check-filenames
    name: Check for spaces in all filenames
182
183
184
185
    entry: bash
    args:
      - -c
      - 'git ls-files | grep " " && echo "Filenames should not contain spaces!" && exit 1 || exit 0'
186
187
188
    language: system
    always_run: true
    pass_filenames: false
189
190
  - id: update-dockerfile-graph
    name: Update Dockerfile dependency graph
191
    entry: tools/pre_commit/update-dockerfile-graph.sh
192
    language: script
193
194
195
  - id: check-forbidden-imports
    name: Check for forbidden imports
    entry: python tools/pre_commit/check_forbidden_imports.py
196
197
    language: python
    types: [python]
198
    additional_dependencies: [regex]
199
200
201
202
203
204
205
  # prevent use torch.cuda APIs
  - id: check-torch-cuda-call
    name: "Prevent new 'torch.cuda' APIs call"
    entry: python tools/pre_commit/check_torch_cuda.py
    language: python
    types: [python]
    additional_dependencies: [regex]
206
207
  - id: validate-config
    name: Validate configuration has default values and that each field has a docstring
208
    entry: python tools/pre_commit/validate_config.py
209
    language: python
210
    additional_dependencies: [regex]
211
212
213
214
215
216
217
  - id: validate-docker-versions
    name: Validate docker/versions.json matches Dockerfile
    entry: python tools/generate_versions_json.py --check
    language: python
    files: ^docker/(Dockerfile|versions\.json)$
    pass_filenames: false
    additional_dependencies: [dockerfile-parse]
218
219
220
221
  - id: attention-backend-docs
    name: Check attention backend documentation is up to date
    entry: python tools/pre_commit/generate_attention_backend_docs.py --check
    language: python
222
223
224
225
226
  - id: check-boolean-context-manager
    name: Check for boolean ops in with-statements
    entry: python tools/pre_commit/check_boolean_context_manager.py
    language: python
    types: [python]
227
228
229
  # Keep `suggestion` last
  - id: suggestion
    name: Suggestion
230
    entry: bash -c 'echo "To bypass all the pre-commit hooks, add --no-verify to git commit. To skip a specific hook, prefix the commit command with SKIP=<hook-id>."'
231
232
233
234
    language: system
    verbose: true
    pass_filenames: false
  # Insert new entries above the `suggestion` entry