common.py 22.4 KB
Newer Older
1
2
3
4
5
6
7
8
9
# SPDX-License-Identifier: Apache-2.0
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
from dataclasses import dataclass
from typing import Any, Optional, Union

import torch

import vllm._custom_ops as ops
import vllm.model_executor.layers.fused_moe.modular_kernel as mk
10
11
12
13
from tests.kernels.moe.utils import make_test_weights, per_token_cast_to_fp8
from tests.kernels.quantization.nvfp4_utils import (FLOAT4_E2M1_MAX,
                                                    FLOAT8_E4M3_MAX,
                                                    dequantize_nvfp4_to_dtype)
14
15
16
from tests.kernels.utils import torch_experts
from vllm.config import VllmConfig
from vllm.distributed import get_dp_group, get_tensor_model_parallel_world_size
17
from vllm.forward_context import set_forward_context
18
19
20
21
22
from vllm.model_executor.layers.fused_moe.config import (
    FusedMoEConfig, FusedMoEParallelConfig, FusedMoEQuantConfig)
from vllm.model_executor.layers.fused_moe.fused_moe import fused_topk
from vllm.utils import has_deep_ep, has_deep_gemm, has_pplx

23
from .mk_objects import (TestMoEQuantConfig, expert_info, make_fused_experts,
24
                         make_prepare_finalize, prepare_finalize_info)
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
from .parallel_utils import ProcessGroupInfo


def _describe_tensor(t: Optional[torch.Tensor], name: str) -> str:
    if t is None:
        return f"{name} : None"
    else:
        return f"{name} : {t.shape} {t.dtype} {t.device}"


@dataclass
class Config:
    Ms: Union[list[int], int]
    K: int
    N: int
    E: int
    topks: Union[list[int], int]
    dtype: torch.dtype
43
    quant_config: Optional[TestMoEQuantConfig]
44
45
46
47
48
49
50
51
52

    prepare_finalize_type: mk.FusedMoEPrepareAndFinalize
    fused_experts_type: mk.FusedMoEPermuteExpertsUnpermute

    fused_moe_chunk_size: Optional[int]
    world_size: int

    torch_trace_dir_path: Optional[str] = None

53
54
    def __post_init__(self):
        if self.quant_config is None:
55
            self.quant_config = TestMoEQuantConfig(None, False, False, None)
56

57
58
    def describe(self) -> str:
        s = ""
59
60
61
62
63
64
65
66
67
68
69
70
        s += "== Config:\n"
        s += f" world_size={self.world_size}\n"
        s += f" PF={self.prepare_finalize_type.__name__}\n"
        s += f" FE={self.fused_experts_type.__name__}\n"
        s += f" E={self.E}\n"
        s += f" Ms={self.Ms}\n"
        s += f" N={self.N}\n"
        s += f" K={self.K}\n"
        s += f" topk={self.topks}\n"
        s += f" dtype={self.dtype}\n"
        s += f" fused_moe_chunk_size={self.fused_moe_chunk_size}\n"
        s += " Quant:\n"
71
        if self.quant_config is not None:
72
73
74
75
            s += f"     q_dtype={self.quant_dtype}\n"
            s += f"     q_block_shape={self.quant_block_shape}\n"
            s += f"     q_per_out_ch_quant={self.is_per_out_ch_quant}\n"
            s += f"     q_per_act_token={self.is_per_act_token_quant}\n"
76
        else:
77
            s += "     quant=None\n"
78
79
80
81
82
83
84
85
        return s

    @property
    def M(self) -> int:
        assert isinstance(self.Ms, int)
        return self.Ms

    @property
86
87
    def quant_dtype(self) -> Union[torch.dtype, str, None]:
        assert self.quant_config is not None
88
89
90
91
        return self.quant_config.quant_dtype

    @property
    def is_per_act_token_quant(self) -> bool:
92
        assert self.quant_config is not None
93
94
95
96
97
98
99
100
101
        return self.quant_config.per_act_token_quant

    @property
    def is_per_tensor_act_quant(self) -> bool:
        return (not self.is_per_act_token_quant
                and self.quant_block_shape is None)

    @property
    def is_per_out_ch_quant(self) -> bool:
102
        assert self.quant_config is not None
103
104
105
106
        return self.quant_config.per_out_ch_quant

    @property
    def quant_block_shape(self) -> Optional[list[int]]:
107
        assert self.quant_config is not None
108
109
110
111
112
113
114
115
116
117
118
119
120
        return self.quant_config.block_shape

    @property
    def topk(self) -> int:
        assert isinstance(self.topks, int)
        return self.topks

    @property
    def num_local_experts(self) -> int:
        return self.E // self.world_size

    def make_env_data(self) -> tuple[VllmConfig, dict[Any, Any]]:
        """
121
        make env data for vllm launch.
122
123
124
125
126
127
128
129
        """
        vllm_config = VllmConfig()
        vllm_config.parallel_config.data_parallel_size = self.world_size
        vllm_config.parallel_config.enable_expert_parallel = True

        env_dict = {
            "VLLM_USE_DEEP_GEMM": str(int(self.needs_deep_gemm())),
        }
130
131
132
133
134

        backend = self.all2all_backend()
        if backend is not None:
            env_dict.update({"VLLM_ALL2ALL_BACKEND": backend})

135
136
137
        if self.fused_moe_chunk_size is not None:
            env_dict.update(
                {"VLLM_FUSED_MOE_CHUNK_SIZE": str(self.fused_moe_chunk_size)})
138

139
140
141
142
143
144
145
        return vllm_config, env_dict

    def is_fp8_block_quantized(self):
        return (self.quant_dtype == torch.float8_e4m3fn
                and self.quant_block_shape is not None)

    def is_batched_prepare_finalize(self):
146
147
148
        info = prepare_finalize_info(self.prepare_finalize_type)
        return (mk.FusedMoEActivationFormat.BatchedExperts ==
                info.activation_format)
149
150

    def is_batched_fused_experts(self):
151
152
153
        info = expert_info(self.fused_experts_type)
        return (mk.FusedMoEActivationFormat.BatchedExperts ==
                info.activation_format)
154
155

    def is_standard_fused_experts(self):
156
157
158
159
160
161
162
163
164
165
166
167
168
169
        info = expert_info(self.fused_experts_type)
        return mk.FusedMoEActivationFormat.Standard == info.activation_format

    def fe_supported_types(self):
        info = expert_info(self.fused_experts_type)
        return info.supported_dtypes

    def pf_supported_types(self):
        info = prepare_finalize_info(self.prepare_finalize_type)
        return info.supported_dtypes

    def is_block_quant_supported(self):
        info = expert_info(self.fused_experts_type)
        return info.blocked_quantization_support
170
171

    def is_fe_supports_chunking(self):
172
173
174
175
176
177
178
179
180
181
        info = expert_info(self.fused_experts_type)
        return info.supports_chunking

    def supports_expert_map(self):
        info = expert_info(self.fused_experts_type)
        return info.supports_expert_map

    def supports_apply_weight_on_input(self):
        info = prepare_finalize_info(self.prepare_finalize_type)
        return info.supports_apply_weight_on_input
182
183

    def needs_deep_gemm(self):
184
185
        info = expert_info(self.fused_experts_type)
        return info.needs_deep_gemm
186
187

    def needs_pplx(self):
188
189
        info = prepare_finalize_info(self.prepare_finalize_type)
        return info.backend == "pplx"
190
191

    def needs_deep_ep(self):
192
193
194
        info = prepare_finalize_info(self.prepare_finalize_type)
        return (info.backend == "deepep_high_throughput"
                or info.backend == "deepep_low_latency")
195
196

    def all2all_backend(self):
197
198
        info = prepare_finalize_info(self.prepare_finalize_type)
        return info.backend
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219

    def is_valid(self):
        # Check prepare-finalize and fused-experts compatibility
        if self.is_batched_prepare_finalize():
            if not self.is_batched_fused_experts():
                return False
        else:
            if not self.is_standard_fused_experts():
                return False

        use_chunking = self.fused_moe_chunk_size is not None
        if use_chunking and not self.is_fe_supports_chunking():
            return False

        # Check quantization sanity
        if (int(self.is_per_act_token_quant) +
                int(self.is_per_tensor_act_quant) +
                int(self.quant_block_shape is not None)) > 1:
            # invalid quant config
            return False

220
221
222
223
224
225
226
227
228
        # check type support
        if self.quant_dtype is None:
            if (self.dtype not in self.pf_supported_types()
                    or self.dtype not in self.fe_supported_types()):
                return False
        else:
            if (self.quant_dtype not in self.pf_supported_types()
                    or self.quant_dtype not in self.fe_supported_types()):
                return False
229

230
        # Check block quanization support
231
        is_block_quatized = self.quant_block_shape is not None
232
        if is_block_quatized and self.quant_dtype is None:
233
            return False
234
        if is_block_quatized and not self.is_block_quant_supported():
235
236
237
238
239
240
            return False

        # deep_gemm only works with block-quantized
        if self.needs_deep_gemm() and not is_block_quatized:
            return False

241
        # Check dependencies (turn into asserts?)
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
        if self.needs_deep_ep() and not has_deep_ep():
            return False
        if self.needs_deep_gemm() and not has_deep_gemm():
            return False
        if self.needs_pplx() and not has_pplx():  # noqa: SIM103
            return False

        return True


@dataclass
class WeightTensors:
    w1: torch.Tensor
    w2: torch.Tensor
    w1_scale: Optional[torch.Tensor]
    w2_scale: Optional[torch.Tensor]
258
259
    w1_gs: Optional[torch.Tensor] = None
    w2_gs: Optional[torch.Tensor] = None
260
261
262
263
264
265
266
267

    def describe(self):
        s = ""
        s += "== Weight Tensors: \n"
        s += f' - {_describe_tensor(self.w1, "w1")} \n'
        s += f' - {_describe_tensor(self.w2, "w2")} \n'
        s += f' - {_describe_tensor(self.w1_scale, "w1_scale")} \n'
        s += f' - {_describe_tensor(self.w2_scale, "w2_scale")} \n'
268
269
        s += f' - {_describe_tensor(self.w1_gs, "w1_gs")} \n'
        s += f' - {_describe_tensor(self.w2_gs, "w2_gs")} \n'
270
271
        return s

272
273
274
275
276
    def is_quantized(self) -> bool:
        # or w1_scale is not None?
        return (self.w1.dtype == torch.float8_e4m3fn
                or self.w1.dtype == torch.uint8 or self.w1.dtype == torch.int8)

277
    def to_current_device(self):
278
279
280
        device = torch.cuda.current_device()
        self.w1 = self.w1.to(device=device)
        self.w2 = self.w2.to(device=device)
281

282
283
284
285
        if self.w1_scale is not None:
            self.w1_scale = self.w1_scale.to(device=device)
        if self.w2_scale is not None:
            self.w2_scale = self.w2_scale.to(device=device)
286

287
        if self.w1_gs is not None:
288
289
290
            self.w1_gs = self.w1_gs.to(device=device)
        if self.w2_gs is not None:
            self.w2_gs = self.w2_gs.to(device=device)
291

292
293
294
295
296
297
    def slice_weights(self, rank: int,
                      num_local_experts: int) -> "WeightTensors":
        s = rank * num_local_experts
        e = s + num_local_experts
        w1 = self.w1[s:e, :, :]
        w2 = self.w2[s:e, :, :]
298
299
300
301
302
303
        w1_scale = self.w1_scale[
            s:e, :, :] if self.w1_scale is not None else None
        w2_scale = self.w2_scale[
            s:e, :, :] if self.w2_scale is not None else None
        w1_gs = self.w1_gs[s:e] if self.w1_gs is not None else None
        w2_gs = self.w2_gs[s:e] if self.w2_gs is not None else None
304

305
        return WeightTensors(w1, w2, w1_scale, w2_scale, w1_gs, w2_gs)
306

307
308
309
    @staticmethod
    def make(config: Config) -> "WeightTensors":
        (_, w1, w1_scale, w1_gs), (_, w2, w2_scale, w2_gs) = make_test_weights(
310
311
312
            e=config.E,
            n=config.N,
            k=config.K,
313
314
315
            in_dtype=config.dtype,
            quant_dtype=config.quant_dtype,
            block_shape=config.quant_block_shape,
316
317
            per_out_ch_quant=config.
            is_per_act_token_quant,  # or config.is_per_out_ch_quant
318
319
320
321
        )
        return WeightTensors(w1=w1,
                             w2=w2,
                             w1_scale=w1_scale,
322
323
324
                             w2_scale=w2_scale,
                             w1_gs=w1_gs,
                             w2_gs=w2_gs)
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361


@dataclass
class RankTensors:
    hidden_states: torch.Tensor
    hidden_states_scale: Optional[torch.Tensor]

    topk_weights: torch.Tensor
    topk_ids: torch.Tensor
    expert_map: Optional[torch.Tensor]

    def describe(self):
        s = ""
        s += "== Rank Tensors: \n"
        s += f' - {_describe_tensor(self.hidden_states, "HS")} \n'
        s += f' - {_describe_tensor(self.hidden_states_scale, "HS_scale")} \n'
        s += f' - {_describe_tensor(self.topk_weights, "topk_weights")} \n'
        s += f' - {_describe_tensor(self.topk_ids, "topk_ids")} \n'
        s += f' - {_describe_tensor(self.expert_map, "expert_map")} \n'
        return s

    @staticmethod
    def make_hidden_states(
            config: Config) -> tuple[torch.Tensor, Optional[torch.Tensor]]:
        """
        Return hidden_states
        """
        m, k, dtype = (config.M, config.K, config.dtype)
        a = (torch.randn(
            (m, k), device=torch.cuda.current_device(), dtype=dtype) / 15.0)

        if config.quant_dtype is None:
            return a, None

        # We dequant and use that as hidden_states so the tests are stable.
        # quantizing and dequantizing yield slightly different results
        # depending on the hardware. Here we, quantize and dequantize
362
        # first - so further quantize and dequantize will yield the same
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
        # values.
        if config.is_per_tensor_act_quant:
            a_q, a_scales = ops.scaled_fp8_quant(
                a, use_per_token_if_dynamic=False)
            return a_q.float().mul(a_scales).to(dtype), a_scales

        if config.is_per_act_token_quant:
            a_q, a_scales = ops.scaled_fp8_quant(a,
                                                 use_per_token_if_dynamic=True)
            return a_q.float().mul(a_scales).to(dtype), None

        assert config.quant_block_shape is not None
        block_k = config.quant_block_shape[1]
        a_q, a_scales = per_token_cast_to_fp8(a, block_size=block_k)
        return a_q.float().view(
            (-1, block_k)).mul(a_scales.view(-1, 1)).view(m, k).to(dtype), None

    @staticmethod
    def make(config: Config, pgi: ProcessGroupInfo):

        dtype = config.dtype
        topk, m, _ = (config.topk, config.M, config.K)
        hidden_states, hidden_states_scale = RankTensors.make_hidden_states(
            config)

        num_local_experts, global_num_experts = (config.num_local_experts,
                                                 config.E)
        score = torch.randn((m, global_num_experts),
                            device="cuda",
                            dtype=dtype)
        topk_weights, topk_ids, _ = fused_topk(hidden_states, score, topk,
                                               False)

        # distribute topk_ids evenly
        for mi in range(m):
            topk_ids[mi] = torch.randperm(config.E)[:topk]
        topk_ids = topk_ids.to(device=torch.cuda.current_device())

        expert_map = None
402
        if config.world_size > 1 and config.supports_expert_map():
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
            expert_map = torch.full((global_num_experts, ),
                                    fill_value=-1,
                                    dtype=torch.int32)
            s = pgi.rank * num_local_experts
            e = s + num_local_experts
            expert_map[s:e] = torch.tensor(list(range(num_local_experts)))
            expert_map = expert_map.to(device=torch.cuda.current_device(),
                                       dtype=torch.int32)

        return RankTensors(
            hidden_states=hidden_states,
            hidden_states_scale=hidden_states_scale,
            topk_weights=topk_weights,
            topk_ids=topk_ids,
            expert_map=expert_map,
        )


def reference_moe_impl(config: Config, weights: WeightTensors,
                       rank_tensors: RankTensors) -> torch.Tensor:

424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
    if config.quant_dtype == "nvfp4":
        quant_blocksize = 16
        dtype = config.dtype

        w1_q = weights.w1
        w1_blockscale = weights.w1_scale
        w1_gs = weights.w1_gs

        w2_q = weights.w2
        w2_blockscale = weights.w2_scale
        w2_gs = weights.w2_gs

        a_global_scale = ((FLOAT8_E4M3_MAX * FLOAT4_E2M1_MAX) / torch.amax(
            rank_tensors.hidden_states.flatten(), dim=-1)).to(torch.float32)

        assert w1_gs is not None
        assert w2_gs is not None
        assert w1_blockscale is not None
        assert w2_blockscale is not None

        assert w1_blockscale.shape[1] % 128 == 0
        assert w1_blockscale.shape[2] % 4 == 0
        assert w2_blockscale.shape[1] % 128 == 0
        assert w2_blockscale.shape[2] % 4 == 0

        a_fp4, a_scale_interleaved = ops.scaled_fp4_quant(
            rank_tensors.hidden_states, a_global_scale)

        a = dequantize_nvfp4_to_dtype(a_fp4,
                                      a_scale_interleaved,
                                      a_global_scale,
                                      dtype=dtype,
                                      device=a_fp4.device,
                                      block_size=quant_blocksize)

        e = w1_q.shape[0]
        n = w1_q.shape[1] // 2
        k = w2_q.shape[1]

        w1 = torch.zeros((e, 2 * n, k), device="cuda", dtype=dtype)
        w2 = torch.zeros((e, k, n), device="cuda", dtype=dtype)

        for idx in range(0, e):
            w1[idx] = dequantize_nvfp4_to_dtype(w1_q[idx],
                                                w1_blockscale[idx],
                                                w1_gs[idx],
                                                dtype=dtype,
                                                device=w1_q.device,
                                                block_size=quant_blocksize)
            w2[idx] = dequantize_nvfp4_to_dtype(w2_q[idx],
                                                w2_blockscale[idx],
                                                w2_gs[idx],
                                                dtype=dtype,
                                                device=w2_q.device,
                                                block_size=quant_blocksize)
        a_scale = None
        w1_scale = None
        w2_scale = None
        quant_dtype = None
        per_act_token_quant = False
        block_shape = None
    else:
        a = rank_tensors.hidden_states
        a_scale = rank_tensors.hidden_states_scale
        w1 = weights.w1
        w1_scale = weights.w1_scale
        w2 = weights.w2
        w2_scale = weights.w2_scale
        quant_dtype = config.quant_dtype
        per_act_token_quant = config.is_per_act_token_quant
        block_shape = config.quant_block_shape

    return torch_experts(a=a,
                         w1=w1,
                         w2=w2,
499
500
501
502
                         topk_weight=rank_tensors.topk_weights,
                         topk_ids=rank_tensors.topk_ids,
                         global_num_experts=config.E,
                         expert_map=None,
503
504
505
506
507
508
509
510
                         w1_scale=w1_scale,
                         w2_scale=w2_scale,
                         a1_scale=a_scale,
                         quant_dtype=quant_dtype,
                         per_act_token_quant=per_act_token_quant,
                         block_shape=block_shape,
                         apply_router_weights_on_input=config.topk == 1
                         and config.supports_apply_weight_on_input())
511
512


513
514
515
516
517
518
def _make_gscale(num_experts: int) -> torch.Tensor:
    return torch.ones((num_experts, ),
                      device=torch.cuda.current_device(),
                      dtype=torch.float32)


519
520
521
def make_modular_kernel(
    config: Config,
    vllm_config: VllmConfig,
522
    quant_config: FusedMoEQuantConfig,
523
) -> mk.FusedMoEModularKernel:
524
525
526
527
528
529
530
531
532
533
534
535
536

    def next_power_of_2(x):
        import math
        if x == 0:
            return 1
        return 2**math.ceil(math.log2(x))

    # make moe config
    moe_parallel_config: FusedMoEParallelConfig = FusedMoEParallelConfig.make(
        tp_size_=get_tensor_model_parallel_world_size(),
        dp_size_=get_dp_group().world_size,
        vllm_parallel_config=vllm_config.parallel_config,
    )
537

538
539
540
541
542
543
544
545
546
547
548
    moe = FusedMoEConfig(
        num_experts=config.E,
        experts_per_token=config.topk,
        hidden_dim=config.K,
        num_local_experts=config.num_local_experts,
        moe_parallel_config=moe_parallel_config,
        in_dtype=config.dtype,
        max_num_tokens=next_power_of_2(config.M),
    )

    # make modular kernel
549
    prepare_finalize = make_prepare_finalize(config.prepare_finalize_type,
550
551
                                             config.all2all_backend(), moe,
                                             quant_config)
552
553
554
555

    fused_experts = make_fused_experts(
        config.fused_experts_type,
        moe,
556
        quant_config,
557
        prepare_finalize.num_dispatchers(),
558
        config.N,
559
    )
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579

    modular_kernel = mk.FusedMoEModularKernel(
        prepare_finalize=prepare_finalize, fused_experts=fused_experts)

    return modular_kernel


def run_modular_kernel(
    pgi: ProcessGroupInfo,
    vllm_config: VllmConfig,
    config: Config,
    weights: WeightTensors,
    rank_tensors: RankTensors,
) -> torch.Tensor:
    assert isinstance(config.Ms, int)
    assert isinstance(config.topks, int)

    # weights for rank
    rank_weights = weights.slice_weights(pgi.rank, config.num_local_experts)

580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
    if config.quant_dtype == "nvfp4":
        gscale = _make_gscale(config.num_local_experts)
    else:
        gscale = None

    quant_config = FusedMoEQuantConfig.make(
        config.quant_dtype,
        w1_scale=rank_weights.w1_scale,
        w2_scale=rank_weights.w2_scale,
        a1_scale=rank_tensors.hidden_states_scale,
        g1_alphas=(1 / rank_weights.w1_gs)
        if rank_weights.w1_gs is not None else None,
        g2_alphas=(1 / rank_weights.w2_gs)
        if rank_weights.w2_gs is not None else None,
        a1_gscale=gscale,
        a2_gscale=gscale,
        block_shape=config.quant_block_shape,
        per_act_token_quant=config.is_per_act_token_quant,
        per_out_ch_quant=config.is_per_out_ch_quant,
    )

    mk = make_modular_kernel(config, vllm_config, quant_config)

    # impls might update the tensor in place
    hidden_states = rank_tensors.hidden_states.clone()

    topk_ids = rank_tensors.topk_ids.to(
        mk.prepare_finalize.topk_indices_dtype())
608
609

    mk_kwargs = {
610
        "hidden_states":
611
        hidden_states,
612
613
614
615
616
617
618
        "w1":
        rank_weights.w1,
        "w2":
        rank_weights.w2,
        "topk_weights":
        rank_tensors.topk_weights,
        "topk_ids":
619
        topk_ids,
620
621
622
623
624
625
        "expert_map":
        rank_tensors.expert_map,
        "global_num_experts":
        config.E,
        "apply_router_weight_on_input":
        config.topk == 1 and config.supports_apply_weight_on_input(),
626
    }
627
628
629
630
631
632
633
634
635
636
637
638
639

    num_tokens = rank_tensors.hidden_states.shape[0]
    num_tokens_across_dp = torch.tensor([num_tokens] * config.world_size,
                                        device="cuda",
                                        dtype=torch.int)

    with set_forward_context(
            None,
            vllm_config,
            num_tokens=num_tokens,
            num_tokens_across_dp=num_tokens_across_dp,
    ):
        out = mk.forward(**mk_kwargs)
640
641

    return out