test_spec_decode.py 11.1 KB
Newer Older
1
# SPDX-License-Identifier: Apache-2.0
2
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
3
4
from __future__ import annotations

5
import random
6
from typing import Any, Union
7

8
import os
9
import pytest
zhiweiz's avatar
zhiweiz committed
10
import torch
11

12
from tests.utils import get_attn_backend_list_based_on_platform
13
from vllm import LLM, SamplingParams
14

15
16
from vllm.assets.base import VLLM_S3_BUCKET_URL
from vllm.assets.image import VLM_IMAGES_DIR
17

zhiweiz's avatar
zhiweiz committed
18
from vllm.distributed import cleanup_dist_env_and_memory
19
from vllm.platforms import current_platform
20
from ...utils import models_path_prefix
21

22
23
MTP_SIMILARITY_RATE = 0.8

24

25
def get_test_prompts(mm_enabled: bool):
26
    prompt_types = ["repeat", "sentence"]
27
28
    if mm_enabled:
        prompt_types.append("mm")
29
30
31
32
33
    num_prompts = 100
    prompts = []

    random.seed(0)
    random_prompt_type_choices = random.choices(prompt_types, k=num_prompts)
34
    print(f"Prompt types: {random_prompt_type_choices}")
35
36
37
38
39
40

    # Generate a mixed batch of prompts, some of which can be easily
    # predicted by n-gram matching and some which likely cannot.
    for kind in random_prompt_type_choices:
        word_choices = ["test", "temp", "hello", "where"]
        word = random.choice(word_choices)
41
        prompt: Union[str, list[dict[str, Any]]] = ""
42
43
44
45
46
47
48
49
50
51
52
53
        if kind == "repeat":
            prompt = f"""
            please repeat the word '{word}' 10 times.
            give no other output than the word at least ten times in a row,
            in lowercase with spaces between each word and without quotes.
            """
        elif kind == "sentence":
            prompt = f"""
            please give a ten-word sentence that
            uses the word {word} at least once.
            give no other output than that simple sentence without quotes.
            """
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
        elif kind == "mm":
            placeholders = [{
                "type": "image_url",
                "image_url": {
                    "url":
                    f"{VLLM_S3_BUCKET_URL}/{VLM_IMAGES_DIR}/stop_sign.jpg"
                },
            }]
            prompt = [
                *placeholders,
                {
                    "type": "text",
                    "text": "The meaning of the image is"
                },
            ]
69
70
71
72
73
        else:
            raise ValueError(f"Unknown prompt type: {kind}")
        prompts.append([{"role": "user", "content": prompt}])

    return prompts
74
75
76
77


@pytest.fixture
def sampling_config():
78
    return SamplingParams(temperature=0, max_tokens=10, ignore_eos=False)
79
80
81
82


@pytest.fixture
def model_name():
83
    # return os.path.join(models_path_prefix, "meta-llama/Llama-3.1-8B-Instruct")
zhuwenwen's avatar
zhuwenwen committed
84
    return os.path.join(models_path_prefix, "meta-llama/Llama-3.1-8B-Instruct")
85
86


87
88
89
90
91
def test_ngram_correctness(
    monkeypatch: pytest.MonkeyPatch,
    sampling_config: SamplingParams,
    model_name: str,
):
92
    '''
93
    Compare the outputs of an original LLM and a speculative LLM
94
95
96
97
    should be the same when using ngram speculative decoding.
    '''
    with monkeypatch.context() as m:
        m.setenv("VLLM_USE_V1", "1")
98
        test_prompts = get_test_prompts(mm_enabled=False)
99

100
101
        ref_llm = LLM(model=model_name, max_model_len=1024)
        ref_outputs = ref_llm.chat(test_prompts, sampling_config)
102
        del ref_llm
zhiweiz's avatar
zhiweiz committed
103
104
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()
105

106
107
108
109
110
111
112
113
114
115
        spec_llm = LLM(
            model=model_name,
            speculative_config={
                "method": "ngram",
                "prompt_lookup_max": 5,
                "prompt_lookup_min": 3,
                "num_speculative_tokens": 3,
            },
            max_model_len=1024,
        )
116
117
118
        spec_outputs = spec_llm.chat(test_prompts, sampling_config)
        matches = 0
        misses = 0
119
        for ref_output, spec_output in zip(ref_outputs, spec_outputs):
120
121
122
123
124
125
126
            if ref_output.outputs[0].text == spec_output.outputs[0].text:
                matches += 1
            else:
                misses += 1
                print(f"ref_output: {ref_output.outputs[0].text}")
                print(f"spec_output: {spec_output.outputs[0].text}")

127
        # Heuristic: expect at least 66% of the prompts to match exactly
128
        # Upon failure, inspect the outputs to check for inaccuracy.
129
        assert matches >= int(0.66 * len(ref_outputs))
130
        del spec_llm
zhiweiz's avatar
zhiweiz committed
131
132
133
134
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()


135
@pytest.mark.parametrize(["model_setup", "mm_enabled"], [
136
137
138
139
140
    (("eagle3", os.path.join(models_path_prefix, "Qwen/Qwen3-8B"), os.path.join(models_path_prefix, "AngelSlim/Qwen3-8B_eagle3"), 1), False),
    (("eagle", os.path.join(models_path_prefix, "meta-llama/Llama-3.1-8B-Instruct"),
      os.path.join(models_path_prefix, "yuhuili/EAGLE-LLaMA3.1-Instruct-8B"), 1), False),
    (("eagle3", os.path.join(models_path_prefix, "meta-llama/Llama-3.1-8B-Instruct"),
      os.path.join(models_path_prefix, "yuhuili/EAGLE3-LLaMA3.1-Instruct-8B"), 1), False),
141
    pytest.param(
142
143
        ("eagle", os.path.join(models_path_prefix, "meta-llama/Llama-4-Scout-17B-16E-Instruct"),
         os.path.join(models_path_prefix, "morgendave/EAGLE-Llama-4-Scout-17B-16E-Instruct"), 4),
144
145
146
        False,
        marks=pytest.mark.skip(reason="Skipping due to CI OOM issues")),
    pytest.param(
147
148
        ("eagle", os.path.join(models_path_prefix, "meta-llama/Llama-4-Scout-17B-16E-Instruct"),
         os.path.join(models_path_prefix, "morgendave/EAGLE-Llama-4-Scout-17B-16E-Instruct"), 4),
149
150
        True,
        marks=pytest.mark.skip(reason="Skipping due to CI OOM issues")),
151
152
    (("eagle", os.path.join(models_path_prefix, "eagle618/deepseek-v3-random"),
      os.path.join(models_path_prefix, "eagle618/eagle-deepseek-v3-random"), 1), False),
153
154
],
                         ids=[
155
156
157
                             os.path.join(models_path_prefix, "qwen3_eagle3"), os.path.join(models_path_prefix, "llama3_eagle"), os.path.join(models_path_prefix, "llama3_eagle3"),
                             os.path.join(models_path_prefix, "llama4_eagle"), os.path.join(models_path_prefix, "llama4_eagle_mm"),
                             os.path.join(models_path_prefix, os.path.join(models_path_prefix, "deepseek_eagle"))
158
                         ])
159
160
@pytest.mark.parametrize("attn_backend",
                         get_attn_backend_list_based_on_platform())
161
162
163
def test_eagle_correctness(
    monkeypatch: pytest.MonkeyPatch,
    sampling_config: SamplingParams,
zhiweiz's avatar
zhiweiz committed
164
    model_setup: tuple[str, str, str, int],
165
    mm_enabled: bool,
166
    attn_backend: str,
167
):
168
169
170
171
    if attn_backend == "TREE_ATTN":
        # TODO: Fix this flaky test
        pytest.skip(
            "TREE_ATTN is flaky in the test disable for now until it can be "
co63oc's avatar
co63oc committed
172
            "resolved (see https://github.com/vllm-project/vllm/issues/22922)")
173

174
175
    # Generate test prompts inside the function instead of using fixture
    test_prompts = get_test_prompts(mm_enabled)
176
177
178
    '''
    Compare the outputs of a original LLM and a speculative LLM
    should be the same when using eagle speculative decoding.
zhiweiz's avatar
zhiweiz committed
179
    model_setup: (method, model_name, eagle_model_name, tp_size)
180
181
182
    '''
    with monkeypatch.context() as m:
        m.setenv("VLLM_USE_V1", "1")
183
        m.setenv("VLLM_MLA_DISABLE", "1")
184
185
        m.setenv("VLLM_ATTENTION_BACKEND", attn_backend)

186
187
        if (attn_backend == "TRITON_ATTN" and not current_platform.is_rocm()):
            pytest.skip("TRITON_ATTN does not support "
188
189
                        "multi-token eagle spec decode on current platform")

190
        if attn_backend == "FLASH_ATTN" and current_platform.is_rocm():
191
192
            m.setenv("VLLM_ROCM_USE_AITER", "1")

zhiweiz's avatar
zhiweiz committed
193
        method, model_name, spec_model_name, tp_size = model_setup
194

zhiweiz's avatar
zhiweiz committed
195
196
197
        ref_llm = LLM(model=model_name,
                      max_model_len=2048,
                      tensor_parallel_size=tp_size)
198
199
        ref_outputs = ref_llm.chat(test_prompts, sampling_config)
        del ref_llm
zhiweiz's avatar
zhiweiz committed
200
201
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()
202
203
204

        spec_llm = LLM(
            model=model_name,
205
            trust_remote_code=True,
zhiweiz's avatar
zhiweiz committed
206
            tensor_parallel_size=tp_size,
207
            speculative_config={
zhiweiz's avatar
zhiweiz committed
208
                "method": method,
209
                "model": spec_model_name,
210
                "num_speculative_tokens": 3,
211
                "max_model_len": 2048,
212
            },
213
            max_model_len=2048,
214
215
216
217
218
219
220
221
222
223
224
225
        )
        spec_outputs = spec_llm.chat(test_prompts, sampling_config)
        matches = 0
        misses = 0
        for ref_output, spec_output in zip(ref_outputs, spec_outputs):
            if ref_output.outputs[0].text == spec_output.outputs[0].text:
                matches += 1
            else:
                misses += 1
                print(f"ref_output: {ref_output.outputs[0].text}")
                print(f"spec_output: {spec_output.outputs[0].text}")

226
        # Heuristic: expect at least 66% of the prompts to match exactly
227
        # Upon failure, inspect the outputs to check for inaccuracy.
228
        assert matches > int(0.66 * len(ref_outputs))
229
        del spec_llm
zhiweiz's avatar
zhiweiz committed
230
231
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294


@pytest.mark.parametrize(["model_setup", "mm_enabled"], [
    (("mtp", "XiaomiMiMo/MiMo-7B-Base", 1), False),
    (("mtp", "ZixiQi/DeepSeek-V3-4layers-MTP-FP8", 1), False),
],
                         ids=["mimo", "deepseek"])
def test_mtp_correctness(
    monkeypatch: pytest.MonkeyPatch,
    sampling_config: SamplingParams,
    model_setup: tuple[str, str, int],
    mm_enabled: bool,
):
    # Generate test prompts inside the function instead of using fixture
    test_prompts = get_test_prompts(mm_enabled)
    '''
    Compare the outputs of a original LLM and a speculative LLM
    should be the same when using MTP speculative decoding.
    model_setup: (method, model_name, tp_size)
    '''
    with monkeypatch.context() as m:
        m.setenv("VLLM_USE_V1", "1")
        m.setenv("VLLM_MLA_DISABLE", "1")

        method, model_name, tp_size = model_setup

        ref_llm = LLM(model=model_name,
                      max_model_len=2048,
                      tensor_parallel_size=tp_size,
                      trust_remote_code=True)
        ref_outputs = ref_llm.chat(test_prompts, sampling_config)
        del ref_llm
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()

        spec_llm = LLM(
            model=model_name,
            trust_remote_code=True,
            tensor_parallel_size=tp_size,
            speculative_config={
                "method": method,
                "num_speculative_tokens": 1,
                "max_model_len": 2048,
            },
            max_model_len=2048,
        )
        spec_outputs = spec_llm.chat(test_prompts, sampling_config)
        matches = 0
        misses = 0
        for ref_output, spec_output in zip(ref_outputs, spec_outputs):
            if ref_output.outputs[0].text == spec_output.outputs[0].text:
                matches += 1
            else:
                misses += 1
                print(f"ref_output: {ref_output.outputs[0].text}")
                print(f"spec_output: {spec_output.outputs[0].text}")

        # Heuristic: expect at least 80% of the prompts to match exactly
        # Upon failure, inspect the outputs to check for inaccuracy.
        assert matches > int(MTP_SIMILARITY_RATE * len(ref_outputs))
        del spec_llm
        torch.cuda.empty_cache()
        cleanup_dist_env_and_memory()