GitLab

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* WIP

* cleaner code

* Add tests

* Add docs

* Assert dtype

* put back check

* Address comments
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* initial commit

* initial commit

* flake8

* last nits
Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

* add ufmt as code formatter

* cleanup

* quote ufmt requirement

* split imports into more groups

* regenerate circleci config

* fix CI

* clarify local testing utils section

* use ufmt pre-commit hook

* split relative imports into local category

* Revert "split relative imports into local category"

This reverts commit f2e224cde2008c56c9347c1f69746d39065cdd51.

* pin black and usort dependencies

* fix local test utils detection

* fix ufmt rev

* add reference utils to local category

* fix usort config

* remove custom categories sorting

* Run pre-commit without fixing flake8

* got a double import in merge
Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* style: Added typing annotations

* Specified types for iter and seek.
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Vasilis Vryniotis <vvryniotis@fb.com>

* Fixed missing audio with video_reader backend

* Added unit test

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Fixed audio-video synchronisation problem in read_video() when using  as unit

* Addressed review comments

* Added unit test

* Fix io imports and expose methods

* fix fmt
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: James Thewlis <james@unitary.ai>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

This reverts commit 3bfdb427.

* multithreading allowed in stream codec context

* numThreads is passed as a decoder parameter. At this stage code should be unchanged

* enabling multithreading in videoReader API

* moving defaults to header files

* replace long with int64_t because torchscript

* docstring for Num threads

* Enable codec-related heuristics as defaults

* Update torchvision/csrc/io/decoder/stream.cpp
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Fixing build errors

* minor docs

* Linting

* updating defaults for the C++ function calls to be single threaded

* adding special case for single threaded stuff
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Summary:
We accept python bytes for video in existing API, such as `_read_video_timestamps_from_memory`.
We should do so to `_read_video_timestamps_from_memory` as well.

Reviewed By: fmassa

Differential Revision: D26216777

fbshipit-source-id: 5d7ecf15c5a65dc5c57f17b343e7c63b4933189e
Co-authored-by: Zhicheng Yan <zyan3@fb.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Simplify code and remove used vars.

* Simplify expressions and remove used parenthesis.

* Jit fixes.

* Making check more readable.

* fixing styles

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update ImageReadMode error messages, add newline at the end of image_read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum

* Update readpng_cpu and readjpeg_cpu error messages

* Update image.py documentation

* Add option to write audio to video file

Summary:
I was trying to use torchvision's `write_video` function and realized there was no option to add in the audio.

Thus, this diff contains the changes necessary such that this is possible. This is my first time trying to contribute to this project, so be as harsh as you need!

Reviewed By: fmassa

Differential Revision: D21480083

fbshipit-source-id: 2e11f2c8728d42f86c94068f75b843793d5a94aa

* Fix typo

* Try fix Windows

* Disable test on Windows
Co-authored-by: Joanna Bitton <jbitton@fb.com>

* Fix spelling mistake: orignal -> original

* Spelling fix: orignal -> original
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Add support of mode and remove channels.

* Replacing integer mode with define constants.

* Adding output channels implementation for pngs.

* Adding tests for png.

* Adding channels in the API and documentation.

* Fixing formatting.

* Refactoring test_image.py to remove huge grace_hopper_517x606.pth file from assets and reduce duplicate code. Moving jpeg assets used by encode and write unit-tests on their separate folders.

* Adding output channels implementation for jpegs. Fix asset locations.

* Add tests for JPEG, adding the channels in the API and documentation and adding checks for inputs.

* Changing folder for unit-test.

* Fixing windows flakiness, removing duplicate test.

* Replacing components to channels.

* Adding reference for supporting CMYK.

* Minor changes: num_components to output_components, adding comments, fixing variable name etc.

* Reverting output_components to num_components.

* Replacing decoding with generic method on tests.

* Palette converted to Gray.

* Modified the example to conform with the new DICT return.

* adding better stream documentation to examples

* Clearing up some documentation as a result of a feedback

* Formatting mostly

* Addressing Victor's comments.

* addressing fmassas comments

* remove unnecessary tab
Co-authored-by: Bruno Korbar <korbar@vggdev9.vggdev.cluster>
Co-authored-by: vfdev <vfdev.5@gmail.com>

* Fix external DLL loading on wheels

* Use SetDefaultDllDirectoriess and AddDllDirectory

* Add previous paths

* Trigger debug

* Do not call SetDefaultDllDirectories.

* Do not call loadlibrary if the extensions were not compiled

* Fix lint issues

* Video reader now returns dicts

* docs update

* Minor improvements
Co-authored-by: Bruno Korbar <bjuncek@Frazz.local>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Minor improvements to VideoReader

* update jupyter notebook with new naming
Co-authored-by: Bruno Korbar <bjuncek@gmail.com>

* initial API documentation attempt

* test the docs

* initial commit

* updating test to match the registration

* adding the warning on unsucessful import

* Try to do conditional import

* Simple fix?

* clearing up docs

* docstring commit

* Adding types in arguments
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* reverting warning commit

* addressing Francisco's comments

* Apply suggestions from code review
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Revert "reverting warning commit"

This reverts commit bd1a3dd4f3b97709ab59c744962e11174757f8ce.

* Revert "adding the warning on unsucessful import"

This reverts commit afef7df9eaa73bf80246e6d9114cb4c30b16f0ce.

* remove warnings import
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Add write_file

* Fix lint