1. 16 Oct, 2020 1 commit
    • bmanga's avatar
      Ensure torchvision operators are added in C++ (#2798) · adfc15c4
      bmanga authored
      * Ensure torchvision operators are registered in C++ via weak symbols
      
      * Add note to README on how to ensure that torchvision operators are available in C++
      
      * Fix dllimport/dllexport on windows, format files
      
      * Factor out common macros in single file
      
      * Expose cuda_version in the API, use it to avoid pruning of ops initializer
      adfc15c4
  2. 14 Oct, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      Fix wheel relocation issues (#2777) · 4db3dc6d
      Edgar Andrés Margffoy Tuay authored
      
      
      * [DEBUG] Check wheel relocation issues
      
      * Call delocate on Mac
      
      * Use yum instead of conda
      
      * Do not copy ffmpeg dylibs
      
      * Linux dry run
      
      * Do not download FFmpeg on Mac
      
      * Install bzip2
      
      * Restore FFmpeg on Windows
      
      * Remove ffmpeg temporarily
      
      * Do not remove dependencies
      
      * Disable FFmpeg temporarily on Linux wheels
      
      * Test relocation in Linux
      
      * Add docstring
      
      * Call relocation script
      
      * Minor error correction
      
      * Import auditwheel only on Linux
      
      * Restore ffmpeg again on Windows
      
      * Return *device
      
      * Try fix Windows
      
      * Fix clang-format
      
      * Start windows patchwork
      
      * Copy all DLLs
      
      * Disable FFmpeg on Windows for now
      
      * Bugfix
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      4db3dc6d
  3. 13 Oct, 2020 1 commit
    • vfdev's avatar
      Added rois shape check in C++ (#2794) · b8e93084
      vfdev authored
      * Added rois shape check in C++
      
      * Fixes code formatting
      
      * Remove accidental include
      
      * - Updated code according to the review
      - Replaced old AT_ASSERT/ERROR by new TORCH_CHECK
      b8e93084
  4. 11 Oct, 2020 1 commit
  5. 07 Oct, 2020 3 commits
    • Francisco Massa's avatar
    • peterjc123's avatar
      Improve read_file for Windows (#2768) · 5be4f414
      peterjc123 authored
      * Improve read_file for Windows
      
      * Fix lint
      
      * Use _stat64 instead
      
      * Apply suggesion
      
      * Fix lint
      5be4f414
    • Bruno Korbar's avatar
      (WIP) Initial implementation of the new videoReader API (#2683) · 87c78641
      Bruno Korbar authored
      
      
      * adding base files
      
      * setup modification to actually build the thing
      
      * video api constructor registration
      
      * FAIL metadata
      
      * FAIL update for QS
      
      * revert
      
      * debugging with Victor
      
      * adding base files
      
      * setup modification to actually build the thing
      
      * video api constructor registration
      
      * FAIL metadata
      
      * FAIL update for QS
      
      * revert
      
      * debugging with Victor
      
      * metadata registration works
      
      * API build next
      
      * test
      
      * Merge change
      
      * formatting parameters to avoid the segfault
      
      * next now works on a video
      
      * make size of the output tensor format dependent
      
      * Make next work on audio stream only as well
      
      * refactoring the _setCurrentStream param
      
      * Fixing the last frame return and sensor
      
      * todo docs
      
      * Formatting
      
      * cleanup and comments
      
      * introducing new tests for the API
      
      * cleanup
      
      * Comment out unnecesary format (will add following FFMPEG fix)
      
      * Reformat parsing function
      
      * removing the seek bug `get_decoder_params`
      
      * Removing unnecessary code/variables
      
      * enforce RGB24 as a reading format (will crash before ffmpeg fix)
      
      * permute the dimensions to return (RGB x H x W)
      
      * Changing the return type to std::tuple<torch::Tensor, double> as opposed to tensor list
      
      * Adjusting tests for the new return type
      
      * remove unnecessary jitter
      
      * clangangangang
      
      * Metadata return changes (#1)
      
      * remove implicit calls to set a current stream (#2)
      
      * Adding new tests to check the accuracy of the seek
      
      * cleanup debugging statements
      
      * adding base files
      
      * setup modification to actually build the thing
      
      * video api constructor registration
      
      * FAIL metadata
      
      * FAIL update for QS
      
      * revert
      
      * debugging with Victor
      
      * adding base files
      
      * video api constructor registration
      
      * FAIL metadata
      
      * FAIL update for QS
      
      * revert
      
      * debugging with Victor
      
      * metadata registration works
      
      * API build next
      
      * test
      
      * Merge change
      
      * formatting parameters to avoid the segfault
      
      * next now works on a video
      
      * make size of the output tensor format dependent
      
      * Make next work on audio stream only as well
      
      * refactoring the _setCurrentStream param
      
      * Fixing the last frame return and sensor
      
      * todo docs
      
      * Formatting
      
      * cleanup and comments
      
      * introducing new tests for the API
      
      * cleanup
      
      * Comment out unnecesary format (will add following FFMPEG fix)
      
      * Reformat parsing function
      
      * removing the seek bug `get_decoder_params`
      
      * Removing unnecessary code/variables
      
      * enforce RGB24 as a reading format (will crash before ffmpeg fix)
      
      * permute the dimensions to return (RGB x H x W)
      
      * Changing the return type to std::tuple<torch::Tensor, double> as opposed to tensor list
      
      * Adjusting tests for the new return type
      
      * remove unnecessary jitter
      
      * clangangangang
      
      * Metadata return changes (#1)
      
      * remove implicit calls to set a current stream (#2)
      
      * Adding new tests to check the accuracy of the seek
      
      * cleanup debugging statements
      
      * Addressing PR comments
      
      * addressing Francisco's comments
      
      * CLANG build formatting
      
      * Updated testing to test against pyav for the video tensor reads
      
      * Formatting
      
      * remove pyav from pip deps and add it to conda build
      
      * add pyav and ffmeped to conda builds
      
      * Formatting?
      
      * Setting up linter once and for all hopefully
      
      * Testing pyav
      
      * Fix to 8.0.0
      
      * Try 6.2.0
      
      * See what happens with av from pip
      
      * Remove FFMPEG blocker
      
      * What is going on?
      
      * More tests
      
      * Forgot something
      
      * unblocker
      
      * Check if cache is messing up with things
      
      * Now try with different ffmpeg
      
      * Now try with different ffmpeg
      
      * Testing pyav
      
      * Fix to 8.0.0
      
      * Try 6.2.0
      
      * See what happens with av from pip
      
      * What is going on?
      
      * More tests
      
      * Forgot something
      
      * Check if cache is messing up with things
      
      * Now try with different ffmpeg
      
      * Now try with different ffmpeg
      
      * Do not install av
      
      * Test with ffmpeg 4.2
      
      * clean up video tests
      
      * cleaning up the tests a bit to better test partial reading
      
      * arrgh linter
      
      * Forgot the av test
      
      * forgot av test
      
      * checkout build files from master
      
      * revert circleci
      
      * addressing Franciscos comments
      
      * addressing Franciscos comments
      
      * Ignore ffmpeg in travis
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      Co-authored-by: default avatarEdgar Andrés Margffoy Tuay <andfoy@gmail.com>
      87c78641
  6. 06 Oct, 2020 3 commits
    • Francisco Massa's avatar
      Add write_file (#2765) · 6e639d3e
      Francisco Massa authored
      * Add write_file
      
      * Fix lint
      6e639d3e
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add PyTorch FFmpeg to wheel and conda distributions (#2596) · 635406c3
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add PyTorch FFmpeg to wheel and conda distributions
      
      * Try to install wget from conda
      
      * Add yq flag on Mac
      
      * Correct copy instructions
      
      * Use cURL on Windows
      
      * Call bzip2 directly due to msys2/MSYS2-packages#1548
      
      * Copy ffmpeg binaries to system-wide directories
      
      * Try to use std:c++17 on Windows
      
      * Try to define ssize_t on Windows
      
      * Use C++14
      
      * Declare AVRational structs explicitly
      
      * Initialize AVRational explicitly
      
      * Replace macro to prevent errors on Windows
      
      * Replace AV_TIME_BASE_Q
      
      * Add library paths for video extension
      
      * Force ffmpeg from pytorch channels?
      
      * Fix clang style warnings
      
      * Update CONDA_CHANNEL_FLAGS
      
      * Fix clang style issues
      
      * Update unittest
      
      * Use FFmpeg 4.2
      
      * Install correct version on Mac
      
      * Pin av version to 8.0.0
      
      * Fix string formatting issue
      
      * Fix pip pinning
      
      * Try with 8.0.1
      
      * Use av 8.0.2
      
      * Remove trailling whitespaces
      
      * Disable test_io_opt.py
      
      * Disable test_datasets_video_utils
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      635406c3
    • Francisco Massa's avatar
      Add read_file (#2728) · a9e4cea0
      Francisco Massa authored
      * Add read_file
      
      * Add test for non-existent file
      
      * Fix lint
      
      * Lint v2
      
      * Try fix windows
      
      * Try fix Windows v2
      
      * Lint
      
      * Windows v3
      
      * Missed one change in the adapted function
      
      * Try again on Windows
      
      * One more try on Windows
      
      * Give up on tempfile for now
      
      * Are extensions what's missing on Windows?
      
      * Investigating if the issue is on our side
      
      * Try deleting tensor which could hold into the file
      
      * Put back temporary folder
      a9e4cea0
  7. 29 Sep, 2020 2 commits
  8. 28 Sep, 2020 1 commit
  9. 25 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      Add encoding and writing JPEG ops (#2696) · 662373f6
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add decode and write JPEG ops
      
      * Fix styling issues
      
      * Use int64_t instead of int
      
      * Use std::string
      
      * Use jpegcommon.h for read_jpeg
      
      * Minor updates to error handling in read
      
      * Include header only once
      
      * Reverse header inclusion
      
      * Update common header
      
      * Add common definitions
      
      * Include string
      
      * Include header?
      
      * Include header?
      
      * Add Python frontend calls
      
      * Use unsigned long directly
      
      * Fix style issues
      
      * Include cstddef
      
      * Ignore clang-format on cstddef
      
      * Also include stdio
      
      * Add JPEG and PNG include dirs
      
      * Use C10_EXPORT
      
      * Add JPEG encoding test
      
      * Set quality to 75 by default and add write jpeg test
      
      * Minor error correction
      
      * Use assertEquals by assertEqual
      
      * Remove test results
      
      * Use pre-saved PIL output
      
      * Remove extra PIL call
      
      * Use read_jpeg instead of PIL
      
      * Add error tests
      
      * Address review comments
      
      * Fix style issues
      
      * Set test case to uint8
      
      * Update test error check
      
      * Apply suggestions from code review
      
      * Fix clang-format
      
      * Fix lint
      
      * Fix test
      
      * Remove unused file
      
      * Fix regex error message
      
      * Fix tests
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      662373f6
  10. 18 Sep, 2020 1 commit
  11. 14 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add CMake build and function tracing tests (#2577) · a075d629
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add CMake build pipeline
      
      * Add CMake build workflow
      
      * Add executable permissions to script
      
      * Install cmake on Windows/MacOS
      
      * Install conda-build before setting up MSVC
      
      * Install PyTorch from nightly
      
      * Do not use conda-build variables
      
      * Add path to CMake
      
      * Install libpng and libjpeg
      
      * Perform make
      
      * Call msbuild on Windows
      
      * Add missing yq
      
      * Use vc_env_helper
      
      * Use string instruction
      
      * Escape configuration option
      
      * Remove configuration flag
      
      * Try to pass -p
      
      * Use caret to escape equal sign
      
      * Escape string option in Windows
      
      * Try to call other bat
      
      * Remove Windows/GPU CMake
      
      * Add tracing cpp test
      
      * Script model instead of tracing it
      
      * Try to register operators manually
      
      * Use manylinux-cuda102
      
      * Activate conda env on Linux
      
      * Build and run sample tracing test
      
      * Add empty echo
      
      * Remove unnecessary register
      
      * Copy headers on Mac
      
      * Revert to 2xlarge
      
      * Include /usr/local/include on Mac
      
      * Install pillow on Windows
      
      * Install future
      
      * Install torchvision on Windows
      
      * Set include flag
      
      * Add torchlib to PATH
      
      * Normalize path via cygpath
      
      * Register ops on Windows
      
      * Minor error correction
      
      * Register CPU/GPU ops on DLL library and register ops via reference
      
      * Install dataclasses
      
      * Install dataclasses using pip
      
      * Address clang formatting issue
      
      * Try to use an actual GPU instance on Linux
      
      * Remove extra environment section
      
      * Declare environment explicitly
      
      * Regenerate
      
      * Pass env variables to Dokcer
      
      * Regenerate circleci
      
      * Test tracing on GPU
      
      * Use GPU medium
      
      * Regenerate
      
      * Use cuda101
      
      * Regenerate
      
      * Do not use pre-trained weights
      
      Avoids having to download pretrained files, which could cause flaky tests
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      a075d629
  12. 07 Sep, 2020 1 commit
  13. 02 Sep, 2020 1 commit
  14. 24 Aug, 2020 1 commit
    • vfdev's avatar
      Fixes crash in deformable convolutions (2598) (#2604) · 8c32666b
      vfdev authored
      * [WIP] Fixes #2598
      - Adjusted num_kernels and batch_size according to kMaxGridNum * CUDA_NUM_THREADS
      - Tests to add
      
      * - Redefined kMaxGridNum as max grid according to current CUDA device
      - Added test to check the code from issue and compared grads CPU/CUDA
      
      * Fixed static kMaxGridNum evaluation to dynamic
      8c32666b
  15. 15 Jul, 2020 1 commit
  16. 12 Jul, 2020 1 commit
  17. 09 Jul, 2020 2 commits
    • Francisco Massa's avatar
      Fix wrong clamping in RoIAlign with aligned=True (#2438) · 131ba132
      Francisco Massa authored
      * Fix wrong clamping in RoIAlign with aligned=True
      
      * Fix silly mistake
      
      * Bugfix pointed out during code-review
      131ba132
    • mcarilli's avatar
      [WIP] Allow autocast for 1.6 (#2384) · 0a8586c9
      mcarilli authored
      
      
      * Fixes Xiao's repro
      
      * Ports nms to use full dispatcher
      
      * Move HIPGuard to nms_cuda
      
      * clang-format
      
      * run models in test_models.py on GPU if available
      
      * Francisco's comment, also disable cuda model tests to see if CPU alone still passes
      
      * cuda tests now pass locally, although still not comparing to saved numerics
      
      * add note for thing to ask francisco
      
      * Allow cuda and cpu tests to share a data file
      
      * ignore suffix if unneeded
      
      * Skip autocast numerics checks for a few models
      
      * Add roi_align test
      Co-authored-by: default avatarMichael Carilli <mcarilli@nvidia.com>
      0a8586c9
  18. 08 Jul, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Read JPEG images directly (#2388) · 4246abc8
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Enable JPEG support using libjpeg directly
      
      * Install libjpeg-turbo8 on Travis
      
      * Fix styling issues
      
      * Do not append to paths if library found in standard library locations
      
      * Add macro flag
      
      * Use custom error handler
      
      * Use 3?
      
      * Use short-lived buffer
      
      * Return TRUE instead of true
      
      * Assert RuntimeError
      
      * Use .jpg extension
      
      * Remove conda-forge
      
      * Use data_ptr instead of accessor
      
      * Use assertTrue for jpeg verification
      
      * Remove unnecessary memcpy
      
      * Debug test on Windows
      
      * Remove PIL from jpeg verification
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      4246abc8
  19. 06 Jul, 2020 1 commit
  20. 03 Jul, 2020 1 commit
    • Francisco Massa's avatar
      Fix image extension tests (#2382) · 5247f7b6
      Francisco Massa authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      
      * Fix image extension tests
      
      * Add libpng to environment + test fixes
      
      * Minor improvements
      
      * Remove unused Py2 code
      
      * Add stub comments to prevent deletion while merging
      
      * Reintroduce files in order to prevent deletion during merge
      
      * Remove unwanted merge sections
      
      * Restore libpng conda installation on wheel distributions
      
      * Restore comment
      
      * Fix libpng discovery on Windows
      
      * Fix PEP8 style issues
      
      * Add linking flag on Windows
      
      * Remove parenthesis
      
      * Restore libpng during runtime
      Co-authored-by: default avatarEdgar Andrés Margffoy Tuay <andfoy@gmail.com>
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      5247f7b6
  21. 02 Jul, 2020 2 commits
    • Francisco Massa's avatar
      Revert "PR: Enable libPNG support (#2379)" (#2383) · e4b9823f
      Francisco Massa authored
      This reverts commit c1a99b7b.
      e4b9823f
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Enable libPNG support (#2379) · c1a99b7b
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      c1a99b7b
  22. 01 Jul, 2020 1 commit
  23. 30 Jun, 2020 2 commits
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add libpng and libjpeg-turbo requirement into conda recipe (#2301) · 766721b1
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      766721b1
    • Edward Z. Yang's avatar
      Port roi_align to actually use dispatcher (#2366) · 44806038
      Edward Z. Yang authored
      
      
      * Switch torchvision registrations to new operator registration API.
      
      This is still registering everything as catchalls, so we're really just
      moving deck chairs around, but payoff is coming soon.
      Signed-off-by: default avatarEdward Z. Yang <ezyang@fb.com>
      
      * Port roi_align to actually use dispatcher
      Signed-off-by: default avatarEdward Z. Yang <ezyang@fb.com>
      44806038
  24. 09 Jun, 2020 1 commit
  25. 01 Jun, 2020 1 commit
  26. 26 May, 2020 1 commit
  27. 18 May, 2020 1 commit
  28. 14 May, 2020 1 commit
  29. 12 May, 2020 1 commit
  30. 04 May, 2020 1 commit
  31. 23 Apr, 2020 1 commit
  32. 07 Apr, 2020 1 commit
    • Brian Hart's avatar
      improve consistency among box IoU calculations (#2072) · f6a3e0c3
      Brian Hart authored
      Torchvision includes at least 3 bits of code that calculate
      box Intersection over Union values (and usually compare to
      a threshold):
      
      - box_iou in torchvision/ops/boxes.py
      - devIoU in torchvision/csrc/cuda/nms_cuda.cu
      - nms_cpu_kernel in torchvision/csrc/cpu/nms_cpu.cpp
      
      The calculations were performed slightly differently between
      those, leading to occasional differences in results.
      
      Update devIoU to use the same method as the others for better
      consistency.
      
      This change improves agreement between the CPU and CUDA
      calculations but the results can still differ slightly.
      Setting NVCC_FLAGS to include "--fmad=true" would provide
      still better agreement, but with likely cost to performance.
      f6a3e0c3