GitLab

`Mn`, `Sn` are used as mean and std, but their suddenly turned to be
`mean[n]` and `std[n]` in about 10 words later

At the moment in the ASPP-Layer the number of output channels are predefined as a constant,
which is good for DeepLab but not necessairly in other projects, where another out-channel Nr. is required.

Also the number of "atrous rates" is fixed to three, which also could be sometimes more or less depending on the notwork-arch.
Again these fixed values may make sense in DeepLab-Model but not necessarily in other type of models.

This pull-req. contains the needed changes to make ASPP-Layer generic.

* Don't include CUDAApplyUtils.cuh

* fix format

* fix atomic

* Improve documentation for NMS

* update nms doc for special case

* only display extensions if available

* add tests

* fix lint

* For detection model, replace L1 loss with beta smooth L1 loss to achieve better performance.

* Add type annotations for torchscript

* Resolve E226

* fix the use of contiguous() in kernels

* clang-format

* add a contiguous in nms
Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com>

* Fixing nms on boxes when no detection

* test

* Fix for scale_factor computation

* remove newline

* Fix for mask_rcnn dynanmic axes

* Clean up

* Update transform.py

* Fix for torchscript

* Fix scripting errors

* Fix annotation

* Fix lint

* Fix annotation

* Fix for interpolate scripting

* Fix for scripting

* refactoring

* refactor the code

* Fix annotation

* Fixed annotations

* Added test for resize

* lint

* format

* bump ORT

* ort-nightly version

* Going to ort 1.1.0

* remove version

* install typing-extension

Summary:
Pull Request resolved: https://github.com/pytorch/vision/pull/2077

Pull Request resolved: https://github.com/facebookresearch/SlowFast/pull/164

This is a follow-up diff from D18720474

We will be releasing a new version of torchvision soon and the signature of those functions is not ready yet, following my comment in https://our.intern.facebook.com/intern/diff/D18720474/?transaction_id=561239541337402



Reviewed By: stephenyan1231

Differential Revision: D20914571

fbshipit-source-id: 1a7560b8f8e46ab42ef376c50b494a4f73923e94
Co-authored-by: Francisco Massa <fmassa@fb.com>

These are a bit difficult to debug when you can't see the commands that
are running. So just output every command that's running to stdout using
`set -x`
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Torchvision includes at least 3 bits of code that calculate
box Intersection over Union values (and usually compare to
a threshold):

- box_iou in torchvision/ops/boxes.py
- devIoU in torchvision/csrc/cuda/nms_cuda.cu
- nms_cpu_kernel in torchvision/csrc/cpu/nms_cpu.cpp

The calculations were performed slightly differently between
those, leading to occasional differences in results.

Update devIoU to use the same method as the others for better
consistency.

This change improves agreement between the CPU and CUDA
calculations but the results can still differ slightly.
Setting NVCC_FLAGS to include "--fmad=true" would provide
still better agreement, but with likely cost to performance.

* Add tests for negative samples for Mask R-CNN and Keypoint R-CNN

* Fix lint

* Replace **.is_cuda() to just is_cuda()

* Replace type to scalar_type

* Fix lint, clang-format

* Fix lint, clang-format

cleanup

* Try building Windows nightlies on CircleCI

* Update config.yml

* Merge jobs

* Use cmd

* Debug

* Fix PATH

* Enable build matrix

* Try integrate with regenerate.py

* Fix upload path for Windows wheels

* Bring fewer tests to CI

* Run other tests only on master

* Refactor code

* Use nightly branch

* Fix lint

* type annotations for torchvision/utils.py

* add missing annotation for make_grid

* fix annotation for save_image

* mirror PIL annotation for fp

* improve stability of test_nms_cuda

This change addresses two issues:

_create_tensors_with_iou() creates test data for the NMS tests. It
takes care to ensure at least one pair of boxes (1st and last) have
IoU around the threshold for the test. However, the constructed
IoU for that pair is _so_ close to the threshold that rounding
differences (presumably) between CPU and CUDA implementations may
result in one suppressing a box in the pair and the other not.
Adjust the construction to ensure the IoU for the box pair is
near the threshold, but far-enough above that both implementations
should agree.

Where 2 boxes have nearly or exactly the same score, the CPU and
CUDA implementations may order them differently. Adjust
test_nms_cuda() to check only that the non-suppressed box lists
include the same members, without regard for ordering.

* adjust assertion in test_nms_cuda

The CPU and CUDA nms implementations each sort the box scores
as part of their work, but the sorts they use are not stable. So
boxes with the same score maybe be processed in opposite order
by the two implmentations.

Relax the assertion in test_nms_cuda (following the model in
pytorch's test_topk()) to allow the test to pass if the output
differences are caused by similarly-scored boxes.

* improve stability of test_nms_cuda

Adjust _create_tensors_with_iou() to ensure we create at least
one box just over threshold that should be suppressed.