GitLab

* Fix out-of-bounds read in decode_png

* Fix lint

* Use size_t instead of int to fix sign-compare check

* Add a unit-test to decode currupted png file

* Fix linter

* Update torchvision/csrc/io/image/cpu/decode_png.cpp

* Replace png_error with TORCH_CHECK
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Update error message

* Update error message
Co-authored-by: vfdev <vfdev.5@gmail.com>

* Fix linter
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: vfdev <vfdev.5@gmail.com>

* upgrade usort to

* Also update black

* Actually use 1.0.2

* Apply pre-commit
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

This reverts commit 85b78580.

Description:
- Applied `contiguous` on decoded output tensor in decode_jpeg and decode_png ops
- Updated tests and docs

Related to #4880

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* WIP

* cleaner code

* Add tests

* Add docs

* Assert dtype

* put back check

* Address comments
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

* add ufmt as code formatter

* cleanup

* quote ufmt requirement

* split imports into more groups

* regenerate circleci config

* fix CI

* clarify local testing utils section

* use ufmt pre-commit hook

* split relative imports into local category

* Revert "split relative imports into local category"

This reverts commit f2e224cde2008c56c9347c1f69746d39065cdd51.

* pin black and usort dependencies

* fix local test utils detection

* fix ufmt rev

* add reference utils to local category

* fix usort config

* remove custom categories sorting

* Run pre-commit without fixing flake8

* got a double import in merge
Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* Replace in test_datasets*

* Replace in test_image.py

* Replace in test_transforms_tensor.py

* Replace in test_internet.py and test_io.py

* get_list_of_videos is util function still use get_tmp_dir

* Fix get_list_of_videos siginiture

* Add get_tmp_dir import

* Modify test_datasets_video_utils.py for test to pass

* Fix indentation

* Replace get_tmp_dir in util functions in test_dataset_sampler.py

* Replace get_tmp_dir in util functions in test_dataset_video_utils.py

* Move get_tmp_dir() to datasets_utils.py and refactor

* Fix pylint, indentation and imports

* import shutil to common_util.py

* Fix function signiture

* Remove get_list_of_videos under context manager

* Move get_list_of_videos to common_utils.py

* Move get_tmp_dir() back to common_utils.py

* Fix pylint and imports
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

* interlaced png images
Co-authored-by: Vincent Moens <vmoens@fb.com>

Co-authored-by: Vincent Moens <vmoens@fb.com>

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* Fixed read_image bug

* Removed unused import

* Skip tests if cv2 unavailable

* Removed cv2 dependency

Co-authored-by: Philip Meier <github.pmeier@posteo.de>

Co-authored-by: James Thewlis <james@unitary.ai>

* Fix writing to files by using get_tmp_dir()

* Add ImageReadMode to imports

* Fix failing test due to incorrect image path

* Add support of mode and remove channels.

* Replacing integer mode with define constants.

* Adding output channels implementation for pngs.

* Adding tests for png.

* Adding channels in the API and documentation.

* Fixing formatting.

* Refactoring test_image.py to remove huge grace_hopper_517x606.pth file from assets and reduce duplicate code. Moving jpeg assets used by encode and write unit-tests on their separate folders.

* Adding output channels implementation for jpegs. Fix asset locations.

* Add tests for JPEG, adding the channels in the API and documentation and adding checks for inputs.

* Changing folder for unit-test.

* Fixing windows flakiness, removing duplicate test.

* Replacing components to channels.

* Adding reference for supporting CMYK.

* Minor changes: num_components to output_components, adding comments, fixing variable name etc.

* Reverting output_components to num_components.

* Replacing decoding with generic method on tests.

* Palette converted to Gray.

* Add support of different color types in readpng.

* Adding test images and unit-tests.

* Use closest possible type.

* Fix formatting.

* Make read_file accept unicode strings on Windows

* More fixes

* Remove definitions from source files

* Move string definitions to header

* Add checks

* Fix comments

* Update macro

* Fix comments

* Fix lint

* include windows header

* Change func signature in header

* Use from_blob

* Fix fread calls

* Fix clang format

* Fix missing return

* Avoid copy

* Improve read_file for Windows

* Fix lint

* Use _stat64 instead

* Apply suggesion

* Fix lint

* Add write_file

* Fix lint

* Add read_file

* Add test for non-existent file

* Fix lint

* Lint v2

* Try fix windows

* Try fix Windows v2

* Lint

* Windows v3

* Missed one change in the adapted function

* Try again on Windows

* One more try on Windows

* Give up on tempfile for now

* Are extensions what's missing on Windows?

* Investigating if the issue is on our side

* Try deleting tensor which could hold into the file

* Put back temporary folder

* Add encode/write_png functions

* Do not redefine

* Style issues correction

* Comply with low-level interface

* Minor comment correction

* Add python frontend functions

* Add encode_png test

* Pass compession level to encode_png

* Do not compare output buffers

* Convert to bytes

* Compare pil image instead of buffer

* Add error tests

* Add test_write_png

* Remove png test assets

* Register writePNG correctly

* Update write_png docstring

* Do not preserve PIL image beyond the scope
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Add decode_image op

* Fix lint

* More lint

* Add C10_EXPORT

* Add decode and write JPEG ops

* Fix styling issues

* Use int64_t instead of int

* Use std::string

* Use jpegcommon.h for read_jpeg

* Minor updates to error handling in read

* Include header only once

* Reverse header inclusion

* Update common header

* Add common definitions

* Include string

* Include header?

* Include header?

* Add Python frontend calls

* Use unsigned long directly

* Fix style issues

* Include cstddef

* Ignore clang-format on cstddef

* Also include stdio

* Add JPEG and PNG include dirs

* Use C10_EXPORT

* Add JPEG encoding test

* Set quality to 75 by default and add write jpeg test

* Minor error correction

* Use assertEquals by assertEqual

* Remove test results

* Use pre-saved PIL output

* Remove extra PIL call

* Use read_jpeg instead of PIL

* Add error tests

* Address review comments

* Fix style issues

* Set test case to uint8

* Update test error check

* Apply suggestions from code review

* Fix clang-format

* Fix lint

* Fix test

* Remove unused file

* Fix regex error message

* Fix tests
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Make JPEG/PNG return images in CHW format

* Use int array

* Add corruption cases

* Read jpeg headers until exhaustion

* Minor error correction

* Add test script

* Raise exception when image is truncated

* Add test

* Skip damaged_jpeg folder

* Compare against basename

* Remove unused test file