1. 29 Sep, 2020 1 commit
  2. 28 Sep, 2020 1 commit
  3. 25 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      Add encoding and writing JPEG ops (#2696) · 662373f6
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add decode and write JPEG ops
      
      * Fix styling issues
      
      * Use int64_t instead of int
      
      * Use std::string
      
      * Use jpegcommon.h for read_jpeg
      
      * Minor updates to error handling in read
      
      * Include header only once
      
      * Reverse header inclusion
      
      * Update common header
      
      * Add common definitions
      
      * Include string
      
      * Include header?
      
      * Include header?
      
      * Add Python frontend calls
      
      * Use unsigned long directly
      
      * Fix style issues
      
      * Include cstddef
      
      * Ignore clang-format on cstddef
      
      * Also include stdio
      
      * Add JPEG and PNG include dirs
      
      * Use C10_EXPORT
      
      * Add JPEG encoding test
      
      * Set quality to 75 by default and add write jpeg test
      
      * Minor error correction
      
      * Use assertEquals by assertEqual
      
      * Remove test results
      
      * Use pre-saved PIL output
      
      * Remove extra PIL call
      
      * Use read_jpeg instead of PIL
      
      * Add error tests
      
      * Address review comments
      
      * Fix style issues
      
      * Set test case to uint8
      
      * Update test error check
      
      * Apply suggestions from code review
      
      * Fix clang-format
      
      * Fix lint
      
      * Fix test
      
      * Remove unused file
      
      * Fix regex error message
      
      * Fix tests
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      662373f6
  4. 18 Sep, 2020 1 commit
  5. 14 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add CMake build and function tracing tests (#2577) · a075d629
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add CMake build pipeline
      
      * Add CMake build workflow
      
      * Add executable permissions to script
      
      * Install cmake on Windows/MacOS
      
      * Install conda-build before setting up MSVC
      
      * Install PyTorch from nightly
      
      * Do not use conda-build variables
      
      * Add path to CMake
      
      * Install libpng and libjpeg
      
      * Perform make
      
      * Call msbuild on Windows
      
      * Add missing yq
      
      * Use vc_env_helper
      
      * Use string instruction
      
      * Escape configuration option
      
      * Remove configuration flag
      
      * Try to pass -p
      
      * Use caret to escape equal sign
      
      * Escape string option in Windows
      
      * Try to call other bat
      
      * Remove Windows/GPU CMake
      
      * Add tracing cpp test
      
      * Script model instead of tracing it
      
      * Try to register operators manually
      
      * Use manylinux-cuda102
      
      * Activate conda env on Linux
      
      * Build and run sample tracing test
      
      * Add empty echo
      
      * Remove unnecessary register
      
      * Copy headers on Mac
      
      * Revert to 2xlarge
      
      * Include /usr/local/include on Mac
      
      * Install pillow on Windows
      
      * Install future
      
      * Install torchvision on Windows
      
      * Set include flag
      
      * Add torchlib to PATH
      
      * Normalize path via cygpath
      
      * Register ops on Windows
      
      * Minor error correction
      
      * Register CPU/GPU ops on DLL library and register ops via reference
      
      * Install dataclasses
      
      * Install dataclasses using pip
      
      * Address clang formatting issue
      
      * Try to use an actual GPU instance on Linux
      
      * Remove extra environment section
      
      * Declare environment explicitly
      
      * Regenerate
      
      * Pass env variables to Dokcer
      
      * Regenerate circleci
      
      * Test tracing on GPU
      
      * Use GPU medium
      
      * Regenerate
      
      * Use cuda101
      
      * Regenerate
      
      * Do not use pre-trained weights
      
      Avoids having to download pretrained files, which could cause flaky tests
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      a075d629
  6. 07 Sep, 2020 1 commit
  7. 02 Sep, 2020 1 commit
  8. 24 Aug, 2020 1 commit
    • vfdev's avatar
      Fixes crash in deformable convolutions (2598) (#2604) · 8c32666b
      vfdev authored
      * [WIP] Fixes #2598
      - Adjusted num_kernels and batch_size according to kMaxGridNum * CUDA_NUM_THREADS
      - Tests to add
      
      * - Redefined kMaxGridNum as max grid according to current CUDA device
      - Added test to check the code from issue and compared grads CPU/CUDA
      
      * Fixed static kMaxGridNum evaluation to dynamic
      8c32666b
  9. 15 Jul, 2020 1 commit
  10. 12 Jul, 2020 1 commit
  11. 09 Jul, 2020 2 commits
    • Francisco Massa's avatar
      Fix wrong clamping in RoIAlign with aligned=True (#2438) · 131ba132
      Francisco Massa authored
      * Fix wrong clamping in RoIAlign with aligned=True
      
      * Fix silly mistake
      
      * Bugfix pointed out during code-review
      131ba132
    • mcarilli's avatar
      [WIP] Allow autocast for 1.6 (#2384) · 0a8586c9
      mcarilli authored
      
      
      * Fixes Xiao's repro
      
      * Ports nms to use full dispatcher
      
      * Move HIPGuard to nms_cuda
      
      * clang-format
      
      * run models in test_models.py on GPU if available
      
      * Francisco's comment, also disable cuda model tests to see if CPU alone still passes
      
      * cuda tests now pass locally, although still not comparing to saved numerics
      
      * add note for thing to ask francisco
      
      * Allow cuda and cpu tests to share a data file
      
      * ignore suffix if unneeded
      
      * Skip autocast numerics checks for a few models
      
      * Add roi_align test
      Co-authored-by: default avatarMichael Carilli <mcarilli@nvidia.com>
      0a8586c9
  12. 08 Jul, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Read JPEG images directly (#2388) · 4246abc8
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Enable JPEG support using libjpeg directly
      
      * Install libjpeg-turbo8 on Travis
      
      * Fix styling issues
      
      * Do not append to paths if library found in standard library locations
      
      * Add macro flag
      
      * Use custom error handler
      
      * Use 3?
      
      * Use short-lived buffer
      
      * Return TRUE instead of true
      
      * Assert RuntimeError
      
      * Use .jpg extension
      
      * Remove conda-forge
      
      * Use data_ptr instead of accessor
      
      * Use assertTrue for jpeg verification
      
      * Remove unnecessary memcpy
      
      * Debug test on Windows
      
      * Remove PIL from jpeg verification
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      4246abc8
  13. 06 Jul, 2020 1 commit
  14. 03 Jul, 2020 1 commit
    • Francisco Massa's avatar
      Fix image extension tests (#2382) · 5247f7b6
      Francisco Massa authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      
      * Fix image extension tests
      
      * Add libpng to environment + test fixes
      
      * Minor improvements
      
      * Remove unused Py2 code
      
      * Add stub comments to prevent deletion while merging
      
      * Reintroduce files in order to prevent deletion during merge
      
      * Remove unwanted merge sections
      
      * Restore libpng conda installation on wheel distributions
      
      * Restore comment
      
      * Fix libpng discovery on Windows
      
      * Fix PEP8 style issues
      
      * Add linking flag on Windows
      
      * Remove parenthesis
      
      * Restore libpng during runtime
      Co-authored-by: default avatarEdgar Andrés Margffoy Tuay <andfoy@gmail.com>
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      5247f7b6
  15. 02 Jul, 2020 2 commits
    • Francisco Massa's avatar
      Revert "PR: Enable libPNG support (#2379)" (#2383) · e4b9823f
      Francisco Massa authored
      This reverts commit c1a99b7b.
      e4b9823f
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Enable libPNG support (#2379) · c1a99b7b
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      c1a99b7b
  16. 01 Jul, 2020 1 commit
  17. 30 Jun, 2020 2 commits
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add libpng and libjpeg-turbo requirement into conda recipe (#2301) · 766721b1
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      766721b1
    • Edward Z. Yang's avatar
      Port roi_align to actually use dispatcher (#2366) · 44806038
      Edward Z. Yang authored
      
      
      * Switch torchvision registrations to new operator registration API.
      
      This is still registering everything as catchalls, so we're really just
      moving deck chairs around, but payoff is coming soon.
      Signed-off-by: default avatarEdward Z. Yang <ezyang@fb.com>
      
      * Port roi_align to actually use dispatcher
      Signed-off-by: default avatarEdward Z. Yang <ezyang@fb.com>
      44806038
  18. 09 Jun, 2020 1 commit
  19. 01 Jun, 2020 1 commit
  20. 26 May, 2020 1 commit
  21. 18 May, 2020 1 commit
  22. 14 May, 2020 1 commit
  23. 12 May, 2020 1 commit
  24. 04 May, 2020 1 commit
  25. 23 Apr, 2020 1 commit
  26. 07 Apr, 2020 2 commits
    • Brian Hart's avatar
      improve consistency among box IoU calculations (#2072) · f6a3e0c3
      Brian Hart authored
      Torchvision includes at least 3 bits of code that calculate
      box Intersection over Union values (and usually compare to
      a threshold):
      
      - box_iou in torchvision/ops/boxes.py
      - devIoU in torchvision/csrc/cuda/nms_cuda.cu
      - nms_cpu_kernel in torchvision/csrc/cpu/nms_cpu.cpp
      
      The calculations were performed slightly differently between
      those, leading to occasional differences in results.
      
      Update devIoU to use the same method as the others for better
      consistency.
      
      This change improves agreement between the CPU and CUDA
      calculations but the results can still differ slightly.
      Setting NVCC_FLAGS to include "--fmad=true" would provide
      still better agreement, but with likely cost to performance.
      f6a3e0c3
    • AhnDW's avatar
      Remove warning about deprecated (#2064) · 57c789f8
      AhnDW authored
      * Replace **.is_cuda() to just is_cuda()
      
      * Replace type to scalar_type
      
      * Fix lint, clang-format
      
      * Fix lint, clang-format
      57c789f8
  27. 03 Apr, 2020 3 commits
  28. 02 Apr, 2020 1 commit
  29. 01 Apr, 2020 1 commit
  30. 30 Mar, 2020 2 commits
    • Yuwen Xiong's avatar
      Fix shape error for deform conv (#2027) · 7ee5a8b7
      Yuwen Xiong authored
      * fix shape error for deform conv gpu op
      
      recover shape of columns for next iteration in for loops, previous version will cause error when batch_sz / n_parallel_imgs > 1
      
      * fix shape error for deform conv cpu op
      
      recover shape of columns for next iteration in for loops, previous version will cause error when batch_sz / n_parallel_imgs > 1
      7ee5a8b7
    • Mikhail Lobanov's avatar
      Fix Tensor::data<> deprecation. (#2028) · 561a014b
      Mikhail Lobanov authored
      561a014b
  31. 24 Mar, 2020 1 commit
  32. 17 Mar, 2020 1 commit
    • Francisco Massa's avatar
      Update video reader to use new decoder (#1978) · 32e16805
      Francisco Massa authored
      * Base decoder for video. (#1747)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1747
      
      Pull Request resolved: https://github.com/pytorch/vision/pull/1746
      
      Added the implementation of ffmpeg based decoder with functionality that can be used in VUE and TorchVision.
      
      Reviewed By: fmassa
      
      Differential Revision: D19358914
      
      fbshipit-source-id: abb672f89bfaca6351dda2354f0d35cf8e47fa0f
      
      * Integrated base decoder into VideoReader class and video_utils.py (#1766)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1766
      
      Replaced FfmpegDecoder (incompativle with VUE) by base decoder (compatible with VUE).
      Modified python utilities video_utils.py for internal simplification. Public interface got preserved.
      
      Reviewed By: fmassa
      
      Differential Revision: D19415903
      
      fbshipit-source-id: 4d7a0158bd77bac0a18732fe4183fdd9a57f6402
      
      * Optimizating base decoder performance. (#1852)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1852
      
      Changed base decoder internals for a faster clip processing.
      
      Reviewed By: stephenyan1231
      
      Differential Revision: D19748379
      
      fbshipit-source-id: 58a435f0a0b25545e7bd1a3edb0b1d558176a806
      
      * Minor fix and decoder class members access.
      
      Summary:
      Found and fix a bug in cropping algorithm (simple mistyping).
      Also derived classes need access to some decoder class members, like initialization parameters - make it protected.
      
      Reviewed By: stephenyan1231, fmassa
      
      Differential Revision: D19895076
      
      fbshipit-source-id: 691336c8e18526b085ae5792ac3546bc387a6db9
      
      * Added missing header for less dependencies. (#1898)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1898
      
      Include streams/samplers shouldn't depend on decoder headers. Add dependencies directly to the place where they are required.
      
      Reviewed By: stephenyan1231
      
      Differential Revision: D19911404
      
      fbshipit-source-id: ef322a053708405c02cee4562b456b1602fb12fc
      
      * Implemented VUE Asynchronous Decoder
      
      Summary: For Mothership we have found that asynchronous decoder provides a better performance.
      
      Differential Revision: D20026194
      
      fbshipit-source-id: 627b91844b4e3f917002031dd32cb19c239f4ba8
      
      * fix a bug in API read_video_from_memory (#1942)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1942
      
      In D18720474, it introduces a bug in `read_video_from_memory` API. Thank weiyaowang for reporting it.
      
      Reviewed By: weiyaowang
      
      Differential Revision: D20270179
      
      fbshipit-source-id: 66348c99a5ad1f9129b90e934524ddfaad59de03
      
      * extend decoder to support new video_max_dimension argument (#1924)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1924
      
      Extend `video reader` decoder python API in Torchvision to support a new argument `video_max_dimension`. This enables the new video decoding use cases. When setting `video_width=0`, `video_height=0`, `video_min_dimension != 0`, and `video_max_dimension != 0`, we can rescale the video clips so that its spatial resolution (height, width) becomes
       - (video_min_dimension, video_max_dimension) if original height < original width
       - (video_max_dimension, video_min_dimension) if original height >= original width
      
      This is useful at video model testing stage, where we perform fully convolution evaluation and take entire video frames without cropping as input. Previously, for instance we can only set `video_width=0`, `video_height=0`, `video_min_dimension = 128`, which will preserve aspect ratio. In production dataset, there are a small number of videos where aspect ratio is either extremely large or small, and when the shorter edge is rescaled to 128, the longer edge is still large. This will easily cause GPU memory OOM when we sample multiple video clips, and put them in a single minibatch.
      
      Now, we can set (for instance) `video_width=0`, `video_height=0`, `video_min_dimension = 128` and `video_max_dimension = 171` so that the rescale resolution is either (128, 171) or (171, 128) depending on whether original height is larger than original width. Thus, we are less likely to have gpu OOM because the spatial size of video clips is determined.
      
      Reviewed By: putivsky
      
      Differential Revision: D20182529
      
      fbshipit-source-id: f9c40afb7590e7c45e6908946597141efa35f57c
      
      * Fixing samplers initialization (#1967)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1967
      
      
      
      No-ops for torchvision diff, which fixes samplers.
      
      Differential Revision: D20397218
      
      fbshipit-source-id: 6dc4d04364f305fbda7ca4f67a25ceecd73d0f20
      
      * Exclude C++ test files
      Co-authored-by: default avatarYuri Putivsky <yuri@fb.com>
      Co-authored-by: default avatarZhicheng Yan <zyan3@fb.com>
      32e16805
  33. 12 Mar, 2020 1 commit