1. 06 Oct, 2020 2 commits
    • Francisco Massa's avatar
      Add write_file (#2765) · 6e639d3e
      Francisco Massa authored
      * Add write_file
      
      * Fix lint
      6e639d3e
    • Francisco Massa's avatar
      Add read_file (#2728) · a9e4cea0
      Francisco Massa authored
      * Add read_file
      
      * Add test for non-existent file
      
      * Fix lint
      
      * Lint v2
      
      * Try fix windows
      
      * Try fix Windows v2
      
      * Lint
      
      * Windows v3
      
      * Missed one change in the adapted function
      
      * Try again on Windows
      
      * One more try on Windows
      
      * Give up on tempfile for now
      
      * Are extensions what's missing on Windows?
      
      * Investigating if the issue is on our side
      
      * Try deleting tensor which could hold into the file
      
      * Put back temporary folder
      a9e4cea0
  2. 29 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      Add encoding and writing PNG ops (#2726) · f8780e2e
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add encode/write_png functions
      
      * Do not redefine
      
      * Style issues correction
      
      * Comply with low-level interface
      
      * Minor comment correction
      
      * Add python frontend functions
      
      * Add encode_png test
      
      * Pass compession level to encode_png
      
      * Do not compare output buffers
      
      * Convert to bytes
      
      * Compare pil image instead of buffer
      
      * Add error tests
      
      * Add test_write_png
      
      * Remove png test assets
      
      * Register writePNG correctly
      
      * Update write_png docstring
      
      * Do not preserve PIL image beyond the scope
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      f8780e2e
  3. 28 Sep, 2020 1 commit
  4. 25 Sep, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      Add encoding and writing JPEG ops (#2696) · 662373f6
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add decode and write JPEG ops
      
      * Fix styling issues
      
      * Use int64_t instead of int
      
      * Use std::string
      
      * Use jpegcommon.h for read_jpeg
      
      * Minor updates to error handling in read
      
      * Include header only once
      
      * Reverse header inclusion
      
      * Update common header
      
      * Add common definitions
      
      * Include string
      
      * Include header?
      
      * Include header?
      
      * Add Python frontend calls
      
      * Use unsigned long directly
      
      * Fix style issues
      
      * Include cstddef
      
      * Ignore clang-format on cstddef
      
      * Also include stdio
      
      * Add JPEG and PNG include dirs
      
      * Use C10_EXPORT
      
      * Add JPEG encoding test
      
      * Set quality to 75 by default and add write jpeg test
      
      * Minor error correction
      
      * Use assertEquals by assertEqual
      
      * Remove test results
      
      * Use pre-saved PIL output
      
      * Remove extra PIL call
      
      * Use read_jpeg instead of PIL
      
      * Add error tests
      
      * Address review comments
      
      * Fix style issues
      
      * Set test case to uint8
      
      * Update test error check
      
      * Apply suggestions from code review
      
      * Fix clang-format
      
      * Fix lint
      
      * Fix test
      
      * Remove unused file
      
      * Fix regex error message
      
      * Fix tests
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      662373f6
  5. 08 Jul, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Read JPEG images directly (#2388) · 4246abc8
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Enable JPEG support using libjpeg directly
      
      * Install libjpeg-turbo8 on Travis
      
      * Fix styling issues
      
      * Do not append to paths if library found in standard library locations
      
      * Add macro flag
      
      * Use custom error handler
      
      * Use 3?
      
      * Use short-lived buffer
      
      * Return TRUE instead of true
      
      * Assert RuntimeError
      
      * Use .jpg extension
      
      * Remove conda-forge
      
      * Use data_ptr instead of accessor
      
      * Use assertTrue for jpeg verification
      
      * Remove unnecessary memcpy
      
      * Debug test on Windows
      
      * Remove PIL from jpeg verification
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      4246abc8
  6. 03 Jul, 2020 1 commit
    • Francisco Massa's avatar
      Fix image extension tests (#2382) · 5247f7b6
      Francisco Massa authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      
      * Fix image extension tests
      
      * Add libpng to environment + test fixes
      
      * Minor improvements
      
      * Remove unused Py2 code
      
      * Add stub comments to prevent deletion while merging
      
      * Reintroduce files in order to prevent deletion during merge
      
      * Remove unwanted merge sections
      
      * Restore libpng conda installation on wheel distributions
      
      * Restore comment
      
      * Fix libpng discovery on Windows
      
      * Fix PEP8 style issues
      
      * Add linking flag on Windows
      
      * Remove parenthesis
      
      * Restore libpng during runtime
      Co-authored-by: default avatarEdgar Andrés Margffoy Tuay <andfoy@gmail.com>
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      5247f7b6
  7. 02 Jul, 2020 2 commits
    • Francisco Massa's avatar
      Revert "PR: Enable libPNG support (#2379)" (#2383) · e4b9823f
      Francisco Massa authored
      This reverts commit c1a99b7b.
      e4b9823f
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Enable libPNG support (#2379) · c1a99b7b
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      
      * Remove JPEG-related code
      
      * Remove installation references to turbojpeg
      
      * Remove further references to turbojpeg
      
      * Fix c++ style issues
      
      * Fix c++ style issues
      
      * Fix libpng-config include flag parsing
      
      * Remove conda-forge
      
      * Remove include dirs from main extension
      
      * Do not pass extra include and library paths to main torchvision extension
      
      * Add libpng to environment.yml
      
      * Remove inexistent imports
      
      * Add instructions regarding environment variables to README
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      c1a99b7b
  8. 01 Jul, 2020 1 commit
  9. 30 Jun, 2020 1 commit
    • Edgar Andrés Margffoy Tuay's avatar
      PR: Add libpng and libjpeg-turbo requirement into conda recipe (#2301) · 766721b1
      Edgar Andrés Margffoy Tuay authored
      
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Add PNG reading capabilities
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Add PNG reading capabilities
      
      * Add libpng requirement into conda recipe
      
      * Try to install libjpeg-turbo
      
      * Remove newline
      
      * Add image extension to compilation instructions
      
      * Include png functions as part of the main library
      
      * Update CMakeLists
      
      * Detect if building on conda-build
      
      * Debug
      
      * More debug messages
      
      * Print globbed libreries
      
      * Print globbed libreries
      
      * Point to correct PNG path
      
      * Remove libJPEG preventively
      
      * Debug extension loading
      
      * Link libpng explicitly
      
      * Link with PNG
      
      * Install libpng on conda-based wheel distributions
      
      * Add -y flag
      
      * Add -y flag to yum
      
      * Locate LibPNG on windows conda
      
      * Remove empty else
      
      * Copy libpng16.so
      
      * Copy dylib on Mac
      
      * Improve check on Windows
      
      * Try to install ninja using conda on windows
      
      * Use libpng on Windows
      
      * Package lib on windows wheel
      
      * Point library to the correct place
      
      * Include binaries as part of wheel
      
      * Copy libpng.so on linux
      
      * Look for png.h on Windows when using conda-build
      
      * Do not skip png tests on Mac/Win
      
      * Restore libjpeg-turbo
      
      * Install jpeg-turbo on wheel distributions
      
      * Install libjpeg-turbo from conda-forge on wheel distributions
      
      * Do not pull av on conda-build
      
      * Add pillow disclaimer
      
      * Vendors libjpeg-turbo 2.0.4
      
      * Merge JPEG work
      
      * Remove submodules
      
      * Regenerate circle config
      
      * Fix style issues
      
      * Fix C++ style issues
      
      * More style corrections
      
      * Add JPEG-turbo to linking libraries
      
      * More style corrections
      
      * More style corrections
      
      * More style corrections
      
      * Install libjpeg-turbo-devel
      
      * Install libturbo-jpeg on typing pipeline
      
      * Update Circle template
      
      * Windows and Unix turbojpeg have the same linking name
      
      * Install turbojpeg-devel instead of libjpeg-turbo
      
      * Copy TurboJPEG binaries to wheel
      
      * Move test image
      
      * Move back test image
      
      * Update JPEG test path
      
      * Remove dot from extension
      
      * Move image functions to extension
      
      * Use stdout arg in subprocess
      
      * Disable image extension if libpng or turbojpeg are not found
      
      * Append libpng stdout
      
      * Prevent list appending on lists
      
      * Minor path correction
      
      * Minor error correction
      
      * Add linking flags
      
      * Style issues correction
      
      * Address minor review corrections
      
      * Refactor library search
      
      * Restore access index
      
      * Fix JPEG tests
      
      * Update libpng version in Travis
      
      * Add -y flag
      
      * Remove dot
      
      * Update libpng using apt
      
      * Check libpng version
      
      * Change libturbojpeg binary
      
      * Update import
      
      * Change call
      
      * Restore av in conda recipe
      
      * Minor error correction
      
      * Remove unused comment in travis.yml
      
      * Update README
      
      * Fix missing links
      
      * Remove fixes for 16.04
      Co-authored-by: default avatarRyad ZENINE <r.zenine@gmail.com>
      766721b1