GitLab

* add ufmt as code formatter

* cleanup

* quote ufmt requirement

* split imports into more groups

* regenerate circleci config

* fix CI

* clarify local testing utils section

* use ufmt pre-commit hook

* split relative imports into local category

* Revert "split relative imports into local category"

This reverts commit f2e224cde2008c56c9347c1f69746d39065cdd51.

* pin black and usort dependencies

* fix local test utils detection

* fix ufmt rev

* add reference utils to local category

* fix usort config

* remove custom categories sorting

* Run pre-commit without fixing flake8

* got a double import in merge
Co-authored-by: Nicolas Hug <nicolashug@fb.com>

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

* Adding operator.

* Adding tests

* switching order of `p` and `mode`.

* Remove seed setting.

* Replace stats import with pytest.importorskip.

* Fix doc

* Apply suggestions from code review
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Fixing indentation.

* Adding operator in the documentation.

* Fixing lint
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Nicolas Hug <nicolashug@fb.com>

Co-authored-by: Philip Meier <github.pmeier@posteo.de>

* hello

* Try with DYLD_FALLBACK_LIBRARY_PATH
Co-authored-by: Edgar Andrés Margffoy Tuay <andfoy@gmail.com>

* WIP

* clang

* docs

* extracted out common utils

* Use better quantization function and pass tensors as parameters

* proper dequantization

* Some tests

* Dequantization optimization, seems to gain a few ms

* clang-format

* again

* more correct test. Had to remove optimization although it almost works

* Also test aligned=True

* remove useless part

* more docs and comments

* Put back optimization with more robust test

* Added check for index upper bound

* avoid possible overflow

* Move common function into common.h

* oops

* scale=1,zero_point=0 makes more sense

* Force batch size of 1 to prevent any indexingbug

* format

* format again

* updated docstring

* put back description comment for pre_calc_bilinear_interpolate

* revert most changes to docstring as it's taken care of in another PR

* Add quantized version of nms

* Added tests

* Compute areas only once

* remove calls to dequantize_val

* fix return type for empty tensor

* flake8

* remove use of scale as it gets cancelled out

* simpler int convertion in tests

* explicitly set ovr to double

* add tests for more values of scale and zero_point

* comment about underflow

* remove unnecessary accessor

* properly convert to float for division

* Add comments about underflow

* explicitely cast coordinates to float to allow vectorization

* clang

* clang  again

* hopefully OK now

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* new batched_nms implem

* flake8

* hopefully fix torchscipt tests

* Use where instead of nonzero

* Use same threshold (4k) for CPU and GPU

* Remove use of argsort

* use views again

* remove print

* trying stuff, I don't know what's going on

* previous passed onnx checks so the error isn't in _vanilla func. Trying to return vanilla now

* add tracing decorators

* cleanup

* wip

* ignore new path with ONNX

* use vanilla if tracing...????

* Remove script_if_tracing decorator as it was conflicting with _is_tracing

* flake8

* Improve coverage
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Replace type T with accumulator.

* Upcast tensors of box ops to avoid overflow in multiplications.

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Speedup test_ucf101 (#2623 

* Speedup Cmake builds (#3186)

* Speedup test_autoaugment (#3190)

* Speedup DeformConvTester (#3191)

* Speedup InceptionV3 and GoogleNet on Windows (#3196)

* Replacing all torch.jit.annotations with typing

* Replacing remaining typing

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Enable support for images without annotations

* Ensuring gradient propagates to RegressionHead.

* Rewriting losses to remove branching.

* Fix the seed on DeformConv autocast test.

* Add modulation input for DeformConv2D

* lint

* Patch for GPU CI

* Remove bad cache on CI

* Moving Autocast mtest in RoiOpTester.

* Adding autocast test on DeformConvTester.

* Adding autocast test on NMSTester.

* Fixing styles.

* Change default eps value of FrozenBN.

* Update the unit-tests.`

* Update the expected values.

* Revert the expected value and use original eps=0 value for flaky tests.

* Post init change of eps.

* Styles.

* feat: Updated FrozenBN eps to align with BatchNorm

* feat: Added eps to __repr__ of FrozenBN

* test: Updated unittest of __repr__ for FrozenBN

* test: Updated unittest for eps value in BN and FrozenBN

* fix: Revert FrozenBN eps value

* test: Revert test on eps alignment between FrozenBN and BN

* feat: Added __repr__ to MultiScaleRoIAlign

* test: Added unittest for __repr__ of MultiScaleRoIAlign

* feat: Added feature map names in __repr__

* test: Updated unittest
Co-authored-by: vfdev <vfdev.5@gmail.com>

* Adding checks on forward and backward passes.

* Adding unit-tests.

* fixies small bug in box_convert

* activates jit test

* Passes JIT test

* fixes typo

* adds error tests, removes assert

* implements to proposal2

* adds boxes conversion

* adds documentation

* adds xywh tests

* fixes small typo

* adds tests

* Remove sphinx theme

* corrects assertions

* cleans code as per suggestion
Signed-off-by: Aditya Oke <okeaditya315@gmail.com>

* reverts assertion

* fixes to assertEqual

* fixes inplace operations

* Adds docstrings

* added documentation

* changes tests

* moves code to box_convert

* adds more tests

* Apply suggestions from code review

Let's leave those changes to a separate PR

* fixes documentation
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* tries adding genaralized_iou

* fixes linting

* Adds docs for giou, iou and box area

* fixes lint

* removes docs to fixup in other PR

* linter fix

* Cleans comments

* Adds tests for box area, iou and giou

* typo fix for testCase

* fixes typo

* fixes box area test

* fixes implementation

* updates tests to tolerance

* [WIP] Fixes #2598
- Adjusted num_kernels and batch_size according to kMaxGridNum * CUDA_NUM_THREADS
- Tests to add

* - Redefined kMaxGridNum as max grid according to current CUDA device
- Added test to check the code from issue and compared grads CPU/CUDA

* Fixed static kMaxGridNum evaluation to dynamic

* Fixes Xiao's repro

* Ports nms to use full dispatcher

* Move HIPGuard to nms_cuda

* clang-format

* run models in test_models.py on GPU if available

* Francisco's comment, also disable cuda model tests to see if CPU alone still passes

* cuda tests now pass locally, although still not comparing to saved numerics

* add note for thing to ask francisco

* Allow cuda and cpu tests to share a data file

* ignore suffix if unneeded

* Skip autocast numerics checks for a few models

* Add roi_align test
Co-authored-by: Michael Carilli <mcarilli@nvidia.com>

* Add more tests to NMS

* Fix lint

* feat: Added eps argument to FrozenBatchNorm2d

* test: Added unittest for eps addition in FrozenBatchNorm2d

See #2169

* fix: Reverted forward changes for JIT fuser

* fix: Added back n argument for backward-compatibility

* fix: Fixed FrozenBatchNorm2d forward

Added back eps

* feat: Specified deprecation warnings in FrozenBatchNorm2d

* test: Added unittest for deprecation warninig in FrozenBatchNorm2d

* style: Fixed lint

* style: Fixed block comment lint

* feat: Restored support of tuple of Tensors for roi_align & roi_pool

* test: Added unittest for Tensor sequence support by region pooling

* test: Fixed typo in unittest

* test: Fixed data type

* test: Fixed roi pooling tensor unittest

* test: Fixed box format conversion

* feat: Added number of features in FrozenBatchNorm2d repr

While BatchNorm layers have extensive information in their repr, FrozenBatchNorm2d has one

* refactor: Refactored FrozenBatchNorm2d __repr__

* test: Added unittest for FrozenBatchNorm2d __repr__

* style: Removed blank lines in test_ops

* refactor: Avoids creating an extra attribute for __repr__

* style: Switched __repr__ to f-string

Since support of Python version ealier than 3.6 have been dropped, f-string can be used.

* fix: Fixed typo in __repr__

* style: Switched unittest .format to f-string

* improve stability of test_nms_cuda

This change addresses two issues:

_create_tensors_with_iou() creates test data for the NMS tests. It
takes care to ensure at least one pair of boxes (1st and last) have
IoU around the threshold for the test. However, the constructed
IoU for that pair is _so_ close to the threshold that rounding
differences (presumably) between CPU and CUDA implementations may
result in one suppressing a box in the pair and the other not.
Adjust the construction to ensure the IoU for the box pair is
near the threshold, but far-enough above that both implementations
should agree.

Where 2 boxes have nearly or exactly the same score, the CPU and
CUDA implementations may order them differently. Adjust
test_nms_cuda() to check only that the non-suppressed box lists
include the same members, without regard for ordering.

* adjust assertion in test_nms_cuda

The CPU and CUDA nms implementations each sort the box scores
as part of their work, but the sorts they use are not stable. So
boxes with the same score maybe be processed in opposite order
by the two implmentations.

Relax the assertion in test_nms_cuda (following the model in
pytorch's test_topk()) to allow the test to pass if the output
differences are caused by similarly-scored boxes.

* improve stability of test_nms_cuda

Adjust _create_tensors_with_iou() to ensure we create at least
one box just over threshold that should be suppressed.