1. 07 Apr, 2020 1 commit
  2. 06 Apr, 2020 3 commits
  3. 03 Apr, 2020 5 commits
    • Brian Hart's avatar
      improve stability of test_nms_cuda (#2044) · e61538cb
      Brian Hart authored
      * improve stability of test_nms_cuda
      
      This change addresses two issues:
      
      _create_tensors_with_iou() creates test data for the NMS tests. It
      takes care to ensure at least one pair of boxes (1st and last) have
      IoU around the threshold for the test. However, the constructed
      IoU for that pair is _so_ close to the threshold that rounding
      differences (presumably) between CPU and CUDA implementations may
      result in one suppressing a box in the pair and the other not.
      Adjust the construction to ensure the IoU for the box pair is
      near the threshold, but far-enough above that both implementations
      should agree.
      
      Where 2 boxes have nearly or exactly the same score, the CPU and
      CUDA implementations may order them differently. Adjust
      test_nms_cuda() to check only that the non-suppressed box lists
      include the same members, without regard for ordering.
      
      * adjust assertion in test_nms_cuda
      
      The CPU and CUDA nms implementations each sort the box scores
      as part of their work, but the sorts they use are not stable. So
      boxes with the same score maybe be processed in opposite order
      by the two implmentations.
      
      Relax the assertion in test_nms_cuda (following the model in
      pytorch's test_topk()) to allow the test to pass if the output
      differences are caused by similarly-scored boxes.
      
      * improve stability of test_nms_cuda
      
      Adjust _create_tensors_with_iou() to ensure we create at least
      one box just over threshold that should be suppressed.
      e61538cb
    • Francisco Massa's avatar
      Fix C++ lint (#2059) · 9ed2fa3c
      Francisco Massa authored
      9ed2fa3c
    • gslotman's avatar
      Fix some deprecated warnings (#2055) · 3c2c0022
      gslotman authored
      3c2c0022
    • Francisco Massa's avatar
      Add clang-format to CircleCI (#2057) · d0b32a11
      Francisco Massa authored
      * Add clang-format to CircleCI
      
      * Fix for clang-format version
      
      * Fix lint and remove Travis CI
      
      * Seeing if lost commit comes back
      
      * Fix lint
      
      * Re-enable all tests
      d0b32a11
    • Francisco Massa's avatar
      Add CircleCI job for python lint (#2056) · 0777b51e
      Francisco Massa authored
      * Add CircleCI job for python lint
      
      * Break lint
      
      * Fix
      
      * Fix lint
      
      * Re-enable all tests and remove travis python lint
      0777b51e
  4. 02 Apr, 2020 5 commits
  5. 01 Apr, 2020 4 commits
  6. 31 Mar, 2020 5 commits
    • Negin Raoof's avatar
      ONNX export for variable input sizes (#1840) · 986d2423
      Negin Raoof authored
      
      
      * fixes and tests for variable input size
      
      * transform test fix
      
      * Fix comment
      
      * Dynamic shape for keypoint_rcnn
      
      * Update test_onnx.py
      
      * Update rpn.py
      
      * Fix for split on RPN
      
      * Fixes for feedbacks
      
      * flake8
      
      * topk fix
      
      * Fix build
      
      * branch on tracing
      
      * fix for scalar tensor
      
      * Fixes for script type annotations
      
      * Update rpn.py
      
      * clean up
      
      * clean up
      
      * Update rpn.py
      
      * Updated for feedback
      
      * Fix for comments
      
      * revert to use tensor
      
      * Added test for box clip
      
      * Fixes for feedback
      
      * Fix for feedback
      
      * ORT version revert
      
      * Update ort
      
      * Update .travis.yml
      
      * Update test_onnx.py
      
      * Update test_onnx.py
      
      * Tensor sizes
      
      * Fix for dynamic split
      
      * Try disable tests
      
      * pytest verbose
      
      * revert one test
      
      * enable tests
      
      * Update .travis.yml
      
      * Update .travis.yml
      
      * Update .travis.yml
      
      * Update test_onnx.py
      
      * Update .travis.yml
      
      * Passing device
      
      * Fixes for test
      
      * Fix for boxes datatype
      
      * clean up
      Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
      986d2423
    • Philip Meier's avatar
      Document origin of preprocessing mean / std (#1965) · 504d20c6
      Philip Meier authored
      * guess documentation location
      
      * document mean/std origins
      
      * fix artifact
      
      * update for clarity
      
      * fix typo
      504d20c6
    • Philip Meier's avatar
      Remove python2 compability code (#2033) · 24f16a33
      Philip Meier authored
      * remove sys.version_info == 2
      
      * remove sys.version_info < 3
      
      * remove from __future__ imports
      24f16a33
    • Philip Meier's avatar
      Remove six dependency (#2017) · 42b8d462
      Philip Meier authored
      * remove six from python code
      
      * remove six from setup.py
      
      * remove six from tests
      
      * remove six from references
      
      * remove six from packaging
      
      * revert str to torch._six._string_classes
      
      * revert str to torch._six._string_classes
      42b8d462
    • Brian Johnson's avatar
      Update sphinx theme (#2031) · e1bd43cb
      Brian Johnson authored
      * Update requirements.txt
      
      * Update conf.py
      
      * Update conf.py
      e1bd43cb
  7. 30 Mar, 2020 5 commits
  8. 24 Mar, 2020 3 commits
  9. 23 Mar, 2020 3 commits
  10. 20 Mar, 2020 2 commits
  11. 19 Mar, 2020 1 commit
  12. 17 Mar, 2020 3 commits
    • Tee Jung's avatar
      cc43e0a9
    • NVS Abhilash's avatar
      7a36388c
    • Francisco Massa's avatar
      Update video reader to use new decoder (#1978) · 32e16805
      Francisco Massa authored
      * Base decoder for video. (#1747)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1747
      
      Pull Request resolved: https://github.com/pytorch/vision/pull/1746
      
      Added the implementation of ffmpeg based decoder with functionality that can be used in VUE and TorchVision.
      
      Reviewed By: fmassa
      
      Differential Revision: D19358914
      
      fbshipit-source-id: abb672f89bfaca6351dda2354f0d35cf8e47fa0f
      
      * Integrated base decoder into VideoReader class and video_utils.py (#1766)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1766
      
      Replaced FfmpegDecoder (incompativle with VUE) by base decoder (compatible with VUE).
      Modified python utilities video_utils.py for internal simplification. Public interface got preserved.
      
      Reviewed By: fmassa
      
      Differential Revision: D19415903
      
      fbshipit-source-id: 4d7a0158bd77bac0a18732fe4183fdd9a57f6402
      
      * Optimizating base decoder performance. (#1852)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1852
      
      Changed base decoder internals for a faster clip processing.
      
      Reviewed By: stephenyan1231
      
      Differential Revision: D19748379
      
      fbshipit-source-id: 58a435f0a0b25545e7bd1a3edb0b1d558176a806
      
      * Minor fix and decoder class members access.
      
      Summary:
      Found and fix a bug in cropping algorithm (simple mistyping).
      Also derived classes need access to some decoder class members, like initialization parameters - make it protected.
      
      Reviewed By: stephenyan1231, fmassa
      
      Differential Revision: D19895076
      
      fbshipit-source-id: 691336c8e18526b085ae5792ac3546bc387a6db9
      
      * Added missing header for less dependencies. (#1898)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1898
      
      Include streams/samplers shouldn't depend on decoder headers. Add dependencies directly to the place where they are required.
      
      Reviewed By: stephenyan1231
      
      Differential Revision: D19911404
      
      fbshipit-source-id: ef322a053708405c02cee4562b456b1602fb12fc
      
      * Implemented VUE Asynchronous Decoder
      
      Summary: For Mothership we have found that asynchronous decoder provides a better performance.
      
      Differential Revision: D20026194
      
      fbshipit-source-id: 627b91844b4e3f917002031dd32cb19c239f4ba8
      
      * fix a bug in API read_video_from_memory (#1942)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1942
      
      In D18720474, it introduces a bug in `read_video_from_memory` API. Thank weiyaowang for reporting it.
      
      Reviewed By: weiyaowang
      
      Differential Revision: D20270179
      
      fbshipit-source-id: 66348c99a5ad1f9129b90e934524ddfaad59de03
      
      * extend decoder to support new video_max_dimension argument (#1924)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1924
      
      Extend `video reader` decoder python API in Torchvision to support a new argument `video_max_dimension`. This enables the new video decoding use cases. When setting `video_width=0`, `video_height=0`, `video_min_dimension != 0`, and `video_max_dimension != 0`, we can rescale the video clips so that its spatial resolution (height, width) becomes
       - (video_min_dimension, video_max_dimension) if original height < original width
       - (video_max_dimension, video_min_dimension) if original height >= original width
      
      This is useful at video model testing stage, where we perform fully convolution evaluation and take entire video frames without cropping as input. Previously, for instance we can only set `video_width=0`, `video_height=0`, `video_min_dimension = 128`, which will preserve aspect ratio. In production dataset, there are a small number of videos where aspect ratio is either extremely large or small, and when the shorter edge is rescaled to 128, the longer edge is still large. This will easily cause GPU memory OOM when we sample multiple video clips, and put them in a single minibatch.
      
      Now, we can set (for instance) `video_width=0`, `video_height=0`, `video_min_dimension = 128` and `video_max_dimension = 171` so that the rescale resolution is either (128, 171) or (171, 128) depending on whether original height is larger than original width. Thus, we are less likely to have gpu OOM because the spatial size of video clips is determined.
      
      Reviewed By: putivsky
      
      Differential Revision: D20182529
      
      fbshipit-source-id: f9c40afb7590e7c45e6908946597141efa35f57c
      
      * Fixing samplers initialization (#1967)
      
      Summary:
      Pull Request resolved: https://github.com/pytorch/vision/pull/1967
      
      
      
      No-ops for torchvision diff, which fixes samplers.
      
      Differential Revision: D20397218
      
      fbshipit-source-id: 6dc4d04364f305fbda7ca4f67a25ceecd73d0f20
      
      * Exclude C++ test files
      Co-authored-by: default avatarYuri Putivsky <yuri@fb.com>
      Co-authored-by: default avatarZhicheng Yan <zyan3@fb.com>
      32e16805