GitLab

* WIP

* clang

* docs

* extracted out common utils

* Use better quantization function and pass tensors as parameters

* proper dequantization

* Some tests

* Dequantization optimization, seems to gain a few ms

* clang-format

* again

* more correct test. Had to remove optimization although it almost works

* Also test aligned=True

* remove useless part

* more docs and comments

* Put back optimization with more robust test

* Added check for index upper bound

* avoid possible overflow

* Move common function into common.h

* oops

* scale=1,zero_point=0 makes more sense

* Force batch size of 1 to prevent any indexingbug

* format

* format again

* updated docstring

* put back description comment for pre_calc_bilinear_interpolate

* revert most changes to docstring as it's taken care of in another PR

This reverts commit 3bfdb427.

* minor clean up

* do same for ps_roialign
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Add quantized version of nms

* Added tests

* Compute areas only once

* remove calls to dequantize_val

* fix return type for empty tensor

* flake8

* remove use of scale as it gets cancelled out

* simpler int convertion in tests

* explicitly set ovr to double

* add tests for more values of scale and zero_point

* comment about underflow

* remove unnecessary accessor

* properly convert to float for division

* Add comments about underflow

* explicitely cast coordinates to float to allow vectorization

* clang

* clang  again

* hopefully OK now

* multithreading allowed in stream codec context

* numThreads is passed as a decoder parameter. At this stage code should be unchanged

* enabling multithreading in videoReader API

* moving defaults to header files

* replace long with int64_t because torchscript

* docstring for Num threads

* Enable codec-related heuristics as defaults

* Update torchvision/csrc/io/decoder/stream.cpp
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Fixing build errors

* minor docs

* Linting

* updating defaults for the C++ function calls to be single threaded

* adding special case for single threaded stuff
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Stash commit

* Refactoring the current tests in a simpler file

* Addressing Francisco's comments, attempt 1

* Remove old tests

* audio changes

* adding some comments

* Stash commit

* Refactoring the current tests in a simpler file

* Addressing Francisco's comments, attempt 1

* Remove old tests

* audio changes

* adding some comments

* adding the py39 check stuff
Co-authored-by: Bruno Korbar <korbar@vggdev9.vggdev.cluster>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

* Replace type T with accumulator.

* Upcast tensors of box ops to avoid overflow in multiplications.

* On MSVC, instruct the linker not to drop the _register_ops symbol

* Remove workaround for ops registration on windows
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Summary:
Noticed this copy-paste error while reading D26026259 (https://github.com/pytorch/vision/commit/f16322b596c7dc9e9d67d3b40907694f29e16357) for inspiration to solve a similar problem

Created from Diffusion's 'Open in Editor' feature.

Reviewed By: datumbox

Differential Revision: D26373056

fbshipit-source-id: d67f46243a280e8a59d12bad9dd730c1a3d512c9

* [android] android gradle project for ops

* Change CMakeLists to latest PyTorch

* Use mobilenet_v3 models for detection

Don't need to have two variants of the model anymore, but I'm not removing it for now

* Fix orientation when angle = 0

* [android][test_app] Fix YUV decoding

* Use smaller version of mobilenet model

* Divide inputs by 255 again

* [android] assets mobilenetv3
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Moving jpegcommon inside cpu implementation

* Adding namespaces on image and moving private methods to anonymous.

* Fixing headers.

* Renaming public image methods to match the ones on python.

* Refactoring to remove the double ifs in common_jpeg.h

* Moving registration of video methods in Video.cpp and removing unnecessary includes.

* Rename files according to cpp styles.

* Adding namespaces and moving private methods to anonymous namespaces.

* Syncing method names.

* Fixing minor issues.

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Summary:
Upgrading service to platform009 enforces tls1.3 authentication.
Specify tls cert file to decoder through config.
Context: https://fb.workplace.com/groups/2020511478062223

Differential Revision: D26026259

fbshipit-source-id: e89f88ff7e41ec6b6a62e85d9015d78f6377aa65

The video reader suppressed code 61 (ENODATA on Linux) that occured at
the end of a stream and logged an INFO message. On macOS ENODATA has a
different code (96), which resulted in an error message being logged.

This small patch replaces the hard-coded value with the ENODATA constant
to suppress the macOS warning.
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Adding TORCH_SELECTIVE_* macros on op registration.

* Adding torchvision namespace.

* Update ImageReadMode error messages, add newline at the end of image_read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum

* Update readpng_cpu and readjpeg_cpu error messages

* Update image.py documentation

* Removing VISION_API from backward() methods and adding a ops.h

* Fixing clang format.

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Summary:
* Reduce unnecessary header inclusions in models and io.

* Move autocast to separate folder and hide autograd implementation in an anonymous namespace.

* Moving files in subfolders.

Reviewed By: fmassa

Differential Revision: D25461523

fbshipit-source-id: 756eeb6848aacaa474de4825ed4c1045d17e2cea

* Moving deform_conv2d op registration.

* Moving nms op registration.

* Moving new_empty_tensor op registration.

* Moving ps_roi_align op registration.

* Moving ps_roi_pool op registration.

* Moving roi_align op registration.

* Moving roi_pool op registration.

* Restoring headers for forward/backward and fixing styles.

* Restoring the test hack on windows.

* Stricter header inclusion.

* Encapsulate and standardize deform_conv2d (#3074)

* Rename files.

* Standardizing method names.

* Adding anonymous namespaces.

* Applying C++ naming rules and alinging variable names across headers and cpp files.

* Syncing names across implementations.

* Rename deform_conv2d.h to deform_conv2d.cpp

* Use header files:
- Create header files for kernel implementation and remove definitions from vision_*.h files.
- Eliminate unnecessary headers and ensure all cpp include their headers.

* Change the naming convention for kernel implementations.

* Remove the _param postfix from the variables and standardizing names.

* Exposing public forward/backward methods to the C++ API and moving methods around to minimize git blame changes.

* Encapsulate and standardize nms (#3081)

* Syncing, where possible, the names of functions across devices.

* Adding all internal functions in anonymous namespaces.

* Renaming C++/CUDA kernel files and moving operator code from header to cpp file.

* Create foreach cpp file a separate header file with "public" functions.

* Removing unnecessary repeated includes.

* Update CMakeLists.txt to include all headers.

* Encapsulate and standardize ps_roi_align (#3082)

* Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.
Syncing, where possible, the names of functions across devices.

* Adding all internal functions in anonymous namespaces.

* Renaming C++/CUDA kernel files and moving operator code from header to cpp file.

* Create foreach cpp file a separate header file with "public" functions.

* Removing unnecessary repeated includes.

* Encapsulate and standardize ps_roi_pool (#3084)

* Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.

* Adding all internal functions in anonymous namespaces.

* Renaming C++/CUDA kernel files and moving operator code from header to cpp file.

* Create foreach cpp file a separate header file with "public" functions.

* Removing unnecessary repeated includes.

* Encapsulate and standardize roi_align (#3085)

* Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.

* Adding all internal functions in anonymous namespaces.

* Renaming C++/CUDA kernel files and moving operator code from header to cpp file.

* Create foreach cpp file a separate header file with "public" functions.

* Removing unnecessary repeated includes.

* Encapsulate and standardize roi_pool  (#3088)

* Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.

* Adding all internal functions in anonymous namespaces.

* Syncing variable names between the cpp files and their header files.

* Renaming C++/CUDA kernel files and moving operator code from header to cpp file.

* Create foreach cpp file a separate header file with "public" functions.

* Removing unnecessary repeated includes.

* Encapsulate and standardize new_empty_tensor_op (#3089)

* Renaming C++ files & methods according to recommended naming conventions and aligning them with Python's API.

* Create foreach cpp file a separate header file with "public" functions.

* Adding all internal functions in anonymous namespaces.

* Convert to const ref all possible parameters.

* Removing unnecessary repeated includes.

* Encapsulate and standardize C++ Ops - Clean up (#3094)

* Removing unnecessary repeated includes.

* Remove unnecessary vision_cpu.h, vision_cuda.h, autocast.h.

* Fixing naming convention and correcting method names on macros.

* Turn on clang formatter for cu files and fixing broken styles.

* Replace "#ifndef ... #define ... #endif" with "#pragma once" on header files.

* Adding operator methods in vision::ops namespace. (#3096)

* Adding operator methods in vision::ops namespace.

* Replace general.h with macros.h

* Adding vision.h to the necessary cpp files.

Operator registration of functions with noexcept doesn't work on some compilers, see https://github.com/pytorch/pytorch/issues/48667

* add UUID in LOG() in decoder

* Fix lint

* More lint

Summary:
* Link libav change into fbcode
* Set rw_timeout value

Differential Revision: D23412524

fbshipit-source-id: 5755950be1b1b4c37cb0c3a69a8c875f8862a92c
Co-authored-by: Keyun Tong <ktong@fb.com>

* Fix spelling mistake: orignal -> original

* Spelling fix: orignal -> original
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

* Add support of mode and remove channels.

* Replacing integer mode with define constants.

* Adding output channels implementation for pngs.

* Adding tests for png.

* Adding channels in the API and documentation.

* Fixing formatting.

* Refactoring test_image.py to remove huge grace_hopper_517x606.pth file from assets and reduce duplicate code. Moving jpeg assets used by encode and write unit-tests on their separate folders.

* Adding output channels implementation for jpegs. Fix asset locations.

* Add tests for JPEG, adding the channels in the API and documentation and adding checks for inputs.

* Changing folder for unit-test.

* Fixing windows flakiness, removing duplicate test.

* Replacing components to channels.

* Adding reference for supporting CMYK.

* Minor changes: num_components to output_components, adding comments, fixing variable name etc.

* Reverting output_components to num_components.

* Replacing decoding with generic method on tests.

* Palette converted to Gray.

* Removing python headers and code for Python2 compatibility.

* Restoring python3 inits.

* Add support of different color types in readpng.

* Adding test images and unit-tests.

* Use closest possible type.

* Fix formatting.