Skip to content

GitLab

Unverified Commit 6713f034 authored by moto's avatar moto Committed by GitHub
Browse files

Update unittest and packaging to use UPLOAD_CHANNEL (#2846) (#2848) 


Co-authored-by: default avatarFrancisco Massa <fvsmassa@gmail.com>
parent 34708e4c
Hide whitespace changes
Inline Side-by-side
Showing with 53 additions and 12 deletions
.circleci/config.yml
View file @ 6713f034
...@@ -138,6 +138,7 @@ jobs: ...@@ -138,6 +138,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: packaging/build_wheel.sh - run: packaging/build_wheel.sh
- store_artifacts: - store_artifacts:
path: dist path: dist
...@@ -153,6 +154,7 @@ jobs: ...@@ -153,6 +154,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: packaging/build_conda.sh - run: packaging/build_conda.sh
- store_artifacts: - store_artifacts:
path: /opt/conda/conda-bld/linux-64 path: /opt/conda/conda-bld/linux-64
...@@ -168,6 +170,7 @@ jobs: ...@@ -168,6 +170,7 @@ jobs:
executor: windows-cpu executor: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Build conda packages name: Build conda packages
command: | command: |
...@@ -193,6 +196,7 @@ jobs: ...@@ -193,6 +196,7 @@ jobs:
executor: windows-cpu executor: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Build wheel packages name: Build wheel packages
command: | command: |
...@@ -215,6 +219,7 @@ jobs: ...@@ -215,6 +219,7 @@ jobs:
xcode: "9.4.1" xcode: "9.4.1"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
# Cannot easily deduplicate this as source'ing activate # Cannot easily deduplicate this as source'ing activate
# will set environment variables which we need to propagate # will set environment variables which we need to propagate
...@@ -237,6 +242,7 @@ jobs: ...@@ -237,6 +242,7 @@ jobs:
xcode: "9.4.1" xcode: "9.4.1"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
...@@ -299,6 +305,7 @@ jobs: ...@@ -299,6 +305,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -317,6 +324,7 @@ jobs: ...@@ -317,6 +324,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -337,6 +345,7 @@ jobs: ...@@ -337,6 +345,7 @@ jobs:
image_name: torchvision/smoke_test image_name: torchvision/smoke_test
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Build and push Docker image name: Build and push Docker image
no_output_timeout: "1h" no_output_timeout: "1h"
...@@ -356,6 +365,7 @@ jobs: ...@@ -356,6 +365,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -381,6 +391,7 @@ jobs: ...@@ -381,6 +391,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -404,6 +415,7 @@ jobs: ...@@ -404,6 +415,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -444,6 +456,7 @@ jobs: ...@@ -444,6 +456,7 @@ jobs:
image_name: "pytorch/manylinux-cuda101" image_name: "pytorch/manylinux-cuda101"
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -465,7 +478,7 @@ jobs: ...@@ -465,7 +478,7 @@ jobs:
- env - env
- run: - run:
name: Install torchvision name: Install torchvision
command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/install.sh command: docker run -t --gpus all -v $PWD:$PWD -w $PWD -e UPLOAD_CHANNEL "${image_name}" .circleci/unittest/linux/scripts/install.sh
- run: - run:
name: Run tests name: Run tests
command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh
...@@ -481,6 +494,7 @@ jobs: ...@@ -481,6 +494,7 @@ jobs:
name: windows-cpu name: windows-cpu
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -520,6 +534,7 @@ jobs: ...@@ -520,6 +534,7 @@ jobs:
CUDA_VERSION: "10.1" CUDA_VERSION: "10.1"
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -558,6 +573,7 @@ jobs: ...@@ -558,6 +573,7 @@ jobs:
resource_class: large resource_class: large
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Install wget name: Install wget
command: HOMEBREW_NO_AUTO_UPDATE=1 brew install wget command: HOMEBREW_NO_AUTO_UPDATE=1 brew install wget
...@@ -600,6 +616,7 @@ jobs: ...@@ -600,6 +616,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Setup conda name: Setup conda
command: .circleci/unittest/linux/scripts/setup_env.sh command: .circleci/unittest/linux/scripts/setup_env.sh
...@@ -617,12 +634,13 @@ jobs: ...@@ -617,12 +634,13 @@ jobs:
CU_VERSION: << parameters.cu_version >> CU_VERSION: << parameters.cu_version >>
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Setup conda name: Setup conda
command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> .circleci/unittest/linux/scripts/setup_env.sh command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> .circleci/unittest/linux/scripts/setup_env.sh
- run: - run:
name: Build torchvision C++ distribution and test name: Build torchvision C++ distribution and test
command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> packaging/build_cmake.sh command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -e UPLOAD_CHANNEL -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> packaging/build_cmake.sh
cmake_macos_cpu: cmake_macos_cpu:
<<: *binary_common <<: *binary_common
...@@ -630,6 +648,7 @@ jobs: ...@@ -630,6 +648,7 @@ jobs:
xcode: "9.0" xcode: "9.0"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
...@@ -644,6 +663,7 @@ jobs: ...@@ -644,6 +663,7 @@ jobs:
name: windows-cpu name: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
set -ex set -ex
...@@ -656,6 +676,7 @@ jobs: ...@@ -656,6 +676,7 @@ jobs:
name: windows-gpu name: windows-gpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
set -ex set -ex
......
.circleci/config.yml.in
View file @ 6713f034
...@@ -138,6 +138,7 @@ jobs: ...@@ -138,6 +138,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: packaging/build_wheel.sh - run: packaging/build_wheel.sh
- store_artifacts: - store_artifacts:
path: dist path: dist
...@@ -153,6 +154,7 @@ jobs: ...@@ -153,6 +154,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: packaging/build_conda.sh - run: packaging/build_conda.sh
- store_artifacts: - store_artifacts:
path: /opt/conda/conda-bld/linux-64 path: /opt/conda/conda-bld/linux-64
...@@ -168,6 +170,7 @@ jobs: ...@@ -168,6 +170,7 @@ jobs:
executor: windows-cpu executor: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Build conda packages name: Build conda packages
command: | command: |
...@@ -193,6 +196,7 @@ jobs: ...@@ -193,6 +196,7 @@ jobs:
executor: windows-cpu executor: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Build wheel packages name: Build wheel packages
command: | command: |
...@@ -215,6 +219,7 @@ jobs: ...@@ -215,6 +219,7 @@ jobs:
xcode: "9.4.1" xcode: "9.4.1"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
# Cannot easily deduplicate this as source'ing activate # Cannot easily deduplicate this as source'ing activate
# will set environment variables which we need to propagate # will set environment variables which we need to propagate
...@@ -237,6 +242,7 @@ jobs: ...@@ -237,6 +242,7 @@ jobs:
xcode: "9.4.1" xcode: "9.4.1"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
...@@ -299,6 +305,7 @@ jobs: ...@@ -299,6 +305,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -317,6 +324,7 @@ jobs: ...@@ -317,6 +324,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -337,6 +345,7 @@ jobs: ...@@ -337,6 +345,7 @@ jobs:
image_name: torchvision/smoke_test image_name: torchvision/smoke_test
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Build and push Docker image name: Build and push Docker image
no_output_timeout: "1h" no_output_timeout: "1h"
...@@ -356,6 +365,7 @@ jobs: ...@@ -356,6 +365,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -381,6 +391,7 @@ jobs: ...@@ -381,6 +391,7 @@ jobs:
steps: steps:
- attach_workspace: - attach_workspace:
at: ~/workspace at: ~/workspace
- designate_upload_channel
- run: - run:
name: install binaries name: install binaries
command: | command: |
...@@ -404,6 +415,7 @@ jobs: ...@@ -404,6 +415,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -444,6 +456,7 @@ jobs: ...@@ -444,6 +456,7 @@ jobs:
image_name: "pytorch/manylinux-cuda101" image_name: "pytorch/manylinux-cuda101"
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -465,7 +478,7 @@ jobs: ...@@ -465,7 +478,7 @@ jobs:
- env - env
- run: - run:
name: Install torchvision name: Install torchvision
command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/install.sh command: docker run -t --gpus all -v $PWD:$PWD -w $PWD -e UPLOAD_CHANNEL "${image_name}" .circleci/unittest/linux/scripts/install.sh
- run: - run:
name: Run tests name: Run tests
command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh command: docker run -t --gpus all -v $PWD:$PWD -w $PWD "${image_name}" .circleci/unittest/linux/scripts/run_test.sh
...@@ -481,6 +494,7 @@ jobs: ...@@ -481,6 +494,7 @@ jobs:
name: windows-cpu name: windows-cpu
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -520,6 +534,7 @@ jobs: ...@@ -520,6 +534,7 @@ jobs:
CUDA_VERSION: "10.1" CUDA_VERSION: "10.1"
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Generate cache key name: Generate cache key
# This will refresh cache on Sundays, nightly build should generate new cache. # This will refresh cache on Sundays, nightly build should generate new cache.
...@@ -558,6 +573,7 @@ jobs: ...@@ -558,6 +573,7 @@ jobs:
resource_class: large resource_class: large
steps: steps:
- checkout - checkout
- designate_upload_channel
- run: - run:
name: Install wget name: Install wget
command: HOMEBREW_NO_AUTO_UPDATE=1 brew install wget command: HOMEBREW_NO_AUTO_UPDATE=1 brew install wget
...@@ -600,6 +616,7 @@ jobs: ...@@ -600,6 +616,7 @@ jobs:
resource_class: 2xlarge+ resource_class: 2xlarge+
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Setup conda name: Setup conda
command: .circleci/unittest/linux/scripts/setup_env.sh command: .circleci/unittest/linux/scripts/setup_env.sh
...@@ -617,12 +634,13 @@ jobs: ...@@ -617,12 +634,13 @@ jobs:
CU_VERSION: << parameters.cu_version >> CU_VERSION: << parameters.cu_version >>
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
name: Setup conda name: Setup conda
command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> .circleci/unittest/linux/scripts/setup_env.sh command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> .circleci/unittest/linux/scripts/setup_env.sh
- run: - run:
name: Build torchvision C++ distribution and test name: Build torchvision C++ distribution and test
command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> packaging/build_cmake.sh command: docker run -e CU_VERSION -e PYTHON_VERSION -e UNICODE_ABI -e PYTORCH_VERSION -e UPLOAD_CHANNEL -t --gpus all -v $PWD:$PWD -w $PWD << parameters.wheel_docker_image >> packaging/build_cmake.sh
cmake_macos_cpu: cmake_macos_cpu:
<<: *binary_common <<: *binary_common
...@@ -630,6 +648,7 @@ jobs: ...@@ -630,6 +648,7 @@ jobs:
xcode: "9.0" xcode: "9.0"
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
...@@ -644,6 +663,7 @@ jobs: ...@@ -644,6 +663,7 @@ jobs:
name: windows-cpu name: windows-cpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
set -ex set -ex
...@@ -656,6 +676,7 @@ jobs: ...@@ -656,6 +676,7 @@ jobs:
name: windows-gpu name: windows-gpu
steps: steps:
- checkout_merge - checkout_merge
- designate_upload_channel
- run: - run:
command: | command: |
set -ex set -ex
......
.circleci/unittest/linux/scripts/install.sh
View file @ 6713f034
...@@ -23,7 +23,7 @@ else ...@@ -23,7 +23,7 @@ else
cudatoolkit="cudatoolkit=${version}" cudatoolkit="cudatoolkit=${version}"
fi fi
printf "Installing PyTorch with %s\n" "${cudatoolkit}" printf "Installing PyTorch with %s\n" "${cudatoolkit}"
conda install -y -c pytorch-nightly pytorch "${cudatoolkit}" conda install -y -c "pytorch-${UPLOAD_CHANNEL}" pytorch "${cudatoolkit}"
printf "* Installing torchvision\n" printf "* Installing torchvision\n"
python setup.py develop python setup.py develop
\ No newline at end of file
.circleci/unittest/windows/scripts/install.sh
View file @ 6713f034
...@@ -25,7 +25,7 @@ else ...@@ -25,7 +25,7 @@ else
cudatoolkit="cudatoolkit=${version}" cudatoolkit="cudatoolkit=${version}"
fi fi
printf "Installing PyTorch with %s\n" "${cudatoolkit}" printf "Installing PyTorch with %s\n" "${cudatoolkit}"
conda install -y -c pytorch-nightly pytorch "${cudatoolkit}" conda install -y -c "pytorch-${UPLOAD_CHANNEL}" pytorch "${cudatoolkit}"
printf "* Installing torchvision\n" printf "* Installing torchvision\n"
"$this_dir/vc_env_helper.bat" python setup.py develop "$this_dir/vc_env_helper.bat" python setup.py develop
\ No newline at end of file
packaging/build_cmake.sh
View file @ 6713f034
...@@ -23,7 +23,7 @@ fi ...@@ -23,7 +23,7 @@ fi
setup_visual_studio_constraint setup_visual_studio_constraint
setup_junit_results_folder setup_junit_results_folder
conda install -yq pytorch=$PYTORCH_VERSION $CONDA_CUDATOOLKIT_CONSTRAINT $CONDA_CPUONLY_FEATURE -c pytorch-nightly conda install -yq pytorch=$PYTORCH_VERSION $CONDA_CUDATOOLKIT_CONSTRAINT $CONDA_CPUONLY_FEATURE -c "pytorch-${UPLOAD_CHANNEL}"
TORCH_PATH=$(dirname $(python -c "import torch; print(torch.__file__)")) TORCH_PATH=$(dirname $(python -c "import torch; print(torch.__file__)"))
if [[ "$(uname)" == Darwin || "$OSTYPE" == "msys" ]]; then if [[ "$(uname)" == Darwin || "$OSTYPE" == "msys" ]]; then
......
packaging/pkg_helpers.bash
View file @ 6713f034
...@@ -235,8 +235,7 @@ setup_pip_pytorch_version() { ...@@ -235,8 +235,7 @@ setup_pip_pytorch_version() {
else else
pip_install "torch==$PYTORCH_VERSION$PYTORCH_VERSION_SUFFIX" \ pip_install "torch==$PYTORCH_VERSION$PYTORCH_VERSION_SUFFIX" \
-f "https://download.pytorch.org/whl/${CU_VERSION}/torch_stable.html" \ -f "https://download.pytorch.org/whl/${CU_VERSION}/torch_stable.html" \
-f "https://download.pytorch.org/whl/test/${CU_VERSION}/torch_test.html" \ -f "https://download.pytorch.org/whl/${UPLOAD_CHANNEL}/${CU_VERSION}/torch_${UPLOAD_CHANNEL}.html"
-f "https://download.pytorch.org/whl/nightly/${CU_VERSION}/torch_nightly.html"
fi fi
} }
...@@ -261,7 +260,7 @@ setup_conda_pytorch_constraint() { ...@@ -261,7 +260,7 @@ setup_conda_pytorch_constraint() {
exit 1 exit 1
fi fi
else else
export CONDA_CHANNEL_FLAGS="-c pytorch -c pytorch-nightly -c pytorch-test" export CONDA_CHANNEL_FLAGS="-c pytorch -c pytorch-${UPLOAD_CHANNEL}"
fi fi
if [[ "$CU_VERSION" == cpu ]]; then if [[ "$CU_VERSION" == cpu ]]; then
export CONDA_PYTORCH_BUILD_CONSTRAINT="- pytorch==$PYTORCH_VERSION${PYTORCH_VERSION_SUFFIX}" export CONDA_PYTORCH_BUILD_CONSTRAINT="- pytorch==$PYTORCH_VERSION${PYTORCH_VERSION_SUFFIX}"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment