1. 02 Sep, 2024 1 commit
  2. 02 Jun, 2022 1 commit
    • moto's avatar
      Remove mad (#2428) · d2ecba98
      moto authored
      Summary:
      Remove the code related to libmad, which had been disabled in https://github.com/pytorch/audio/issues/2354
      
      In https://github.com/pytorch/audio/issues/2419, we mp3 decoding to ffmpeg. But CI tests were still using libmad.
      This commit completely removes libmad from torchaudio.
      
      This is BC-breaking change as `apply_sox_effects_file` function cannot handle MP3, and it cannot fallback to ffmpeg.
      The workaround for this is to use `torchaudio.load` then `apply_sox_effects_tensor`.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2428
      
      Reviewed By: carolineechen
      
      Differential Revision: D36851805
      
      Pulled By: mthrok
      
      fbshipit-source-id: f98795c59a1ac61cef511f2bbeac37f7c3c69d55
      d2ecba98
  3. 28 Apr, 2022 1 commit
  4. 01 Apr, 2022 1 commit
    • moto's avatar
      Update GNU config files to support `arm64-apple` system (#2307) · 3ed39e15
      moto authored
      Summary:
      This commit
      1. Updates the config.guess and config.sub files and
      2. applies them to all the third party libraries that use them.
      
      This resolves the following build failure on M1 mac with newer SDK.
      
      On MacBookPro with M1 chip, with the recent OS update, something
      about the development environment has been changed (probably newer
      version of XCode) and the build stopeed working with the following
      errors from third party dependencies.
      
      ```
      checking build system type... Invalid configuration ‘arm64-apple-darwin20.0.0': machine ‘arm64-apple' not recognized
      ```
      
      note: config files are taken from https://www.gnu.org/software/gettext/manual/html_node/config_002eguess.html
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2307
      
      Reviewed By: nateanl
      
      Differential Revision: D35318273
      
      Pulled By: mthrok
      
      fbshipit-source-id: 746ac51dd1816767aa78b88445f76a29acfd29e8
      3ed39e15
  5. 04 Jan, 2022 1 commit
    • moto's avatar
      [CI] Install tools from conda instead of brew (#1873) · df0175e8
      moto authored
      Summary:
      Currently, macOS CI jobs install `pkg-config` and `wget` with `brew`.
      This is problematic as brew takes a long time with auto-update, and disabling the auto-update is not an ideal solution.
      Conda also distributes these packages, so switching to conda.
      
      Example issues with brew installation.
      https://app.circleci.com/pipelines/github/pytorch/audio/7825/workflows/53965bcf-6ddf-4e42-ad52-83fd1bbab717
      
      This commit removes the use of `brew` by
      1. Replacing the use of `wget` with `curl` (pre-installed in most distro)
      2. Install `pkg-condig` from conda.
          Note: All the macOS jobs, including binary build jobs, uses conda. Using `pkg-config` from Conda makes it easy to discover the packages installed from conda. (like `ffmpeg` in https://github.com/pytorch/audio/issues/2122)
      3. Add `pkg-config` to conda build-time dependency
      4. Make sure that the availability of `pkg-config` is explicitly checked when `sox` is being configured. (otherwise, it will fail at somewhere in the middle of build process with somewhat unintuitve error message)
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/1873
      
      Reviewed By: carolineechen, nateanl
      
      Differential Revision: D33404975
      
      Pulled By: mthrok
      
      fbshipit-source-id: ae512d3a3a422ebfe3b46c492bed44deecc36e72
      df0175e8
  6. 20 Dec, 2021 1 commit
    • moto's avatar
      Standardize the location of third-party source code (#2086) · 2476dd2d
      moto authored
      Summary:
      Previously sox-related third-party source code was archived at
      `third_party/sox/archives`.
      Recently KenLM-related third-party source code was added and
      they are archived at `third_party/archives`.
      
      This PR changes the sox archive location to `third_party/archives`,
      so that all the archvies are cached at the same location.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2086
      
      Reviewed By: carolineechen
      
      Differential Revision: D33236927
      
      Pulled By: mthrok
      
      fbshipit-source-id: 2f2aa5f4b386fefb46d7c98f7179c04995219f3c
      2476dd2d
  7. 28 Jun, 2021 1 commit
  8. 25 May, 2021 1 commit
  9. 19 Apr, 2021 1 commit
  10. 23 Feb, 2021 1 commit
  11. 04 Feb, 2021 1 commit
  12. 21 Jan, 2021 1 commit
  13. 09 Jan, 2021 1 commit