GitLab

`SOX_SIGNED_16BIT_TO_SAMPLE` and `SOX_SIGNED_32BIT_TO_SAMPLE` uses left shift on signed integers, (negative values) which is UB.
This PR replaces them (and other sox macros for `uint8` and `float` as well) with Tensor operations.

Some audio formats like `gsm` does not have valid frame numbers when opened. But `libsox` can properly handle these audios, so checking if `length > 0` is not necessary and too strict.

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/51319



We were going out of our way to accommodate `IValue::to<Tensor>` returning a copy of the inner Tensor. `IValue::toTensor` is capable of returning a reference without copying, so if we use it directly, we can allow kernels that want to take `Tensor &` to do so!
As a bonus, we get reduced build times.
ghstack-source-id: 121378961

Reviewed By: bhosmer

Differential Revision: D26138549

fbshipit-source-id: b0f830527da360c542c815bef2f7e1692615b32a
Co-authored-by: Scott Wolchok <swolchok@fb.com>

After a9f5e7229 was merged into upstream pytorch the passing of
references within torch c extension functions is no longer allowed. This
just removes the reference and passes by value instead.
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

* Distinguish get_encodinginfo for Tensor I/O and save output

* Isolate get_tensor_encodinginfo so as not to use the same helper function

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

Co-authored-by: Prabhat Roy <prabhatroy@fb.com>

[`sox_format_t.tell_off`](https://fossies.org/dox/sox-14.4.2/structsox__format__t.html#a2016a9fa839f3139e3c2f64381b0c445) should be representing current offset in file, but there are cases it does not. This was causing segmentation fault in some cases. This PR fixes it by replacing it with `ftell` call and add extra check so that if the same thing should happen, it will throw runtime error instead of segmentation fault.

fix 'file-does-not-end-in-newline' and typo.

* Support file-like object in save func

* Disable CircleCI cache for TP artifacts for cleaner build