GitLab

* formatting.

* update datasets.

* Add safeguard to SoX initialization/shutdown

* Initialize SoX automatically when it's needed

Nightly smoke test is failing for Python 3.8 as conda environment does not exist.

* wip

* Add test

* add caching

* fixup! add caching

* fixup! fixup! add caching

* Add overdrive to functional

* Minor change to overdrive

* Minor change to overdrive

* minor flake8 changes

* changes to make overdrive generic
Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com>

* fix inline typing for mypy

* fix flake8

* change check position

* fix for py3.5

* fix for py3.5

* change to inline typing

* add inline typing

* add checksums

* checksum function changes

* function Docstring change

* checksums moved to Dataset Modules

Before

Total time: 13.7078

```
   722|    220501|      2.44247|  1.10769e-05| 17.82%|    for i_sample, o0 in enumerate(input_signal_windows.t()):
(call)|         1|  6.36578e-05|  6.36578e-05|  0.00%|# /scratch/moto/pytorch/torch/tensor.py:460 __iter__
(call)|    220500|      1.60566|  7.28191e-06| 11.71%|# /scratch/moto/pytorch/torch/tensor.py:474 <lambda>
   723|    220500|      1.86697|  8.46698e-06| 13.62%|        windowed_output_signal = padded_output_waveform[:, i_sample:(i_sample + n_order)]
   724|    220500|      1.94628|  8.82669e-06| 14.20%|        o0.addmv_(windowed_output_signal, a_coeffs_flipped, alpha=-1)
   725|    220500|         2.46|  1.11565e-05| 17.94%|        o0.div_(a_coeffs[0])
   726|         0|            0|            0|  0.00%|
   727|    220500|      3.37869|  1.53229e-05| 24.64%|        padded_output_waveform[:, i_sample + n_order - 1] = o0
```

After

Total time: 10.9667

```
   722|         1|   9.2268e-05|   9.2268e-05|  0.00%|    input_signal_windows.div_(a_coeffs[0])
   723|         1|  2.14577e-05|  2.14577e-05|  0.00%|    a_coeffs_flipped.div_(a_coeffs[0])
   724|    220501|      2.40216|  1.08941e-05| 21.90%|    for i_sample, o0 in enumerate(input_signal_windows.t()):
(call)|         1|  5.84126e-05|  5.84126e-05|  0.00%|# /scratch/moto/pytorch/torch/tensor.py:460 __iter__
(call)|    220500|      1.59821|   7.2481e-06| 14.57%|# /scratch/moto/pytorch/torch/tensor.py:474 <lambda>
   725|    220500|      1.82273|  8.26633e-06| 16.62%|        windowed_output_signal = padded_output_waveform[:, i_sample:(i_sample + n_order)]
   726|    220500|      1.84074|  8.34802e-06| 16.78%|        o0.addmv_(windowed_output_signal, a_coeffs_flipped, alpha=-1)
   727|    220500|       3.2952|  1.49442e-05| 30.05%|        padded_output_waveform[:, i_sample + n_order - 1] = o0
```

* Add dcshift to functional

* Doc string change and remove inplace clamp

* Minor Fix to dcshit and separate sox test refactoring

* Minor change to limiter_gain type

* adding dcshift to __all__ in functional

* add cmvn

* Update transforms.rst

add cmvn

* Correct the format

* Correct the format

* Correct the format

* add test unit and cmvn change to cmn

* fix bug
Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com>

* Add contrast to functional

* add tests for contrast and update functional.rst

* Minor changes to sox and batch tests for contrast

This PR aims the following things;
1. Introduce and adopt helper function `get_asset_path` that abstract the logic to construct path to test assets.
2. Remove `create_temp_assets_dir` anywhere except `test_io`.

The benefits of doing so are,
a. the test code becomes simpler (no manual construction of asset path with `os.path.join`)
b. No unnecessary directory creation and file copies.

For 2. and b. tests in `test_io.py` (or tests that use `torchaudio.save`) are the only tests that need to write file to the disc, where the use of temporary directory makes it cleaner, therefore, `create_temp_assets_dir` is not necessary elsewhere. (still, `test_io` does not need to copy the entire asset directory, but that's not the point here.)

Also if any test is accidentally overwriting an asset data, not using a copy will make us aware of such behavior, so it is better to get rid of `create_temp_assets_dir`.

This lfilter tests were moved to `test_torchscript_consistency.py` in #507 and GPU tests were added in #528.
We can safely remove this tests from `test_functional_filtering.py`.

* inline typing first iteration

* fix issue with mypy

* change docstring

* add more typing

* fix to not break BC

* update docstrings

* Update requirements and travis installation

* Drop support for 3.5 and add test for 3.8

* Call torch.stft directly

* Update requirements and travis installation

* Drop support for 3.5 and add test for 3.8

* Make test module name descriptive

* Rename test_functional_filtering to test_sox_compatibility

* Separate CPU and GPU tests for functions torchscript test

* fix indentation
Co-authored-by: Vincent QB <vincentqb@users.noreply.github.com>

* add inline typing

* fix error

* minor change

* minor fix