1. 16 Apr, 2020 1 commit
  2. 14 Apr, 2020 1 commit
    • moto's avatar
      Simplify and abstract away asset access in test (#542) · 0e5581cb
      moto authored
      This PR aims the following things;
      1. Introduce and adopt helper function `get_asset_path` that abstract the logic to construct path to test assets.
      2. Remove `create_temp_assets_dir` anywhere except `test_io`.
      
      The benefits of doing so are,
      a. the test code becomes simpler (no manual construction of asset path with `os.path.join`)
      b. No unnecessary directory creation and file copies.
      
      For 2. and b. tests in `test_io.py` (or tests that use `torchaudio.save`) are the only tests that need to write file to the disc, where the use of temporary directory makes it cleaner, therefore, `create_temp_assets_dir` is not necessary elsewhere. (still, `test_io` does not need to copy the entire asset directory, but that's not the point here.)
      
      Also if any test is accidentally overwriting an asset data, not using a copy will make us aware of such behavior, so it is better to get rid of `create_temp_assets_dir`.
      0e5581cb
  3. 07 Apr, 2020 1 commit
  4. 06 Apr, 2020 2 commits
    • moto's avatar
      Use torch.testing.assert_allclose (#513) · 5f5df1d6
      moto authored
      * grep -l 'torch.allclose' -r test | xargs sed -i 's/assert torch.allclose/torch.testing.assert_allclose/g'
      
      * grep -l 'torch.allclose' -r test | xargs sed -i 's/self.assertTrue(torch.allclose(\(.*\)))/torch.testing.assert_allclose(\1)/g'
      
      * Fix missing atol/rtol, wrong shape, argument order. Remove redundant shape assertions
      5f5df1d6
    • moto's avatar
      Simplify helper function (#514) · bc1ffb11
      moto authored
      bc1ffb11
  5. 03 Apr, 2020 4 commits
  6. 02 Apr, 2020 1 commit