Skip to content

GitLab

Switch branch/tag
  1. 29 Aug, 2023 2 commits
  3. 23 Aug, 2023 1 commit
  5. 21 Aug, 2023 2 commits
  7. 20 Aug, 2023 3 commits
    • moto's avatar
      Fix I/O test (#3568) · 0688863c
      moto authored 
      Summary:
Turned out FFmpeg 5 installed via conda reports video frame rate -1. FFmpeg 4 and 6 are fine. This is either a regression in FFmpeg or in the underlying decoding library.

Make the reference value adoptive.

Pull Request resolved: https://github.com/pytorch/audio/pull/3568

Reviewed By: huangruizhe

Differential Revision: D48499621

Pulled By: mthrok

fbshipit-source-id: fb64187bcf0dc57b753cb6c05f04d436238f5c51
      0688863c
    • moto's avatar
      Fix style check CI job (#3564) · a5da0a28
      moto authored 
      Summary:
It seems that the default Python version was updated to 3.11.
libcst does not have binary release for 3.11, so the CI attempts to
build from source but it fails because building libcst requires Rust
compiler.

This commit fix the Python version of style check job to 3.10 so that
the issue with Rust compiler is avoided.

Pull Request resolved: https://github.com/pytorch/audio/pull/3564

Reviewed By: huangruizhe

Differential Revision: D48499560

Pulled By: mthrok

fbshipit-source-id: 53ab77268d8143f4946d92e8cd1f96aea55e7b72
      a5da0a28
    • moto's avatar
      Add detail about CTC peaky behavior (#3566) · a25bcb6b
      moto authored 
      Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/3566

Reviewed By: huangruizhe

Differential Revision: D48499338

Pulled By: mthrok

fbshipit-source-id: 7f837e1a1f8116d7d82411607c91628b729077d8
      a25bcb6b
  9. 19 Aug, 2023 1 commit
  11. 18 Aug, 2023 1 commit
    • moto's avatar
      Update README.md (#3567) · 1638efee
      moto authored 
      Summary:
Remove mention of backend and quick usage. Those are explained in the documentation in detail.

Pull Request resolved: https://github.com/pytorch/audio/pull/3567

Reviewed By: huangruizhe

Differential Revision: D48471832

Pulled By: mthrok

fbshipit-source-id: 467efc1f11f66534c33cf4751de27b08176c31bf
      1638efee
  13. 15 Aug, 2023 2 commits
    • Andrey Talman's avatar
      Use pytorch/manylinuxaarch64-builder:cpu-aarch64 docker image (#3560) · 126f9f6c
      Andrey Talman authored 
      Summary:
Use pytorch/manylinuxaarch64-builder:cpu-aarch64

Introduced in https://github.com/pytorch/builder/pull/1472

Pull Request resolved: https://github.com/pytorch/audio/pull/3560

Reviewed By: mthrok

Differential Revision: D48366572

Pulled By: atalman

fbshipit-source-id: 6de15f81abb09c737e6a1271226259483141e8f4
      126f9f6c
    • moto's avatar
      [BC-breaking] Update pre-built ffmpeg4 to 4.4.4 (#3561) · bf07ea6b
      moto authored 
      Summary:
In https://github.com/pytorch/audio/pull/3460, we switched the build process for FFmpeg extension.
Since it is complicated to install FFmpeg in some environments, at build time, pre-built binaries and its headers
are downloaded and used as a scaffolding for torchaudio build.

Now even though we did not change any code or FFmpeg version, it turned out that this causes segmentation
fault on Ubuntu when using system Python and FFmpeg 4.4 installed via aptitude.
While investigating the issue, I swapped the said pre-built FFmpeg scaffolding with FFmpeg 4.4 from aptitude,
and the segmentation fault did not happen. This indicates that it is binary compatibility issue.

Before https://github.com/pytorch/audio/issues/3460, each binary build job was building FFmpeg 4.1.8 using the same compiler used to build torchaudio,
but after https://github.com/pytorch/audio/issues/3460 the environments to build FFmpeg 4.1.8 and torchaudio are different. My hypothesis is that
this difference is causing some ABI incompatibility when linking against FFmpeg 4.4. (Also, I don't remember well,
but I read somewhere that 4.4 has a different ABI)

Through experiments, it turned out upgrading the pre-built FFmpeg scaffolding to 4.4 resolves this.
So this commit upgrade the pre-built FFmpeg 4 to 4.4.
The potential (yet unconfirmed) downside is that torchaudio will no longer work with 4.1, 4.2, and 4.3.
Since FFmpeg 4.4 is what Ubuntu 20.04 and 22.04 support by default, and Google Colab is also on 20.04,
I think it is more important to support 4.4.

Therefore we drop the support for 4.1-4.3 from normal build (and official distributions). Those who wish to
use 4.1-4.3 can build torchaudio from source by linking to specific FFmpeg.

Pull Request resolved: https://github.com/pytorch/audio/pull/3561

Reviewed By: hwangjeff

Differential Revision: D48340201

Pulled By: mthrok

fbshipit-source-id: 7ece82910f290c7cf83f58311c4cf6a384e8795e
      bf07ea6b
  15. 14 Aug, 2023 5 commits
  17. 11 Aug, 2023 3 commits
  19. 10 Aug, 2023 6 commits
  21. 09 Aug, 2023 1 commit
  23. 08 Aug, 2023 6 commits
  25. 07 Aug, 2023 4 commits
  27. 04 Aug, 2023 2 commits
  29. 03 Aug, 2023 1 commit