1. 28 Jul, 2022 1 commit
    • moto's avatar
      Migrate CTC decoder code (#2580) · 39b6343d
      moto authored
      Summary:
      This commit gets rid of our copy of CTC decoder code and
      replace it with upstream Flashlight-Text repo.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2580
      
      Reviewed By: carolineechen
      
      Differential Revision: D38244906
      
      Pulled By: mthrok
      
      fbshipit-source-id: d274240fc67675552d19ff35e9a363b9b9048721
      39b6343d
  2. 19 Jul, 2022 1 commit
    • moto's avatar
      Remove boost (#2552) · ee631d6b
      moto authored
      Summary:
      After reviewing the code for KenLM it turned out that we can build it without boost.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2552
      
      Reviewed By: xiaohui-zhang
      
      Differential Revision: D37949699
      
      Pulled By: mthrok
      
      fbshipit-source-id: 4a4ffae4220d0b764b53f52b93040670d91a84a3
      ee631d6b
  3. 28 Apr, 2022 1 commit
  4. 22 Mar, 2022 1 commit
    • moto's avatar
      Revise the parameterization of third party libraries (#2282) · 7444f568
      moto authored
      Summary:
      Originally, the global property TORCHAUDIO_THIRD_PARTIES was introduced
      to handle the optional third party dependencies that can change based on
      the build config.
      
      After revising the CMake, it turned out this is not really necessary,
      as our torchaudio/csrc/CMakeLists.txt properly branches out for
      conditional dependencies. Rather we should leave the global scope untouched.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2282
      
      Reviewed By: hwangjeff
      
      Differential Revision: D35059838
      
      Pulled By: mthrok
      
      fbshipit-source-id: ed3557eaa9a669e4466d64893beab5089eca78b8
      7444f568
  5. 15 Feb, 2022 1 commit
    • moto's avatar
      Improve ffmpeg library discovery (#2204) · 963905e4
      moto authored
      Summary:
      This commit fixes the issue with ffmpeg discovery at build time.
      The original implementation had issues like.
      
      1. Wrong usage of FindFFMPEG, which caused mixture of ffmpeg libraries from system directory and user directory.
      2. The optional `FFMPEG_ROOT` variable was not set within cmake.
      
      The issue 1 is problematic when a user does not have a permission to
      modify the environment. For example, an old version of ffmpeg, which is
      installed in a directory managed by the system (such as `/usr/local/lib`),
      then there is no way to specify a path in which user installs a supported version
      of ffmpeg.
      
      This commit changes the behavior by first searching the library
      in `FFMPEG_ROOT` environment variables, then
      resorting to the original behavior of searching the custom paths with
      system default path.
      
      Also this commirt removes support for `libavresample`, which is deprecated in
      ffmpeg 4 and removed in ffmpeg 5.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2204
      
      Reviewed By: carolineechen
      
      Differential Revision: D34225769
      
      Pulled By: mthrok
      
      fbshipit-source-id: 95b0bfaaef31e2e69e6df29f789010f48a48210b
      963905e4
  6. 05 Jan, 2022 1 commit
    • moto's avatar
      Update ffmpeg discovery logic (#2124) · d8a65450
      moto authored
      Summary:
      Update ffmpeg discovery logic
      
      Previously the build process used pkg-config to locate
      an installation of ffmpeg, which does not work well Windows/CentOS.
      
      This commit update the discovery process to use the custom
      FindFFMPEG.cmake adopted from Kitware/VTK repository with addition of
      conda environment.
      
       The custom discovery logic can support Windows and CentOS.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2124
      
      Reviewed By: carolineechen
      
      Differential Revision: D33429564
      
      Pulled By: mthrok
      
      fbshipit-source-id: 6cb50c1d8c58f51e0f3f3af5c5b541aa3a699bba
      d8a65450
  7. 30 Dec, 2021 2 commits
    • moto's avatar
      Build ffmpeg-features in Linux/macOS unittests (#2114) · 9f14fa63
      moto authored
      Summary:
      Preparation to land Python front-end of ffmpeg-related features.
      
      - Set BUILD_FFMPEG=1 in Linux/macOS unit test jobs
      - Install ffmpeg and pkg-config from conda-forge
      - Add note about Windows build process
      - Temporarily avoid `av_err2str`
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2114
      
      Reviewed By: hwangjeff
      
      Differential Revision: D33371346
      
      Pulled By: mthrok
      
      fbshipit-source-id: b0e16a35959a49a2166109068f3e0cbbb836e888
      9f14fa63
    • moto's avatar
      Add a switch to build ffmpeg binding (#2048) · ece03edc
      moto authored
      Summary:
      This PR adds `BUILD_FFMPEG` switch to torchaudio build process so that features related to ffmpeg are built.
      The flag is false by default, so no CI jobs or development flow are affected.
      
      This is because handling the dependencies around ffmpeg is a bit tricky.
      Currently, the CMake file uses `pkg-config` to find an ffmpeg installation in the system.
      This works fine for both conda-based installation and system-managed installation (like `apt`).
      
      In subsequent PRs, I will find a solution that works for local development and binary distributions.
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2048
      
      Reviewed By: hwangjeff, nateanl
      
      Differential Revision: D33367260
      
      Pulled By: mthrok
      
      fbshipit-source-id: 94517acecb62bd6d4e96d4b7cbc3ab3c2a25706c
      ece03edc
  8. 18 Dec, 2021 1 commit
  9. 17 Dec, 2021 1 commit
    • moto's avatar
      Add static build of KenLM (#2076) · adc559a8
      moto authored
      Summary:
      Add KenLM and its dependencies required for static build (`zlib`, `bzip2`, `lzma` and `boost-thread`).
      
      The KenLM and its dependencies are build but since no corresponding code on torchaudio side is changed, the resulting torchaudio extension module is not changed. (therefore, as long as build process passes on CI this PR should be good to go.)
      
      Pull Request resolved: https://github.com/pytorch/audio/pull/2076
      
      Reviewed By: carolineechen
      
      Differential Revision: D33189980
      
      Pulled By: mthrok
      
      fbshipit-source-id: 6096113128b939f3cf70990c99aacc4aaa954584
      adc559a8
  10. 30 Apr, 2021 1 commit
  11. 02 Mar, 2021 1 commit
  12. 09 Feb, 2021 1 commit
  13. 04 Feb, 2021 1 commit
  14. 09 Jan, 2021 2 commits
  15. 05 Jan, 2021 2 commits
  16. 22 Dec, 2020 1 commit
  17. 08 Dec, 2020 1 commit
  18. 04 Dec, 2020 1 commit
  19. 20 Nov, 2020 1 commit
    • moto's avatar
      Temporarily Disable OpenMP support for libsox (#1026) · 75804859
      moto authored
      Currently `libsox` on Linux is compiled with GPU OpenMP and it interferes with the version PyTorch uses (Intel in case of binary distribution). This PR disables OpenMP support for `libsox`, while we investigate the way to use the same OpenMP as PyTorch's version.
      75804859
  20. 01 Jul, 2020 2 commits