Skip to content

GitLab

Switch branch/tag
  1. 09 Dec, 2022 2 commits
    • Moto Hira's avatar
      Fix wrong frame allocation in StreamWriter (#2905) · 3518df48
      Moto Hira authored 
      Summary:
Pull Request resolved: https://github.com/pytorch/audio/pull/2905

In StreamWriter, if the tensor format is different from the encoding format, then a FilterGraph object is automatically inserted to convert the format.

The FilterGraph object operates on AVFrames. The input AVFrame must be allocated by us, but the output AVFrames is filled by FilterGraph, thus no need to allocate it.

Now the output AVFrame is used as input to encoder regardless of whether FilterGraph was inserted. Thus the output AVFrame has to be manually allocated by us when FilterGraph is not used.

The current code flips this condition and incorrectly allocates AVFrame when FilterGraph is present and does not allocate otherwise.

This commit fix that.

Reviewed By: xiaohui-zhang

Differential Revision: D41866198

fbshipit-source-id: 40799c147dc8166a979ecfb58ed8e502539a6aed
      3518df48
    • atalman's avatar
      Toggle on/off ffmpeg test if needed (#2901) · ccda545c
      atalman authored 
      Summary:
Toggle on/off ffmpeg test if needed
By default it ON, hence should not affect any current tests.
To toggle ON no change required.
To toggle OFF use:
```
smoke_test.py --no-ffmpeg
```

To be used when calling from builder currently. Since we do not install ffmpeg currently.

Pull Request resolved: https://github.com/pytorch/audio/pull/2901

Reviewed By: carolineechen, mthrok

Differential Revision: D41874976

Pulled By: atalman

fbshipit-source-id: c57b19f37c63a1f476f93a5211550e980e67d9c7
      ccda545c
  3. 08 Dec, 2022 4 commits
  5. 07 Dec, 2022 3 commits
  7. 06 Dec, 2022 1 commit
  9. 04 Dec, 2022 1 commit
  11. 02 Dec, 2022 1 commit
  13. 30 Nov, 2022 2 commits
  15. 29 Nov, 2022 5 commits
  17. 28 Nov, 2022 3 commits
  19. 19 Nov, 2022 1 commit
  21. 18 Nov, 2022 2 commits
  23. 17 Nov, 2022 4 commits
  25. 16 Nov, 2022 2 commits
  27. 15 Nov, 2022 3 commits
  29. 14 Nov, 2022 2 commits
  31. 13 Nov, 2022 1 commit
  33. 11 Nov, 2022 1 commit
    • DanilBaibak's avatar
      Add nova workflow for MacOS and Linux (#2800) · eabf1a13
      DanilBaibak authored 
      Summary:
Added missed build workflows for MacOS and Linux:

- [x] Linux conda
- [x] MacOS conda

This does not change the existing builds/uploads in CircleCI, and should not break any existing jobs/workflows. This is just to add back workflows for the MacOS and Linux conda builds with Nova.

We will create a workflow (most likely in test-infra) that does this comparison between the binaries to ensure there is parity between the binaries before we start uploading with Nova.

Pull Request resolved: https://github.com/pytorch/audio/pull/2800

Reviewed By: osalpekar

Differential Revision: D41181467

Pulled By: DanilBaibak

fbshipit-source-id: a5c5d4dcfdd778b4045203f6016c20fb42daa01b
      eabf1a13
  35. 10 Nov, 2022 2 commits
    • moto's avatar
      Fix the handling of discard_before_pts (#2841) · 4e309734
      moto authored 
      Summary:
Currently `discard_before_pts=-1` is used to indicate no AVFrame should be skipped. It was reported that some corrupted video can have constant negative pts value.

It is technically UB for such corrupted data, but still all the AVFrame should be decoded as long as `seek` is not used.

This commit changes the decoder so that it processes AVFrame if `discard_before_pts==-1` disregard of AVFrame::pts value.

Pull Request resolved: https://github.com/pytorch/audio/pull/2841

Reviewed By: hwangjeff

Differential Revision: D41174442

Pulled By: mthrok

fbshipit-source-id: e9d2fab4b0e2bc47146eda8e1dd377a74c087590
      4e309734
    • Omkar Salpekar's avatar
      [Nova] Add M1 Wheels Build (#2839) · 15f76b0b
      Omkar Salpekar authored 
      Summary:
Adding Nova Reusable Workflow for M1 Wheels Build. Once this has been running well for a while, we can replace the old `build-m1-binaries.yml` workflow.

Pull Request resolved: https://github.com/pytorch/audio/pull/2839

Reviewed By: DanilBaibak

Differential Revision: D41195316

Pulled By: osalpekar

fbshipit-source-id: f3754043f384b1645e5fcfaebf465f6839f72461
      15f76b0b