GitLab

Summary:
[Nova] Add cache ffmpeg before building - 2
Follow up after https://github.com/pytorch/audio/pull/3417, need to pass new arguments to test-infra workflows

Pull Request resolved: https://github.com/pytorch/audio/pull/3423

Reviewed By: mthrok

Differential Revision: D46559344

Pulled By: atalman

fbshipit-source-id: fa5cccc3bfb052688de4a05cc3b4f37fcbe3a6f5

Summary:
- Moving the unit test scripts from .circleci to .github
- Remove docker file for unit test base
- Use the Conda from Docker image in Linux jobs.

Remaining follow-up items

- Reuse the unittest script in Linux GPU job like done in Linux CPU job.

The unit test script needs to be fixed to be used for Linux GPU job
in new GHA workflow. Keeping it as a separate follow-up work item.

Pull Request resolved: https://github.com/pytorch/audio/pull/3407

Differential Revision: D46498263

Pulled By: mthrok

fbshipit-source-id: d8256717a55bb4257151d819d3b2ebd453601eac

Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/3414

Differential Revision: D46536717

Pulled By: mthrok

fbshipit-source-id: 505bdcdd1b59ca9fe5afc2c8516a0a821e2b8d7e

Summary:
[Nova] Add cache ffmpeg before building

Pull Request resolved: https://github.com/pytorch/audio/pull/3417

Reviewed By: mthrok

Differential Revision: D46537892

Pulled By: atalman

fbshipit-source-id: 9f8dc0ecfc305c3b378557d46f89a5d7de67a165

Summary:
We are using Project Nova workflows now. These are not required.

Same as: https://github.com/pytorch/vision/pull/7656

Pull Request resolved: https://github.com/pytorch/audio/pull/3409

Reviewed By: mthrok

Differential Revision: D46494331

Pulled By: atalman

fbshipit-source-id: a642ae55b75482918e0afb7c55dc876bc8356e70

Summary:
Introducing the stylecheck job on Nova. It seems like it is failing on trunk, but the functionality of this job itself is working and it fails with the same error as it does on trunk with CCI.

Pull Request resolved: https://github.com/pytorch/audio/pull/3390

Reviewed By: mthrok

Differential Revision: D46324223

Pulled By: osalpekar

fbshipit-source-id: 1324202e53569d610559ef6f1b90cb5c364e6909

Summary:
See title. If all is well, we can deprecate the CCI job in a few days.

Pull Request resolved: https://github.com/pytorch/audio/pull/3341

Reviewed By: mthrok

Differential Revision: D46324265

Pulled By: osalpekar

fbshipit-source-id: bc706c6ae4285d4085dc5f0223ea41d8fc290f1c

Summary:
Set the directory of JUnitText XML file to the one where test-infra picks up and put them in summary.

Example: https://github.com/pytorch/audio/actions/runs/5136305988

Pull Request resolved: https://github.com/pytorch/audio/pull/3394

Differential Revision: D46328832

Pulled By: mthrok

fbshipit-source-id: f0b5020a911ca4ec09345a965bdec769300859f0

Summary:
Windows GPU workflows

Pull Request resolved: https://github.com/pytorch/audio/pull/3364

Reviewed By: mthrok

Differential Revision: D46292403

Pulled By: atalman

fbshipit-source-id: ee3c6f8082ca77bdc1ffdb930c59fa5a9cb25a4a

Summary:
Disable failing GPU unit test.
See associated issue: https://github.com/pytorch/audio/issues/3376

Pull Request resolved: https://github.com/pytorch/audio/pull/3384

Reviewed By: mthrok

Differential Revision: D46279324

Pulled By: atalman

fbshipit-source-id: 3a606bb992e0261451f48d1fb458e054f7fd5583

Summary:
Continuing with the job migrations from CCI to Nova, this PR introduces the Windows CPU Unittest job as a Nova workflow.

The job is passing: https://github.com/pytorch/audio/actions/runs/5094569687/jobs/9159020192?pr=3329.

Pull Request resolved: https://github.com/pytorch/audio/pull/3329

Reviewed By: huydhn

Differential Revision: D46265649

Pulled By: atalman

fbshipit-source-id: 7659dfbcc8ad400f2e109ff64530e1f768e82ef9

Summary:
This reverts commit d38a7854.

This is temporary revert to unblock unit test migration from circleci to github

Pull Request resolved: https://github.com/pytorch/audio/pull/3377

Reviewed By: mthrok

Differential Revision: D46230498

Pulled By: atalman

fbshipit-source-id: 000d8a9ca00750fc1ca61f4c2cdd6e930a5ce46d

Summary:
Follow-up https://github.com/pytorch/audio/issues/3045
- Revert the removal of HW acceleration doc
- comment out FFmpeg CLI test run

Pull Request resolved: https://github.com/pytorch/audio/pull/3349

Reviewed By: nateanl

Differential Revision: D46121899

Pulled By: mthrok

fbshipit-source-id: dfc030a69f05addec73637cfb6a720c184e37323

Summary:
This commit changes the way doc is pushed.
It ammends instead of adding a new commit.

Currently each commit in gh-pages contain like 100MB of data. gh-pages branch is fetched by default when `git clone`. So the size of torchaudio repo grows significantly.

Pull Request resolved: https://github.com/pytorch/audio/pull/3345

Reviewed By: nateanl

Differential Revision: D46136612

Pulled By: mthrok

fbshipit-source-id: 39479ee5d1a6888254ef50f0db252453d976d183

Summary:
CC atalman malfet

Pull Request resolved: https://github.com/pytorch/audio/pull/3360

Reviewed By: mthrok

Differential Revision: D46150898

Pulled By: atalman

fbshipit-source-id: 985a0ef69406f48fb15f239d6b16616c0a5379f5

Summary:
As discussed in the [Torchaudio Migration Proposal](https://docs.google.com/document/d/1PF8biwiGzsjzfEBM78mlLiRrkcsGsvuYkeqkI66Ym8A/edit), this PR moves MacOS unittest job to Nova tooling. Note that this does not touch anything within the existing CircleCI job at the moment.

Passing job: https://github.com/pytorch/audio/actions/runs/4932497525/jobs/8815581251?pr=3324

Pull Request resolved: https://github.com/pytorch/audio/pull/3324

Reviewed By: atalman, mthrok

Differential Revision: D46113524

Pulled By: osalpekar

fbshipit-source-id: d048d300489f992fa187628cb6744d95ab4fb68a

Summary:
As discussed in the [Torchaudio Migration Proposal](https://docs.google.com/document/d/1PF8biwiGzsjzfEBM78mlLiRrkcsGsvuYkeqkI66Ym8A/edit), this PR moves the Linux CPU unittest job to Nova tooling. Note that this does not disable the existing CircleCI job at the moment.

Passing Job: https://github.com/pytorch/audio/actions/runs/4986115298/jobs/8926499354?pr=3323

Pull Request resolved: https://github.com/pytorch/audio/pull/3323

Reviewed By: atalman, mthrok

Differential Revision: D46113506

Pulled By: osalpekar

fbshipit-source-id: 1778c360e17b9d02c63bcc60100834c75798d380

Summary:
This commit add the step to build FFmpeg with GPU decoder in build_doc job so that we can use GPU decoder/encoder in documentations.

Pull Request resolved: https://github.com/pytorch/audio/pull/3045

Reviewed By: nateanl

Differential Revision: D45965739

Pulled By: mthrok

fbshipit-source-id: c167eb3ef347860a51efa906068fa2daa556f017

Summary:
This commit upgrade the version of FFmpeg compiled against TorchAudio binary distribution to 5.0.4.

FFmpeg 5.0 was released in Jan 2022, and many package managers provide a version of FFmpeg v5.
Conda-forge lists 5.1 for all the platforms TorchAudio supports.https://anaconda.org/conda-forge/ffmpeg

Pull Request resolved: https://github.com/pytorch/audio/pull/3298

Reviewed By: hwangjeff

Differential Revision: D45865599

Pulled By: mthrok

fbshipit-source-id: d95638eb80daaf477a710a992f4ead9b9009bb9b

Summary:
Switch windows nightly builds to GHA

Similar to: https://github.com/pytorch/vision/pull/7578

Pull Request resolved: https://github.com/pytorch/audio/pull/3330

Reviewed By: mthrok

Differential Revision: D45871892

Pulled By: atalman

fbshipit-source-id: 817490a2abcaffceec5174c624f9e7d0377bbc4a

Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/3326

Reviewed By: hwangjeff

Differential Revision: D45760678

Pulled By: mthrok

fbshipit-source-id: 79b5d846c93516ca90c9700279124a9a04470242

Summary:
Fixes the regression caused by build_doc job GHA migration. The version number is not properly set.

Pull Request resolved: https://github.com/pytorch/audio/pull/3310

Reviewed By: nateanl

Differential Revision: D45607829

Pulled By: mthrok

fbshipit-source-id: 3450a38fa6982fcc56676a80144e9eed1aad02ec

Summary:
Follow-up of https://github.com/pytorch/audio/issues/3292

Doc deployment is gated by branch_name == nightly, but nightly branch fires push and PR events and there will be two deployment jobs.

This commit specify push event.

Pull Request resolved: https://github.com/pytorch/audio/pull/3294

Reviewed By: hwangjeff

Differential Revision: D45501983

Pulled By: mthrok

fbshipit-source-id: 8eb66b463800f6a30affafb27f5f2448a561cfe1

Summary:
[Nova] Add windows conda workflows
Same as: https://github.com/pytorch/vision/pull/7547

Pull Request resolved: https://github.com/pytorch/audio/pull/3288

Reviewed By: osalpekar

Differential Revision: D45456203

Pulled By: atalman

fbshipit-source-id: 067fd3b9abaeb9b7b0cd45c05b7c72982dfbfe0f

Summary: Pull Request resolved: https://github.com/pytorch/audio/pull/3292

Reviewed By: nateanl

Differential Revision: D45492729

Pulled By: mthrok

fbshipit-source-id: 11578166854c01deb50a6011550a91b87b426385

Summary:
Adding win wheels builds
Same as : https://github.com/pytorch/vision/pull/7540

Pull Request resolved: https://github.com/pytorch/audio/pull/3287

Reviewed By: osalpekar

Differential Revision: D45452770

Pulled By: atalman

fbshipit-source-id: e70ad3a8f456e805b46da3d1752c42208dadb8da

Summary:
As we migrate to use upstream flashlight-text and KenLM, this PR disable building CTC decoder by default.
This will stop shipping flashlight-text and KenLM bundle in torchaudio binary.

Ref: https://github.com/pytorch/audio/issues/3088

cc jacobkahn

Pull Request resolved: https://github.com/pytorch/audio/pull/3232

Reviewed By: hwangjeff

Differential Revision: D44650872

Pulled By: mthrok

fbshipit-source-id: 2415623abaf3cafa181135db5112d3c711137cd7

Summary:
Initial step to migrate to upstream CTC decoder.

https://circleci.com/api/v1.1/project/github/pytorch/audio/1174432/output/107/0?file=true&allocation-id=642636c6eaaa102ce75beb8e-0-build%2FB77C8AB

Pull Request resolved: https://github.com/pytorch/audio/pull/3225

Reviewed By: nateanl

Differential Revision: D44581338

Pulled By: mthrok

fbshipit-source-id: 1517fa0cd5e4ba001d136eb0dfc2a9349afcd2da

Summary:
In librosa 0.10 release, positional arguments are deprecated (see https://github.com/librosa/librosa/pull/1521 for details). The PR fixes the HiFiGAN unit test by using keyword arguments for `librosa.filters.mel` function.

Pull Request resolved: https://github.com/pytorch/audio/pull/3185

Reviewed By: mthrok

Differential Revision: D44218852

Pulled By: nateanl

fbshipit-source-id: 6171f7bec6a2144917697c1d640e701d95ec60d7

Summary:
This commit adds CUDA frame support to FilterGraph

It initializes and attaches CUDA frames context to FilterGraph,
so that CUDA frames can be processed in FilterGraph.

As a result, it enables
1. CUDA filter support such as `scale_cuda`
2. Properly retrieve the pixel format coming out of FilterGraph when
   CUDA HW acceleration is enabled. (currently it is reported as "cuda")

Resolves https://github.com/pytorch/audio/issues/3159

Pull Request resolved: https://github.com/pytorch/audio/pull/3183

Reviewed By: hwangjeff

Differential Revision: D44183722

Pulled By: mthrok

fbshipit-source-id: 522d21039c361ddfaa87fa89cf49c19d210ac62f

Summary:
Add triggers for RC branches and tags to all build workflows. This will ensure that the release-candidate builds will run with `CHANNEL=test`.

Pull Request resolved: https://github.com/pytorch/audio/pull/3057

Reviewed By: atalman

Differential Revision: D43279657

Pulled By: osalpekar

fbshipit-source-id: 5abf3994b9b4a4897f53c540bd1db6c3d624b3e0

Summary:
So far Linux and MacOS were tested to work fine out of the box. This PR is created to verify this -- disabled windows jobs and configs for now.

Pull Request resolved: https://github.com/pytorch/audio/pull/3039

Reviewed By: osalpekar

Differential Revision: D43174745

Pulled By: weiwangmeta

fbshipit-source-id: 81766905256e03c5a01cb5448a350f5d409ca4b8

Summary:
The first step to migrate doc build to GHA.

Pull Request resolved: https://github.com/pytorch/audio/pull/3043

Reviewed By: xiaohui-zhang

Differential Revision: D43110816

Pulled By: mthrok

fbshipit-source-id: 91de5f3ac567188e7030f14c2827a202a1901f1a

Summary:
Switch to Nova M1 Conda

Pull Request resolved: https://github.com/pytorch/audio/pull/2908

Reviewed By: seemethere, osalpekar

Differential Revision: D43093605

Pulled By: DanilBaibak

fbshipit-source-id: 9e44f26cfb87e277c3808ee59f50218b4629e86e

Summary:
Add GitHub Action-based GPU test jobs.
- It seems that there is 2 hour upper cap so only running CUDA/GPU tests.
- Since Kaldi related features are not available, they are disabled.

Pull Request resolved: https://github.com/pytorch/audio/pull/3029

Reviewed By: hwangjeff

Differential Revision: D42983800

Pulled By: mthrok

fbshipit-source-id: 47fefe39c635d1c73ad6799ddacefd2666fe5403

Summary:
Switch to Nova Linux Conda build.

Pull Request resolved: https://github.com/pytorch/audio/pull/2899

Reviewed By: seemethere, osalpekar, mthrok

Differential Revision: D42416835

Pulled By: DanilBaibak

fbshipit-source-id: 70886c4ff6f3243b80059be9385269cc0f2d4764

Summary:
Switch to Nova MacOS and M1 Wheels. This PR is a step in migrating from CircleCI to the Nova workflow.

- [x] Disable the CircleCI builds for MacOS Wheel.
- [x] Disable the CircleCI builds for M1 Wheel.
- [x] Enable the Nova workflow for MacOS Wheel.
- [x] Enable the Nova workflow for M1 Wheel.

Pull Request resolved: https://github.com/pytorch/audio/pull/2907

Reviewed By: osalpekar, mthrok

Differential Revision: D42040965

Pulled By: DanilBaibak

fbshipit-source-id: b87f028cf5686bf97265109591fb0a8c1190324c

Summary:
Switch to Nova Linux Wheel build.

- [x] Disable the CircleCI builds for Linux Wheel.
- [x] Enable the Nova workflow for Linux Wheel.

~The Linux Wheel Python3.8 build has been kept because it is a dependency for the `docstring_parameters_sync` job.~ As Omkar pointed out, Docstring Parameters Sync also runs on GHA (https://github.com/pytorch/audio/actions/runs/3638187635/jobs/6140090209). So, we completely switched to the Nova Linux Wheel build.

Pull Request resolved: https://github.com/pytorch/audio/pull/2896

Reviewed By: mthrok

Differential Revision: D41994993

Pulled By: DanilBaibak

fbshipit-source-id: 2bafdbe1b62ef8fa194ce96f4d4667a3ed3dc44f

Summary:
Added missed build workflows for MacOS and Linux:

- [x] Linux conda
- [x] MacOS conda

This does not change the existing builds/uploads in CircleCI, and should not break any existing jobs/workflows. This is just to add back workflows for the MacOS and Linux conda builds with Nova.

We will create a workflow (most likely in test-infra) that does this comparison between the binaries to ensure there is parity between the binaries before we start uploading with Nova.

Pull Request resolved: https://github.com/pytorch/audio/pull/2800

Reviewed By: osalpekar

Differential Revision: D41181467

Pulled By: DanilBaibak

fbshipit-source-id: a5c5d4dcfdd778b4045203f6016c20fb42daa01b

Summary:
Adding Nova Reusable Workflow for M1 Wheels Build. Once this has been running well for a while, we can replace the old `build-m1-binaries.yml` workflow.

Pull Request resolved: https://github.com/pytorch/audio/pull/2839

Reviewed By: DanilBaibak

Differential Revision: D41195316

Pulled By: osalpekar

fbshipit-source-id: f3754043f384b1645e5fcfaebf465f6839f72461