Skip to content

GitLab

Switch branch/tag
  1. 08 Jun, 2023 1 commit
  3. 02 Jun, 2023 1 commit
    • moto's avatar
      [BC-Breaking] Remove compute_kaldi_pitch (#3368) · 5bbbb1d5
      moto authored 
      Summary:
This commit removes compute_kaldi_pitch function and the underlying Kaldi integration from torchaudio.

Kaldi pitch function was added in a short period of time by integrating the original Kaldi implementation, instead of reimplementing it in PyTorch.

The Kaldi integration employed a hack which replaces the base vector/matrix implementation of Kaldi with PyTorch Tensor so that there is only one blas library within torchaudio.

Recently, we are making torchaudio more lean, and we don't see a wide adoption of kaldi_pitch feature, so we decided to remove them.

See some of the discussion https://github.com/pytorch/audio/issues/1269

Pull Request resolved: https://github.com/pytorch/audio/pull/3368

Differential Revision: D46406176

Pulled By: mthrok

fbshipit-source-id: ee5e24d825188f379979ddccd680c7323b119b1e
      5bbbb1d5
  5. 01 Jun, 2023 2 commits
    • Omkar Salpekar's avatar
      [Nova] Deleting Remaining CircleCI jobs (#3399) · cc89f743
      Omkar Salpekar authored 
      Summary:
This job completely deletes the CircleCI `config.yml`. Here is what was remaining in the config at the point of deletion:

Used Jobs:
* **Lint** - Now running on Nova - see https://github.com/pytorch/audio/actions/runs/5144082942 for an example run on the latest PR in trunk
* **CircleCI Consistency** - Not needed anymore now if there is no CCI config.

Unused Jobs:
* **build-ffmpeg-$OS** - For the build jobs, we are already building FFMPEG from source as part of the Nova workflows.
* **download-third-parties** - This is caching. We currently do not have caching in Nova jobs, but atalman is working on adding support for this as a future optimization.

Pull Request resolved: https://github.com/pytorch/audio/pull/3399

Reviewed By: mthrok

Differential Revision: D46363921

Pulled By: osalpekar

fbshipit-source-id: 8abf5b0c1612c3492908fb2f5797e6b0a3c70766
      cc89f743
    • Omkar Salpekar's avatar
      Delete CCI Linux and MacOS Unittest Jobs (#3391) · d5d94b7e
      Omkar Salpekar authored 
      Summary:
Deprecates the Linux and MacOS Unittest jobs now that they've been running on Nova for over a week.

Aside: There was also a stylecheck job that was dependent on the Linux Unittest job. I also put up https://github.com/pytorch/audio/pull/3390 to move that stylecheck job to Nova. I'm happy to reintroduce the CCI stylecheck job standalone in CCI if we want the Nova version to run on main for a week.

Pull Request resolved: https://github.com/pytorch/audio/pull/3391

Reviewed By: mthrok

Differential Revision: D46324198

Pulled By: osalpekar

fbshipit-source-id: 2115748e153c5dee1a38db2b6230acebc4f56927
      d5d94b7e
  7. 31 May, 2023 2 commits
  9. 30 May, 2023 1 commit
  11. 29 May, 2023 1 commit
  13. 26 May, 2023 2 commits
  15. 24 May, 2023 1 commit
  17. 23 May, 2023 1 commit
  19. 22 May, 2023 1 commit
  21. 16 May, 2023 1 commit
  23. 15 May, 2023 1 commit
  25. 03 May, 2023 1 commit
  27. 01 May, 2023 1 commit
  29. 11 Apr, 2023 1 commit
  31. 07 Apr, 2023 1 commit
  33. 04 Apr, 2023 2 commits
    • moto's avatar
      Disable CTC decoder bundle by default (#3232) · 3844a2bd
      moto authored 
      Summary:
As we migrate to use upstream flashlight-text and KenLM, this PR disable building CTC decoder by default.
This will stop shipping flashlight-text and KenLM bundle in torchaudio binary.

Ref: https://github.com/pytorch/audio/issues/3088

cc jacobkahn

Pull Request resolved: https://github.com/pytorch/audio/pull/3232

Reviewed By: hwangjeff

Differential Revision: D44650872

Pulled By: mthrok

fbshipit-source-id: 2415623abaf3cafa181135db5112d3c711137cd7
      3844a2bd
    • moto's avatar
      Remove linux GPU unit test from CircleCI (#3231) · 0d57a3af
      moto authored 
      Summary:
Linux GPU unit test on CircleCI relies on custom Docker image with CUDA 10.2.

PyTorch 2.0 does not support CUDA 10, so these tests have not run for a while.

We have GPU tests on GHA for Linux, so we can get rid of them.

Windows GPU tests are not ported to GHA yet, but they are still working on CircleCI, so we don't delete them yet.

Pull Request resolved: https://github.com/pytorch/audio/pull/3231

Reviewed By: hwangjeff

Differential Revision: D44639302

Pulled By: mthrok

fbshipit-source-id: c1fd39f4805a50a12af4259d423985fe453fd229
      0d57a3af
  35. 03 Apr, 2023 1 commit
  37. 21 Mar, 2023 1 commit
  39. 20 Mar, 2023 1 commit
    • moto's avatar
      Support CUDA frame in FilterGraph (#3183) · c5b96558
      moto authored 
      Summary:
This commit adds CUDA frame support to FilterGraph

It initializes and attaches CUDA frames context to FilterGraph,
so that CUDA frames can be processed in FilterGraph.

As a result, it enables
1. CUDA filter support such as `scale_cuda`
2. Properly retrieve the pixel format coming out of FilterGraph when
   CUDA HW acceleration is enabled. (currently it is reported as "cuda")

Resolves https://github.com/pytorch/audio/issues/3159

Pull Request resolved: https://github.com/pytorch/audio/pull/3183

Reviewed By: hwangjeff

Differential Revision: D44183722

Pulled By: mthrok

fbshipit-source-id: 522d21039c361ddfaa87fa89cf49c19d210ac62f
      c5b96558
  41. 04 Mar, 2023 1 commit
    • Zhaoheng Ni's avatar
      Fix linux gpu tests (#3144) · b96a7ebb
      Zhaoheng Ni authored 
      Summary:
Environment variable `TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MACOS ` needs to be added when running the bash script

Pull Request resolved: https://github.com/pytorch/audio/pull/3144

Reviewed By: mthrok

Differential Revision: D43807178

Pulled By: nateanl

fbshipit-source-id: 27c57d2efaed5519a12aa027967968895f357c67
      b96a7ebb
  43. 03 Mar, 2023 1 commit
  45. 02 Mar, 2023 1 commit
  47. 17 Feb, 2023 1 commit
  49. 14 Feb, 2023 1 commit
  51. 10 Feb, 2023 1 commit
  53. 08 Feb, 2023 1 commit
  55. 07 Feb, 2023 1 commit
    • juan.azcarreta.ortiz's avatar
      Add playback function (#3026) · 2ead941e
      juan.azcarreta.ortiz authored 
      Summary:
Allows user to play audio through the
device speaker.

Pull Request resolved: https://github.com/pytorch/audio/pull/3026

Test Plan:
Created a new test that mocks a call to the write audio chunk method from StreamWriter. To run the test:

`pytest test/torchaudio_unittest/io/_playback_test.py`

Reviewed By: mthrok

Differential Revision: D43082062

Pulled By: jazcarretao

fbshipit-source-id: 01a85b32ce925687a633d1208d15d54556e89dd8
      2ead941e
  57. 06 Feb, 2023 1 commit
  59. 01 Feb, 2023 3 commits
  61. 27 Jan, 2023 1 commit
  63. 14 Jan, 2023 1 commit
  65. 11 Jan, 2023 1 commit
  67. 15 Dec, 2022 1 commit
    • DanilBaibak's avatar
      Switch to Nova MacOS Wheel (#2907) · 0be8423d
      DanilBaibak authored 
      Summary:
Switch to Nova MacOS and M1 Wheels. This PR is a step in migrating from CircleCI to the Nova workflow.

- [x] Disable the CircleCI builds for MacOS Wheel.
- [x] Disable the CircleCI builds for M1 Wheel.
- [x] Enable the Nova workflow for MacOS Wheel.
- [x] Enable the Nova workflow for M1 Wheel.

Pull Request resolved: https://github.com/pytorch/audio/pull/2907

Reviewed By: osalpekar, mthrok

Differential Revision: D42040965

Pulled By: DanilBaibak

fbshipit-source-id: b87f028cf5686bf97265109591fb0a8c1190324c
      0be8423d