Skip to content

GitLab

Switch branch/tag
  1. 11 Jun, 2020 3 commits
    • moto's avatar
      Get rid of dynamic test suite generation (#716) · 08217121
      moto authored 
      `type` used in `common_utils` generates test class definition in `common_utils` and
this modifies the module state after it's imported. This is anti-pattern.
This PR get rid of the related utility functions and define test suite manually.
      08217121
    • moto's avatar
      Fix integer division (#714) · 50939b75
      moto authored
      50939b75
    • moto's avatar
      Change parameterized testing system to be compatible with unittest (#712) · d2724481
      moto authored 
      

* Change parameterized testing system to be compatible with unittest

Summary: The previous implementation of parameterized testing worked by modifying test.common_utils inplace.  This doesn't work in general because unittest's contract with test modules is such that it must be able to load the module and run the test itself.  Because the previous implementation needed to load the module and modify it, it is incompatible.

Reviewed By: mthrok

Differential Revision: D21964676
Co-authored-by: default avatarBen Mehne <bmehne@fb.com>
      d2724481
  3. 10 Jun, 2020 2 commits
    • jimchen90's avatar
      Add cmu_arctic dataset (#710) · 55b5c80c
      jimchen90 authored 
      

* Add cmu_arctic dataset

* add dataset name

* update audio test file with whitenoise.wav file

* add test text file

* update text method and file name

* update comment

* change datasets order in doc

* add line length
Co-authored-by: default avatarJi Chen <jimchen90@devfair0160.h2.fair>
      55b5c80c
    • moto's avatar
      Add sox_effects submodule and delegate sox_effects init/shutdown (#708) · c82a7f9c
      moto authored 
      There are couple of aspects of this PR that overall improves the maintainability of the code base, based on "decoupling" and "separation of concerns".

First, `sox_effects` functionalities can be either available or unavailable. From the viewpoint of `torchaudio` main module, the looser the connection between the `torchaudio` module and `torchaudio.sox_effects`, the more manageable the code base become because you can change the two modules independently. This is mostly accomplished when the definitions of `initialize_sox` and `shutdown_sox` were moved from `torchaudio.__init__` to `torchaudio.sox_effects`, but the initialization of sox effects are still happening in `torchaudio.__init__`. If we move the initialization to `sox_effects` module, the responsibility of sox initialization is moved to `sox_effects` module, along with the required module availability check etc. The main `torchaudio` module can be carefree about how the `sox_effects` module should work.

In addition to that, I found that `initialize_sox` and `shutdown_sox` are confusing because it sound like they are required for `libsox` based I/O. To make it clear, I renamed them to include `sox_effect` in function name.

Also moving functions from the original places are BC breaking itself, therefore, these functions are re-imported in `torchaudio.__init__` and renamed to match the original names. Therefore the PR is not BC breaking.
      c82a7f9c
  5. 09 Jun, 2020 2 commits
  7. 08 Jun, 2020 4 commits
  9. 05 Jun, 2020 5 commits
  11. 04 Jun, 2020 6 commits
  13. 03 Jun, 2020 3 commits
  15. 02 Jun, 2020 3 commits
  17. 01 Jun, 2020 2 commits
  19. 29 May, 2020 1 commit
  21. 28 May, 2020 1 commit
    • moto's avatar
      Separate style check from unit test (#664) · 6c3cc16d
      moto authored 
      * Separate style check from unit test

* TEST flake8 fail

* TEST clang-format fail

* Revert "TEST flake8 fail"

This reverts commit 88d90185cefe294b9a662129a05c2e26a9844fe4.

* Revert "TEST clang-format fail"

This reverts commit 93517d1ccba650a6ccd813268fd73a4fd63b252c.
      6c3cc16d
  23. 27 May, 2020 3 commits
  25. 26 May, 2020 1 commit
  27. 21 May, 2020 2 commits
  29. 20 May, 2020 2 commits